Use HttpMessageHandler instead of HttpClientHandler (#26)

Co-authored-by: Eric Busch <ebusch@gowithfloat.com>

Author: EBusch

Float.FileDownloader.Tests/DownloadRequest.Tests.cs

@@ -88,7 +88,7 @@ public async Task TestCustomHandler()
         {
             var mock = new Mock<HttpClientHandler>();
             mock.Protected().Setup<Task<HttpResponseMessage>>("SendAsync", ItExpr.IsAny<HttpRequestMessage>(), ItExpr.IsAny<CancellationToken>()).Returns(Task.FromResult(new HttpResponseMessage()));
-            await DownloadRequest.Download(new HttpRequestMessage(HttpMethod.Get, TestUriString()), TempFilePath(), clientHandler: mock.Object);
+            await DownloadRequest.Download(new HttpRequestMessage(HttpMethod.Get, TestUriString()), TempFilePath(), messageHandler: mock.Object);
             mock.Protected().Verify("SendAsync", Times.AtLeastOnce(), ItExpr.IsAny<HttpRequestMessage>(), ItExpr.IsAny<CancellationToken>());
         }
     }

Float.FileDownloader.Tests/FileDownloadRequest.Tests.cs

@@ -165,7 +165,7 @@ public async Task TestCustomHandler()
             var destination = new Uri(TempFilePath());
             var mock = new Mock<HttpClientHandler>();
             mock.Protected().Setup<Task<HttpResponseMessage>>("SendAsync", ItExpr.IsAny<HttpRequestMessage>(), ItExpr.IsAny<CancellationToken>()).Returns(Task.FromResult(new HttpResponseMessage()));
-            await FileDownloadRequest.DownloadFile(provider, file, destination, clientHandler: mock.Object);
+            await FileDownloadRequest.DownloadFile(provider, file, destination, messageHandler: mock.Object);
             mock.Protected().Verify("SendAsync", Times.AtLeastOnce(), ItExpr.IsAny<HttpRequestMessage>(), ItExpr.IsAny<CancellationToken>());
         }
 

Float.FileDownloader/DownloadRequest.cs

@@ -20,8 +20,8 @@ public static class DownloadRequest
         /// <param name="progressReporter">Optionally, a progress reporter can be provided to receive updated on download status.</param>
         /// <param name="cancellationTokenSource">Optionally, a cancellation token can be specified to allow the caller to cancel the download.</param>
         /// <param name="bufferSize">The size of the buffer for writing to disk. 4096 by default.</param>
-        /// <param name="clientHandler">Optionally, the client handler.</param>
-        public static async Task<HttpResponseMessage> Download(HttpRequestMessage request, string destination, IProgress<IDownloadBytesProgress> progressReporter = null, CancellationTokenSource cancellationTokenSource = null, int bufferSize = 4096, HttpClientHandler clientHandler = null)
+        /// <param name="messageHandler">Optionally, the message handler.</param>
+        public static async Task<HttpResponseMessage> Download(HttpRequestMessage request, string destination, IProgress<IDownloadBytesProgress> progressReporter = null, CancellationTokenSource cancellationTokenSource = null, int bufferSize = 4096, HttpMessageHandler messageHandler = null)
         {
             if (request == null)
             {
@@ -33,12 +33,12 @@ public static async Task<HttpResponseMessage> Download(HttpRequestMessage reques
                 throw new ArgumentException(nameof(destination));
             }
 
-            if (clientHandler == null)
+            if (messageHandler == null)
             {
-                clientHandler = new HttpClientHandler();
+                messageHandler = new HttpClientHandler();
             }
 
-            using (var client = new HttpClient(clientHandler))
+            using (var client = new HttpClient(messageHandler))
             {
                 if (cancellationTokenSource == null)
                 {

Float.FileDownloader/FileDownloadRequest.cs

@@ -31,8 +31,8 @@ public static class FileDownloadRequest
         /// <param name="downloadDestination">Absolute URI of the location to save the downloaded file.</param>
         /// <param name="status">Optionally, receive status updates about the download progress of the file.</param>
         /// <param name="fileProcessor">Optionally, specify an IFileProcessor to process or manipulate the file after it downloads.</param>
-        /// <param name="clientHandler">Optionally, the client handler.</param>
-        public static async Task<HttpResponseMessage> DownloadFile(IRemoteFileProvider fileProvider, IRemoteFile file, Uri downloadDestination, DownloadStatus status = null, IRemoteFileProcessor fileProcessor = null, HttpClientHandler clientHandler = null)
+        /// <param name="messageHandler">Optionally, the message handler.</param>
+        public static async Task<HttpResponseMessage> DownloadFile(IRemoteFileProvider fileProvider, IRemoteFile file, Uri downloadDestination, DownloadStatus status = null, IRemoteFileProcessor fileProcessor = null, HttpMessageHandler messageHandler = null)
         {
             if (fileProvider == null)
             {
@@ -80,7 +80,7 @@ public static async Task<HttpResponseMessage> DownloadFile(IRemoteFileProvider f
 
             try
             {
-                response = await DownloadRequest.Download(request, temporaryDownloadPath, progressReporter, token, clientHandler: clientHandler);
+                response = await DownloadRequest.Download(request, temporaryDownloadPath, progressReporter, token, messageHandler: messageHandler);
             }
             catch (Exception e)
             {