addressed review feedback

Author: skuruppu

src/database.ts

@@ -266,8 +266,6 @@ export interface GetIamPolicyOptions {
 
 /**
  * @typedef {object} GetTransactionOptions
- * * @property {boolean} [readLockMode] The read lock mode a
- *     {@link Transaction} should use while running.
  */
 export type GetTransactionOptions = Omit<RunTransactionOptions, 'timeout'>;
 

src/table.ts

@@ -1122,6 +1122,7 @@ class Table {
           requestOptions: requestOptions,
           excludeTxnFromChangeStreams: excludeTxnFromChangeStreams,
           isolationLevel: isolationLevel,
+          readLockMode: readLockMode,
         },
         (err, transaction) => {
           if (err) {

src/transaction-runner.ts

@@ -46,6 +46,10 @@ const RetryInfo = Root.fromJSON(jsonProtos).lookup('google.rpc.RetryInfo');
 export interface RunTransactionOptions {
   timeout?: number;
   requestOptions?: Pick<IRequestOptions, 'transactionTag'>;
+  /**
+   * @deprecated Use readLockMode instead.
+   */
+  optimisticLock?: boolean;
   excludeTxnFromChangeStreams?: boolean;
   isolationLevel?: IsolationLevel;
   readLockMode?: ReadLockMode;

system-test/spanner.ts

@@ -49,6 +49,7 @@ import {google} from '../protos/protos';
 import CreateDatabaseMetadata = google.spanner.admin.database.v1.CreateDatabaseMetadata;
 import CreateBackupMetadata = google.spanner.admin.database.v1.CreateBackupMetadata;
 import CreateInstanceConfigMetadata = google.spanner.admin.instance.v1.CreateInstanceConfigMetadata;
+import ReadLockMode = google.spanner.v1.TransactionOptions.ReadWrite.ReadLockMode;
 const singer = require('../test/data/singer');
 const music = singer.examples.spanner.music;
 import {util} from 'protobufjs';
@@ -9152,7 +9153,7 @@ describe('Spanner', () => {
 
       it('GOOGLE_STANDARD_SQL should use getTransaction for executing sql', async () => {
         const transaction = (
-          await DATABASE.getTransaction({optimisticLock: true})
+          await DATABASE.getTransaction({readLockMode: ReadLockMode.OPTIMISTIC})
         )[0];
 
         try {

test/database.ts

@@ -3535,9 +3535,9 @@ describe('Database', () => {
               readLockMode: ReadLockMode.PESSIMISTIC,
             };
 
-            await database.runTransaction(fakeOptions, assert.ifError);
+            await database.runTransactionAsync(fakeOptions, assert.ifError);
 
-            const options = fakeTransactionRunner.calledWith_[3];
+            const options = fakeAsyncTransactionRunner.calledWith_[3];
             assert.strictEqual(options, fakeOptions);
           });