refactor(internal/librarian/golang): use ReleaseLevels in serviceconfig.API for release level detection (#4558)

Set GAPIC option, `release-level`, from `ReleaseLevels` in
`serviceconfig.API`.

Set release-level in repo metadata according to API path and
`ReleaseLevels` in `serviceconfig.API`. This logic is ported from
legacylibrarian
([source](https://github.com/googleapis/google-cloud-go/blob/86f6198517fc41bfdbe165cfad0ffcd0e68ec367/internal/librariangen/generate/manifest.go#L140))

Fixes #4435

Author: JoeWang1127

internal/librarian/golang/generate.go

@@ -29,14 +29,11 @@ import (
 	"github.com/googleapis/librarian/internal/command"
 	"github.com/googleapis/librarian/internal/config"
 	"github.com/googleapis/librarian/internal/filesystem"
-	"github.com/googleapis/librarian/internal/semver"
 	"github.com/googleapis/librarian/internal/serviceconfig"
 )
 
 const (
-	releaseLevelAlpha = "alpha"
-	releaseLevelBeta  = "beta"
-	releaseLevelGA    = "ga"
+	releaseLevelGA = "ga"
 )
 
 var (
@@ -154,7 +151,7 @@ func generateAPI(ctx context.Context, api *config.API, library *config.Library,
 		"--go-grpc_opt=require_unimplemented_servers=false",
 	}
 	if !goAPI.ProtoOnly {
-		gapicOpts, err := buildGAPICOpts(api.Path, library, goAPI, googleapisDir)
+		gapicOpts, err := buildGAPICOpts(api.Path, goAPI, googleapisDir)
 		if err != nil {
 			return err
 		}
@@ -172,7 +169,7 @@ func generateAPI(ctx context.Context, api *config.API, library *config.Library,
 	return command.Run(ctx, args[0], args[1:]...)
 }
 
-func buildGAPICOpts(apiPath string, library *config.Library, goAPI *config.GoAPI, googleapisDir string) ([]string, error) {
+func buildGAPICOpts(apiPath string, goAPI *config.GoAPI, googleapisDir string) ([]string, error) {
 	sc, err := serviceconfig.Find(googleapisDir, apiPath, config.LanguageGo)
 	if err != nil {
 		return nil, err
@@ -207,10 +204,7 @@ func buildGAPICOpts(apiPath string, library *config.Library, goAPI *config.GoAPI
 	if trans := transport(sc); trans != "" {
 		opts = append(opts, fmt.Sprintf("transport=%s", trans))
 	}
-	level, err := releaseLevel(apiPath, library.Version)
-	if err != nil {
-		return nil, err
-	}
+	level := releaseLevel(sc)
 	opts = append(opts, "release-level="+level)
 	return opts, nil
 }
@@ -378,27 +372,12 @@ func hasRESTNumericEnums(sc *serviceconfig.API) bool {
 	return true
 }
 
-// releaseLevel determines the release level for an API based on the API path and the library's current version.
-func releaseLevel(apiPath, version string) (string, error) {
-	apiVersion := filepath.Base(apiPath)
-	if strings.Contains(apiVersion, releaseLevelAlpha) {
-		return releaseLevelAlpha, nil
-	}
-	if strings.Contains(apiVersion, releaseLevelBeta) {
-		return releaseLevelBeta, nil
-	}
-	if version == "" {
-		return releaseLevelAlpha, nil
+// releaseLevel determines the release level for an API.
+func releaseLevel(sc *serviceconfig.API) string {
+	if rl, ok := sc.ReleaseLevels[config.LanguageGo]; ok {
+		return rl
 	}
-	semverVer, err := semver.Parse(version)
-	if err != nil {
-		return "", err
-	}
-	if semverVer.Major < 1 {
-		return releaseLevelBeta, nil
-	}
-
-	return releaseLevelGA, nil
+	return releaseLevelGA
 }
 
 // transport get transport from serviceconfig.API for language Go.

internal/librarian/golang/generate_test.go

@@ -743,58 +743,39 @@ func TestHasRESTNumericEnums(t *testing.T) {
 
 func TestReleaseLevel(t *testing.T) {
 	for _, test := range []struct {
-		name    string
-		apiPath string
-		version string
-		want    string
+		name string
+		sc   *serviceconfig.API
+		want string
 	}{
 		{
-			name:    "ga",
-			apiPath: "google/cloud/secretmanager/v1",
-			version: "1.0.0",
-			want:    "ga",
-		},
-		{
-			name:    "stable with pre-GA version",
-			apiPath: "google/cloud/secretmanager/v1",
-			version: "0.11.0",
-			want:    "beta",
-		},
-		{
-			name:    "alpha",
-			apiPath: "google/cloud/secretmanager/v1alpha1",
-			want:    "alpha",
-		},
-		{
-			name:    "beta",
-			apiPath: "google/cloud/secretmanager/v1beta2",
-			want:    "beta",
+			name: "empty release levels",
+			sc:   &serviceconfig.API{},
+			want: "ga",
 		},
 		{
-			name:    "alpha in api path",
-			apiPath: "google/cloud/alphabet/v1",
-			version: "1.0.0",
-			want:    "ga",
+			name: "release levels do not have go",
+			sc: &serviceconfig.API{
+				ReleaseLevels: map[string]string{config.LanguagePython: "beta"},
+			},
+			want: "ga",
 		},
 		{
-			name:    "empty version",
-			apiPath: "google/cloud/alphabet/v1",
-			version: "",
-			want:    "alpha",
+			name: "alpha",
+			sc: &serviceconfig.API{
+				ReleaseLevels: map[string]string{config.LanguageGo: "alpha"},
+			},
+			want: "alpha",
 		},
 		{
-			name:    "empty version with beta path",
-			apiPath: "google/cloud/alphabet/v1beta1",
-			version: "",
-			want:    "beta",
+			name: "beta",
+			sc: &serviceconfig.API{
+				ReleaseLevels: map[string]string{config.LanguageGo: "beta"},
+			},
+			want: "beta",
 		},
 	} {
 		t.Run(test.name, func(t *testing.T) {
-			got, err := releaseLevel(test.apiPath, test.version)
-			if err != nil {
-				t.Error(err)
-				return
-			}
+			got := releaseLevel(test.sc)
 			if diff := cmp.Diff(test.want, got); diff != "" {
 				t.Errorf("mismatch (-want +got):\n%s", diff)
 			}
@@ -850,18 +831,13 @@ func TestBuildGAPICOpts(t *testing.T) {
 	for _, test := range []struct {
 		name          string
 		apiPath       string
-		library       *config.Library
 		goAPI         *config.GoAPI
 		googleapisDir string
 		want          []string
 	}{
 		{
 			name:    "basic case with service and grpc configs",
 			apiPath: "google/cloud/secretmanager/v1",
-			library: &config.Library{
-				Name:    "secretmanager",
-				Version: "1.2.3",
-			},
 			goAPI: &config.GoAPI{
 				ClientPackage: "secretmanager",
 				ImportPath:    "secretmanager/apiv1",
@@ -881,10 +857,6 @@ func TestBuildGAPICOpts(t *testing.T) {
 		{
 			name:    "no rest numeric enums",
 			apiPath: "google/cloud/bigquery/v2",
-			library: &config.Library{
-				Name:    "bigquery/v2",
-				Version: "1.2.3",
-			},
 			goAPI: &config.GoAPI{
 				ClientPackage: "bigquery",
 				ImportPath:    "bigquery/v2/apiv2",
@@ -897,39 +869,12 @@ func TestBuildGAPICOpts(t *testing.T) {
 				"api-service-config=" + filepath.Join(googleapisDir, "google/cloud/bigquery/v2/bigquery_v2.yaml"),
 				"grpc-service-config=" + filepath.Join(googleapisDir, "google/cloud/bigquery/v2/bigquery_grpc_service_config.json"),
 				"transport=grpc+rest",
-				"release-level=ga",
-			},
-		},
-		{
-			name:    "beta release level from version",
-			apiPath: "google/cloud/secretmanager/v1",
-			library: &config.Library{
-				Name:    "secretmanager",
-				Version: "0.2.3",
-			},
-			goAPI: &config.GoAPI{
-				ClientPackage: "secretmanager",
-				ImportPath:    "secretmanager/apiv1",
-				Path:          "google/cloud/secretmanager/v1",
-			},
-			googleapisDir: googleapisDir,
-			want: []string{
-				"go-gapic-package=cloud.google.com/go/secretmanager/apiv1;secretmanager",
-				"metadata",
-				"rest-numeric-enums",
-				"api-service-config=" + filepath.Join(googleapisDir, "google/cloud/secretmanager/v1/secretmanager_v1.yaml"),
-				"grpc-service-config=" + filepath.Join(googleapisDir, "google/cloud/secretmanager/v1/secretmanager_grpc_service_config.json"),
-				"transport=grpc+rest",
-				"release-level=beta",
+				"release-level=alpha",
 			},
 		},
 		{
 			name:    "transport override",
 			apiPath: "google/cloud/gkehub/v1",
-			library: &config.Library{
-				Name:    "gkehub",
-				Version: "1.2.3",
-			},
 			goAPI: &config.GoAPI{
 				ClientPackage: "gkehub",
 				ImportPath:    "gkehub/apiv1",
@@ -948,10 +893,6 @@ func TestBuildGAPICOpts(t *testing.T) {
 		{
 			name:    "no metadata",
 			apiPath: "google/cloud/gkehub/v1",
-			library: &config.Library{
-				Name:    "gkehub",
-				Version: "1.2.3",
-			},
 			goAPI: &config.GoAPI{
 				ClientPackage: "gkehub",
 				ImportPath:    "gkehub/apiv1",
@@ -970,11 +911,6 @@ func TestBuildGAPICOpts(t *testing.T) {
 		{
 			name:    "generator features",
 			apiPath: "google/cloud/bigquery/v2",
-			library: &config.Library{
-				Name:    "bigquery/v2",
-				Version: "1.2.3",
-				APIs:    []*config.API{{Path: "google/cloud/bigquery/v2"}},
-			},
 			goAPI: &config.GoAPI{
 				ClientPackage:            "bigquery",
 				EnabledGeneratorFeatures: []string{"F_wrapper_types_for_page_size"},
@@ -989,17 +925,12 @@ func TestBuildGAPICOpts(t *testing.T) {
 				"api-service-config=" + filepath.Join(googleapisDir, "google/cloud/bigquery/v2/bigquery_v2.yaml"),
 				"grpc-service-config=" + filepath.Join(googleapisDir, "google/cloud/bigquery/v2/bigquery_grpc_service_config.json"),
 				"transport=grpc+rest",
-				"release-level=ga",
+				"release-level=alpha",
 			},
 		},
 		{
 			name:    "no transport",
 			apiPath: "google/cloud/apigeeconnect/v1",
-			library: &config.Library{
-				Name:    "apigeeconnect",
-				Version: "1.2.3",
-				APIs:    []*config.API{{Path: "google/cloud/apigeeconnect/v1"}},
-			},
 			goAPI: &config.GoAPI{
 				ClientPackage: "apigeeconnect",
 				ImportPath:    "apigeeconnect/apiv1",
@@ -1017,11 +948,6 @@ func TestBuildGAPICOpts(t *testing.T) {
 		{
 			name:    "diregapic",
 			apiPath: "google/cloud/compute/v1",
-			library: &config.Library{
-				Name:    "compute",
-				Version: "1.2.3",
-				APIs:    []*config.API{{Path: "google/cloud/compute/v1"}},
-			},
 			goAPI: &config.GoAPI{
 				ClientPackage: "compute",
 				ImportPath:    "compute/apiv1",
@@ -1041,7 +967,7 @@ func TestBuildGAPICOpts(t *testing.T) {
 	} {
 		t.Run(test.name, func(t *testing.T) {
 			t.Parallel()
-			got, err := buildGAPICOpts(test.apiPath, test.library, test.goAPI, test.googleapisDir)
+			got, err := buildGAPICOpts(test.apiPath, test.goAPI, test.googleapisDir)
 			if err != nil {
 				t.Fatal(err)
 			}

internal/librarian/golang/repometadata.go

@@ -34,10 +34,7 @@ func generateRepoMetadata(api *serviceconfig.API, library *config.Library) error
 	if goAPI == nil {
 		return errGoAPINotFound
 	}
-	level, err := metadataReleaseLevel(api, library)
-	if err != nil {
-		return err
-	}
+	level := metadataReleaseLevel(api)
 	metadata := &repometadata.RepoMetadata{
 		APIShortname:        api.ShortName,
 		ClientDocumentation: clientDocURL(library, goAPI.ImportPath),
@@ -66,15 +63,13 @@ func distributionName(importPath string) string {
 	return fmt.Sprintf("cloud.google.com/go/%s", importPath)
 }
 
-func metadataReleaseLevel(api *serviceconfig.API, library *config.Library) (string, error) {
-	apiReleaseLevel, err := releaseLevel(api.Path, library.Version)
-	if err != nil {
-		return "", err
+func metadataReleaseLevel(api *serviceconfig.API) string {
+	version := serviceconfig.ExtractVersion(api.Path)
+	if strings.Contains(version, "alpha") || strings.Contains(version, "beta") {
+		return repoMetadataReleaseLevelPreview
 	}
-	switch apiReleaseLevel {
-	case releaseLevelGA:
-		return repoMetadataReleaseLevelStable, nil
-	default:
-		return repoMetadataReleaseLevelPreview, nil
+	if releaseLevel(api) != releaseLevelGA {
+		return repoMetadataReleaseLevelPreview
 	}
+	return repoMetadataReleaseLevelStable
 }