Skip to content

Commit 4e0f17c

Browse files
gcf-owl-bot[bot]sofislpearigeeshivanee-p
authored
chore: [datamanager] migrate generator to google-cloud-node (#7896)
* feat: add INVALID_MERCHANT_ID to the ErrorReason enum for when the merchant_id field is not valid feat: add EU_POLITICAL_ADVERTISING_DECLARATION_REQUIRED to the ErrorReason enum for campaigns missing the EU political advertising declaration PiperOrigin-RevId: 889816734 Source-Link: googleapis/googleapis@d3ad5e3 Source-Link: googleapis/googleapis-gen@2108ed1 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWFkcy1kYXRhbWFuYWdlci8uT3dsQm90LnlhbWwiLCJoIjoiMjEwOGVkMTkwYjliNGNkYjkyNzdhY2YzYjgxNTRiNjViYTNkOWVmNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: migrate generator to google-cloud-node chore: update generator system tests PiperOrigin-RevId: 896174961 Source-Link: googleapis/googleapis@2233f63 Source-Link: googleapis/googleapis-gen@c4a8c4e Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWFkcy1kYXRhbWFuYWdlci8uT3dsQm90LnlhbWwiLCJoIjoiYzRhOGM0ZWVmOTU5YWE3NDRmYjFjNjcxNDg3NWZhMjk1ZTA2YWFkMyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com> Co-authored-by: Gabe Pearhill <86282859+pearigee@users.noreply.github.com> Co-authored-by: Shivanee <46910562+shivanee-p@users.noreply.github.com>
1 parent ce3b52b commit 4e0f17c

File tree

9 files changed

+23
-25
lines changed

9 files changed

+23
-25
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
{
2-
"extends": "./node_modules/gts"
2+
"extends": "./node_modules/gts",
3+
"root": true
34
}

packages/google-ads-datamanager/protos/google/ads/datamanager/v1/error.proto

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,4 +339,11 @@ enum ErrorReason {
339339

340340
// The user list membership duration is too long.
341341
MEMBERSHIP_DURATION_TOO_LONG = 99;
342+
343+
// The `merchant_id` field is not valid.
344+
INVALID_MERCHANT_ID = 100;
345+
346+
// The customer contains non-exempt campaigns without the EU political
347+
// advertising declaration.
348+
EU_POLITICAL_ADVERTISING_DECLARATION_REQUIRED = 101;
342349
}

packages/google-ads-datamanager/protos/google/ads/datamanager/v1/partner_link_service.proto

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ service PartnerLinkService {
4848
// Google Account of the credentials is a user. If not set, defaults to the
4949
// account of the request. Format:
5050
// `accountTypes/{loginAccountType}/accounts/{loginAccountId}`
51-
// * `linked-account`: (Optional) The resource name of the account with an
52-
// established product link to the `login-account`. Format:
53-
// `accountTypes/{linkedAccountType}/accounts/{linkedAccountId}`
5451
rpc CreatePartnerLink(CreatePartnerLinkRequest) returns (PartnerLink) {
5552
option (google.api.http) = {
5653
post: "/v1/{parent=accountTypes/*/accounts/*}/partnerLinks"
@@ -70,9 +67,6 @@ service PartnerLinkService {
7067
// Google Account of the credentials is a user. If not set, defaults to the
7168
// account of the request. Format:
7269
// `accountTypes/{loginAccountType}/accounts/{loginAccountId}`
73-
// * `linked-account`: (Optional) The resource name of the account with an
74-
// established product link to the `login-account`. Format:
75-
// `accountTypes/{linkedAccountType}/accounts/{linkedAccountId}`
7670
rpc DeletePartnerLink(DeletePartnerLinkRequest)
7771
returns (google.protobuf.Empty) {
7872
option (google.api.http) = {
@@ -92,9 +86,6 @@ service PartnerLinkService {
9286
// Google Account of the credentials is a user. If not set, defaults to the
9387
// account of the request. Format:
9488
// `accountTypes/{loginAccountType}/accounts/{loginAccountId}`
95-
// * `linked-account`: (Optional) The resource name of the account with an
96-
// established product link to the `login-account`. Format:
97-
// `accountTypes/{linkedAccountType}/accounts/{linkedAccountId}`
9889
rpc SearchPartnerLinks(SearchPartnerLinksRequest)
9990
returns (SearchPartnerLinksResponse) {
10091
option (google.api.http) = {

packages/google-ads-datamanager/protos/protos.d.ts

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-ads-datamanager/protos/protos.js

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-ads-datamanager/protos/protos.json

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/google-ads-datamanager/samples/generated/v1/snippet_metadata_google.ads.datamanager.v1.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@
283283
"regionTag": "datamanager_v1_generated_PartnerLinkService_CreatePartnerLink_async",
284284
"title": "IngestionService createPartnerLink Sample",
285285
"origin": "API_DEFINITION",
286-
"description": " Creates a partner link for the given account. Authorization Headers: This method supports the following optional headers to define how the API authorizes access for the request: * `login-account`: (Optional) The resource name of the account where the Google Account of the credentials is a user. If not set, defaults to the account of the request. Format: `accountTypes/{loginAccountType}/accounts/{loginAccountId}` * `linked-account`: (Optional) The resource name of the account with an established product link to the `login-account`. Format: `accountTypes/{linkedAccountType}/accounts/{linkedAccountId}`",
286+
"description": " Creates a partner link for the given account. Authorization Headers: This method supports the following optional headers to define how the API authorizes access for the request: * `login-account`: (Optional) The resource name of the account where the Google Account of the credentials is a user. If not set, defaults to the account of the request. Format: `accountTypes/{loginAccountType}/accounts/{loginAccountId}`",
287287
"canonical": true,
288288
"file": "partner_link_service.create_partner_link.js",
289289
"language": "JAVASCRIPT",
@@ -327,7 +327,7 @@
327327
"regionTag": "datamanager_v1_generated_PartnerLinkService_DeletePartnerLink_async",
328328
"title": "IngestionService deletePartnerLink Sample",
329329
"origin": "API_DEFINITION",
330-
"description": " Deletes a partner link for the given account. Authorization Headers: This method supports the following optional headers to define how the API authorizes access for the request: * `login-account`: (Optional) The resource name of the account where the Google Account of the credentials is a user. If not set, defaults to the account of the request. Format: `accountTypes/{loginAccountType}/accounts/{loginAccountId}` * `linked-account`: (Optional) The resource name of the account with an established product link to the `login-account`. Format: `accountTypes/{linkedAccountType}/accounts/{linkedAccountId}`",
330+
"description": " Deletes a partner link for the given account. Authorization Headers: This method supports the following optional headers to define how the API authorizes access for the request: * `login-account`: (Optional) The resource name of the account where the Google Account of the credentials is a user. If not set, defaults to the account of the request. Format: `accountTypes/{loginAccountType}/accounts/{loginAccountId}`",
331331
"canonical": true,
332332
"file": "partner_link_service.delete_partner_link.js",
333333
"language": "JAVASCRIPT",
@@ -367,7 +367,7 @@
367367
"regionTag": "datamanager_v1_generated_PartnerLinkService_SearchPartnerLinks_async",
368368
"title": "IngestionService searchPartnerLinks Sample",
369369
"origin": "API_DEFINITION",
370-
"description": " Searches for all partner links to and from a given account. Authorization Headers: This method supports the following optional headers to define how the API authorizes access for the request: * `login-account`: (Optional) The resource name of the account where the Google Account of the credentials is a user. If not set, defaults to the account of the request. Format: `accountTypes/{loginAccountType}/accounts/{loginAccountId}` * `linked-account`: (Optional) The resource name of the account with an established product link to the `login-account`. Format: `accountTypes/{linkedAccountType}/accounts/{linkedAccountId}`",
370+
"description": " Searches for all partner links to and from a given account. Authorization Headers: This method supports the following optional headers to define how the API authorizes access for the request: * `login-account`: (Optional) The resource name of the account where the Google Account of the credentials is a user. If not set, defaults to the account of the request. Format: `accountTypes/{loginAccountType}/accounts/{loginAccountId}`",
371371
"canonical": true,
372372
"file": "partner_link_service.search_partner_links.js",
373373
"language": "JAVASCRIPT",

packages/google-ads-datamanager/src/v1/partner_link_service_client.ts

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -363,9 +363,6 @@ export class PartnerLinkServiceClient {
363363
* Google Account of the credentials is a user. If not set, defaults to the
364364
* account of the request. Format:
365365
* `accountTypes/{loginAccountType}/accounts/{loginAccountId}`
366-
* * `linked-account`: (Optional) The resource name of the account with an
367-
* established product link to the `login-account`. Format:
368-
* `accountTypes/{linkedAccountType}/accounts/{linkedAccountId}`
369366
*
370367
* @param {Object} request
371368
* The request object that will be sent.
@@ -473,9 +470,6 @@ export class PartnerLinkServiceClient {
473470
* Google Account of the credentials is a user. If not set, defaults to the
474471
* account of the request. Format:
475472
* `accountTypes/{loginAccountType}/accounts/{loginAccountId}`
476-
* * `linked-account`: (Optional) The resource name of the account with an
477-
* established product link to the `login-account`. Format:
478-
* `accountTypes/{linkedAccountType}/accounts/{linkedAccountId}`
479473
*
480474
* @param {Object} request
481475
* The request object that will be sent.
@@ -583,9 +577,6 @@ export class PartnerLinkServiceClient {
583577
* Google Account of the credentials is a user. If not set, defaults to the
584578
* account of the request. Format:
585579
* `accountTypes/{loginAccountType}/accounts/{loginAccountId}`
586-
* * `linked-account`: (Optional) The resource name of the account with an
587-
* established product link to the `login-account`. Format:
588-
* `accountTypes/{linkedAccountType}/accounts/{linkedAccountId}`
589580
*
590581
* @param {Object} request
591582
* The request object that will be sent.

packages/google-ads-datamanager/system-test/install.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ describe('📦 pack-n-play test', () => {
4040
packageDir: process.cwd(),
4141
sample: {
4242
description: 'JavaScript user can use the library',
43-
ts: readFileSync('./system-test/fixtures/sample/src/index.js').toString()
43+
cjs: readFileSync('./system-test/fixtures/sample/src/index.js').toString()
4444
}
4545
};
4646
await packNTest(options);

0 commit comments

Comments
 (0)