Skip to content

[java-aiplatform] proto files copied but not generated #12817

@zhumin8

Description

@zhumin8

There are these 5 proto files under proto/**/v1beta1/schema:
annotation_payload.proto
annotation_spec_color.proto
data_item_payload.proto
dataset_metadata.proto
geometry.proto

These are treated specially in generate_library.sh , they are removed from proto generation, but added back at copy.

Is there a reason to include these protos as copied protos? They are only copied over, but not used in generation at all (gapic, and grpc also produces no diff in java classes without them). What is the intention to have them listed in proto/ dir?

Under current setup, they are also included in gapic- and grpc- generation, which is probably why reflect-config.json have hints for its classes (referred classes does not exists in google-cloud-aiplatform).
e.g.

  {
    "name": "com.google.cloud.aiplatform.v1beta1.schema.VideoObjectTrackingAnnotation",
    "queryAllDeclaredConstructors": true,
    "queryAllPublicConstructors": true,
    "queryAllDeclaredMethods": true,
    "allPublicMethods": true,
    "allDeclaredClasses": true,
    "allPublicClasses": true
  },

IIUC, these should not be generated (though not harmful being in reflect-config.json), as the classes do not exists?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions