Skip to content

Commit 5a4da06

Browse files
cpovirkDagger Team
authored andcommitted
Bump minimum emulator to API Level 23.
This has been Google's typical minimum supported level, such as [in AndroidX](https://issuetracker.google.com/issues/380448311). Also, switch emulator tests to Ubuntu with KVM, as [recommended nowadays](https://github.com/marketplace/actions/android-emulator-runner#running-hardware-accelerated-emulators-on-linux-runners). RELNOTES=n/a PiperOrigin-RevId: 857192485
1 parent dba58d2 commit 5a4da06

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

.github/actions/artifact-android-emulator-tests/action.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ inputs:
99
runs:
1010
using: "composite"
1111
steps:
12+
# https://github.com/marketplace/actions/android-emulator-runner#running-hardware-accelerated-emulators-on-linux-runners
13+
- name: Enable KVM group perms
14+
run: |
15+
echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS+="static_node=kvm"' | sudo tee /etc/udev/rules.d/99-kvm4all.rules
16+
sudo udevadm control --reload-rules
17+
sudo udevadm trigger --name-match=kvm
1218
- name: 'Check out repository'
1319
uses: actions/checkout@v4
1420
- name: 'Cache Gradle files'

.github/workflows/ci.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,10 @@ jobs:
8787
# can take a while to run
8888
if: github.event_name == 'push' && github.repository == 'google/dagger' && github.ref == 'refs/heads/master'
8989
needs: bazel-build
90-
# It's recommended to run emulator tests on macOS
91-
# See https://github.com/marketplace/actions/android-emulator-runner
92-
runs-on: macos-latest
90+
runs-on: ubuntu-latest
9391
strategy:
94-
matrix: # Run on 16 (PreL), 21 (L), and 26 (O).
95-
api-level: [16, 21, 26, 30]
92+
matrix:
93+
api-level: [23, 26, 30]
9694
steps:
9795
- uses: actions/checkout@v4
9896
- uses: ./.github/actions/artifact-android-emulator-tests

0 commit comments

Comments
 (0)