Improve the error message in planned CreateMap when duplicate key exists

PiperOrigin-RevId: 851474395

Author: l46kok

common/exceptions/BUILD.bazel

@@ -46,3 +46,15 @@ java_library(
     # used_by_android
     exports = ["//common/src/main/java/dev/cel/common/exceptions:iteration_budget_exceeded"],
 )
+
+java_library(
+    name = "duplicate_key",
+    # used_by_android
+    exports = ["//common/src/main/java/dev/cel/common/exceptions:duplicate_key"],
+)
+
+java_library(
+    name = "overload_not_found",
+    # used_by_android
+    exports = ["//common/src/main/java/dev/cel/common/exceptions:overload_not_found"],
+)

common/src/main/java/dev/cel/common/exceptions/BUILD.bazel

@@ -98,3 +98,29 @@ java_library(
         "//common/annotations",
     ],
 )
+
+java_library(
+    name = "duplicate_key",
+    srcs = ["CelDuplicateKeyException.java"],
+    # used_by_android
+    tags = [
+    ],
+    deps = [
+        "//common:error_codes",
+        "//common:runtime_exception",
+        "//common/annotations",
+    ],
+)
+
+java_library(
+    name = "overload_not_found",
+    srcs = ["CelOverloadNotFoundException.java"],
+    # used_by_android
+    tags = [
+    ],
+    deps = [
+        "//common:error_codes",
+        "//common:runtime_exception",
+        "//common/annotations",
+    ],
+)

common/src/main/java/dev/cel/common/exceptions/CelDuplicateKeyException.java

@@ -0,0 +1,32 @@
+// Copyright 2026 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package dev.cel.common.exceptions;
+
+import dev.cel.common.CelErrorCode;
+import dev.cel.common.CelRuntimeException;
+import dev.cel.common.annotations.Internal;
+
+/** Indicates an attempt to create a map using duplicate keys. */
+@Internal
+public final class CelDuplicateKeyException extends CelRuntimeException {
+
+  public static CelDuplicateKeyException of(Object key) {
+    return new CelDuplicateKeyException(String.format("duplicate map key [%s]", key));
+  }
+
+  private CelDuplicateKeyException(String message) {
+    super(message, CelErrorCode.DUPLICATE_ATTRIBUTE);
+  }
+}

common/src/main/java/dev/cel/common/exceptions/CelOverloadNotFoundException.java

@@ -0,0 +1,44 @@
+// Copyright 2026 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package dev.cel.common.exceptions;
+
+import dev.cel.common.CelErrorCode;
+import dev.cel.common.CelRuntimeException;
+import dev.cel.common.annotations.Internal;
+import java.util.Collection;
+import java.util.Collections;
+
+/** Indicates that a matching overload could not be found during function dispatch. */
+@Internal
+public final class CelOverloadNotFoundException extends CelRuntimeException {
+
+  public CelOverloadNotFoundException(String functionName) {
+    this(functionName, Collections.emptyList());
+  }
+
+  public CelOverloadNotFoundException(String functionName, Collection<String> overloadIds) {
+    super(formatErrorMessage(functionName, overloadIds), CelErrorCode.OVERLOAD_NOT_FOUND);
+  }
+
+  private static String formatErrorMessage(String functionName, Collection<String> overloadIds) {
+    StringBuilder sb = new StringBuilder();
+    sb.append("No matching overload for function '").append(functionName).append("'.");
+    if (!overloadIds.isEmpty()) {
+      sb.append(" Overload candidates: ").append(String.join(", ", overloadIds));
+    }
+
+    return sb.toString();
+  }
+}

runtime/BUILD.bazel

@@ -16,6 +16,7 @@ java_library(
         "//runtime/src/main/java/dev/cel/runtime:descriptor_message_provider",
         "//runtime/src/main/java/dev/cel/runtime:function_overload",
         "//runtime/src/main/java/dev/cel/runtime:runtime_type_provider",
+        "//runtime/src/main/java/dev/cel/runtime:variable_resolver",
     ],
 )
 
@@ -263,3 +264,10 @@ java_library(
         "//runtime/src/main/java/dev/cel/runtime:concatenated_list_view",
     ],
 )
+
+java_library(
+    name = "variable_resolver",
+    exports = [
+        "//runtime/src/main/java/dev/cel/runtime:variable_resolver",
+    ],
+)

runtime/src/main/java/dev/cel/runtime/BUILD.bazel

@@ -123,12 +123,14 @@ java_library(
     deps = [
         ":evaluation_exception",
         ":evaluation_exception_builder",
+        ":function_binding",
         ":function_overload",
         ":function_resolver",
         ":resolved_overload",
         "//:auto_value",
         "//common:error_codes",
         "//common/annotations",
+        "//common/exceptions:overload_not_found",
         "@maven//:com_google_code_findbugs_annotations",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven//:com_google_guava_guava",
@@ -142,12 +144,14 @@ cel_android_library(
     deps = [
         ":evaluation_exception",
         ":evaluation_exception_builder",
+        ":function_binding_android",
         ":function_overload_android",
         ":function_resolver_android",
         ":resolved_overload_android",
         "//:auto_value",
         "//common:error_codes",
         "//common/annotations",
+        "//common/exceptions:overload_not_found",
         "@maven//:com_google_code_findbugs_annotations",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven_android//:com_google_guava_guava",
@@ -477,8 +481,6 @@ RUNTIME_SOURCES = [
     "CelRuntimeFactory.java",
     "CelRuntimeLegacyImpl.java",
     "CelRuntimeLibrary.java",
-    "CelVariableResolver.java",
-    "HierarchicalVariableResolver.java",
     "ProgramImpl.java",
     "UnknownContext.java",
 ]
@@ -611,6 +613,7 @@ java_library(
     deps = [
         ":function_binding",
         ":runtime_equality",
+        "//common:operator",
         "//common:options",
         "//common/annotations",
         "//runtime/standard:add",
@@ -668,6 +671,7 @@ cel_android_library(
     deps = [
         ":function_binding_android",
         ":runtime_equality_android",
+        "//common:operator_android",
         "//common:options",
         "//common/annotations",
         "//runtime/standard:add_android",
@@ -725,7 +729,9 @@ java_library(
     tags = [
     ],
     deps = [
+        ":evaluation_exception",
         ":function_overload",
+        "//common/exceptions:overload_not_found",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven//:com_google_guava_guava",
     ],
@@ -737,7 +743,9 @@ cel_android_library(
     tags = [
     ],
     deps = [
+        ":evaluation_exception",
         ":function_overload_android",
+        "//common/exceptions:overload_not_found",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven_android//:com_google_guava_guava",
     ],
@@ -776,7 +784,9 @@ java_library(
     ],
     deps = [
         ":evaluation_exception",
+        "//runtime:unknown_attributes",
         "@maven//:com_google_errorprone_error_prone_annotations",
+        "@maven//:com_google_guava_guava",
     ],
 )
 
@@ -787,7 +797,9 @@ cel_android_library(
     ],
     deps = [
         ":evaluation_exception",
+        "//runtime:unknown_attributes_android",
         "@maven//:com_google_errorprone_error_prone_annotations",
+        "@maven_android//:com_google_guava_guava",
     ],
 )
 
@@ -828,6 +840,7 @@ java_library(
         "//common/types:cel_types",
         "//common/values:cel_value_provider",
         "//common/values:proto_message_value_provider",
+        "//runtime:variable_resolver",
         "//runtime/standard:add",
         "//runtime/standard:int",
         "//runtime/standard:timestamp",
@@ -896,6 +909,7 @@ java_library(
         ":interpretable",
         ":program",
         "//:auto_value",
+        "//runtime:variable_resolver",
         "@maven//:com_google_errorprone_error_prone_annotations",
     ],
 )
@@ -909,6 +923,7 @@ cel_android_library(
         ":function_resolver_android",
         ":interpretable_android",
         ":program_android",
+        ":variable_resolver",
         "//:auto_value",
         "@maven//:com_google_errorprone_error_prone_annotations",
     ],
@@ -1177,7 +1192,6 @@ java_library(
     ],
     deps = [
         ":function_overload",
-        ":unknown_attributes",
         "//:auto_value",
         "//common/annotations",
         "@maven//:com_google_errorprone_error_prone_annotations",
@@ -1192,14 +1206,26 @@ cel_android_library(
     ],
     deps = [
         ":function_overload_android",
-        ":unknown_attributes_android",
         "//:auto_value",
         "//common/annotations",
         "@maven//:com_google_errorprone_error_prone_annotations",
         "@maven_android//:com_google_guava_guava",
     ],
 )
 
+java_library(
+    name = "variable_resolver",
+    srcs = [
+        "CelVariableResolver.java",
+        "HierarchicalVariableResolver.java",
+    ],
+    # used_by_android
+    tags = [
+    ],
+    deps = [
+    ],
+)
+
 java_library(
     name = "program",
     srcs = ["Program.java"],
@@ -1208,6 +1234,7 @@ java_library(
     deps = [
         ":evaluation_exception",
         ":function_resolver",
+        ":variable_resolver",
         "@maven//:com_google_errorprone_error_prone_annotations",
     ],
 )
@@ -1220,6 +1247,7 @@ cel_android_library(
     deps = [
         ":evaluation_exception",
         ":function_resolver_android",
+        ":variable_resolver",
         "//:auto_value",
         "@maven//:com_google_errorprone_error_prone_annotations",
     ],

runtime/src/main/java/dev/cel/runtime/CelFunctionBinding.java

@@ -14,8 +14,13 @@
 
 package dev.cel.runtime;
 
+import static com.google.common.base.Preconditions.checkArgument;
+
+import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableSet;
 import com.google.errorprone.annotations.Immutable;
+import java.util.Collection;
 
 /**
  * Binding consisting of an overload id, a Java-native argument signature, and an overload
@@ -35,7 +40,6 @@
  *
  * <p>Examples: string_startsWith_string, mathMax_list, lessThan_money_money
  */
-
 @Immutable
 public interface CelFunctionBinding {
   String getOverloadId();
@@ -70,4 +74,23 @@ static CelFunctionBinding from(
     return new FunctionBindingImpl(
         overloadId, ImmutableList.copyOf(argTypes), impl, /* isStrict= */ true);
   }
+
+  /** See {@link #fromOverloads(String, Collection)}. */
+  static ImmutableSet<CelFunctionBinding> fromOverloads(
+      String functionName, CelFunctionBinding... overloadBindings) {
+    return fromOverloads(functionName, ImmutableList.copyOf(overloadBindings));
+  }
+
+  /**
+   * Creates a set of bindings for a function, enabling dynamic dispatch logic to select the correct
+   * overload at runtime based on argument types.
+   */
+  static ImmutableSet<CelFunctionBinding> fromOverloads(
+      String functionName, Collection<CelFunctionBinding> overloadBindings) {
+    checkArgument(!Strings.isNullOrEmpty(functionName), "Function name cannot be null or empty");
+    checkArgument(!overloadBindings.isEmpty(), "You must provide at least one binding.");
+
+    return FunctionBindingImpl.groupOverloadsToFunction(
+        functionName, ImmutableSet.copyOf(overloadBindings));
+  }
 }