Skip to content

Commit eafcbbf

Browse files
HuYuxinAngle LUCI CQ
authored andcommitted
Vulkan: Reformat VVL error message
Remove the VVL skip messages that no longer apply. Set the messageContents1 and messageContents2 to nullptr for ease of clean up later. Bug: angleproject:399191283 Change-Id: I6d4477a6c401e6b7d2915b1fc574413be31fdc9b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6594251 Commit-Queue: Yuxin Hu <yuxinhu@google.com> Reviewed-by: Amirali Abdolrashidi <abdolrashidi@google.com> Auto-Submit: Yuxin Hu <yuxinhu@google.com>
1 parent 6542fea commit eafcbbf

1 file changed

Lines changed: 4 additions & 83 deletions

File tree

src/libANGLE/renderer/vulkan/vk_renderer.cpp

Lines changed: 4 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -465,94 +465,15 @@ constexpr vk::SkippedSyncvalMessage kSkippedSyncvalMessages[] = {
465465
}},
466466
// http://anglebug.com/399191283
467467
{"SYNC-HAZARD-WRITE-AFTER-WRITE",
468-
"vkCmdBeginRenderingKHR potentially modifies",
469-
"which was previously written during an image layout transition initiated by "
470-
"vkCmdPipelineBarrier",
471-
false,
472-
{"message_type = GeneralError", "hazard_type = WRITE_AFTER_WRITE",
473-
"access = "
474-
"VK_PIPELINE_STAGE_2_EARLY_FRAGMENT_TESTS_BIT(VK_ACCESS_2_DEPTH_STENCIL_ATTACHMENT_WRITE_"
475-
"BIT)",
476-
"prior_access = SYNC_IMAGE_LAYOUT_TRANSITION", "prior_command = vkCmdPipelineBarrier",
477-
"command = vkCmdBeginRenderingKHR"}},
478-
// http://anglebug.com/399191283
479-
{"SYNC-HAZARD-WRITE-AFTER-WRITE",
480-
"vkCmdBeginRenderPass potentially modifies",
481-
"which was previously written during an image layout transition initiated by "
482-
"vkCmdPipelineBarrier",
468+
nullptr,
469+
nullptr,
483470
false,
484-
{"message_type = GeneralError", "hazard_type = WRITE_AFTER_WRITE",
471+
{"message_type = BeginRenderingError",
485472
"access = "
486473
"VK_PIPELINE_STAGE_2_EARLY_FRAGMENT_TESTS_BIT(VK_ACCESS_2_DEPTH_STENCIL_ATTACHMENT_WRITE_"
487474
"BIT)",
488475
"prior_access = SYNC_IMAGE_LAYOUT_TRANSITION", "prior_command = vkCmdPipelineBarrier",
489-
"command = vkCmdBeginRenderPass"}},
490-
// http://anglebug.com/399191283
491-
{"SYNC-HAZARD-WRITE-AFTER-WRITE",
492-
nullptr,
493-
nullptr,
494-
false,
495-
{"message_type = GeneralError", "hazard_type = WRITE_AFTER_WRITE",
496-
"access = SYNC_IMAGE_LAYOUT_TRANSITION",
497-
"prior_access = "
498-
"VK_PIPELINE_STAGE_2_COLOR_ATTACHMENT_OUTPUT_BIT(VK_ACCESS_2_COLOR_ATTACHMENT_WRITE_BIT)",
499-
"command = vkCmdBeginRenderPass", "prior_command = vkCmdDrawIndexed",
500-
"old_layout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL",
501-
"new_layout = VK_IMAGE_LAYOUT_GENERAL"}},
502-
// http://anglebug.com/399191283
503-
{"SYNC-HAZARD-WRITE-AFTER-WRITE",
504-
nullptr,
505-
nullptr,
506-
false,
507-
{"message_type = GeneralError", "hazard_type = WRITE_AFTER_WRITE",
508-
"access = SYNC_IMAGE_LAYOUT_TRANSITION",
509-
"prior_access = "
510-
"VK_PIPELINE_STAGE_2_COLOR_ATTACHMENT_OUTPUT_BIT(VK_ACCESS_2_COLOR_ATTACHMENT_WRITE_BIT)",
511-
"command = vkCmdBeginRenderPass", "prior_command = vkCmdEndRenderPass",
512-
"old_layout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL",
513-
"new_layout = VK_IMAGE_LAYOUT_GENERAL"}},
514-
// http://anglebug.com/399191283
515-
{"SYNC-HAZARD-WRITE-AFTER-WRITE",
516-
nullptr,
517-
nullptr,
518-
false,
519-
{"message_type = GeneralError", "hazard_type = WRITE_AFTER_WRITE",
520-
"access = SYNC_IMAGE_LAYOUT_TRANSITION",
521-
"prior_access = "
522-
"VK_PIPELINE_STAGE_2_COLOR_ATTACHMENT_OUTPUT_BIT(VK_ACCESS_2_COLOR_ATTACHMENT_WRITE_BIT)",
523-
"command = vkCmdBeginRenderPass", "prior_command = vkCmdEndRenderPass",
524-
"old_layout = VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL",
525-
"new_layout = VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL"}},
526-
// http://anglebug.com/399191283
527-
{"SYNC-HAZARD-WRITE-AFTER-WRITE",
528-
nullptr,
529-
nullptr,
530-
false,
531-
{"message_type = GeneralError", "hazard_type = WRITE_AFTER_WRITE",
532-
"access = "
533-
"VK_PIPELINE_STAGE_2_COLOR_ATTACHMENT_OUTPUT_BIT(VK_ACCESS_2_COLOR_ATTACHMENT_WRITE_BIT)",
534-
"prior_access = SYNC_IMAGE_LAYOUT_TRANSITION", "command = vkCmdDrawIndexed",
535-
"prior_command = vkCmdEndRenderPass", "subcmd = 1"}},
536-
// http://anglebug.com/399191283
537-
{"SYNC-HAZARD-WRITE-AFTER-WRITE",
538-
nullptr,
539-
nullptr,
540-
false,
541-
{"message_type = GeneralError", "hazard_type = WRITE_AFTER_WRITE",
542-
"access = SYNC_IMAGE_LAYOUT_TRANSITION",
543-
"prior_access = "
544-
"VK_PIPELINE_STAGE_2_LATE_FRAGMENT_TESTS_BIT(VK_ACCESS_2_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT)",
545-
"command = vkCmdPipelineBarrier", "prior_command = vkCmdEndRenderPass"}},
546-
// http://anglebug.com/399191283
547-
{"SYNC-HAZARD-READ-AFTER-WRITE",
548-
nullptr,
549-
nullptr,
550-
false,
551-
{"message_type = GeneralError", "hazard_type = READ_AFTER_WRITE",
552-
"access = "
553-
"VK_PIPELINE_STAGE_2_COLOR_ATTACHMENT_OUTPUT_BIT(VK_ACCESS_2_COLOR_ATTACHMENT_READ_BIT)",
554-
"prior_access = SYNC_IMAGE_LAYOUT_TRANSITION", "command = vkCmdBeginRenderPass",
555-
"prior_command = vkCmdEndRenderPass", "load_op = VK_ATTACHMENT_LOAD_OP_LOAD", "subcmd = 1"}},
476+
"command = vkCmdBeginRenderingKHR", "load_op = VK_ATTACHMENT_LOAD_OP_DONT_CARE"}},
556477
// https://anglebug.com/400789178
557478
{"SYNC-HAZARD-WRITE-AFTER-WRITE",
558479
nullptr,

0 commit comments

Comments
 (0)