From 618a7a1fd1a739c03110c0f54e99e7ffa7633434 Mon Sep 17 00:00:00 2001 From: Mike Fullerton Date: Thu, 19 Mar 2026 12:10:55 -0700 Subject: [PATCH] fix: include all public headers unconditionally in umbrella header MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GIDAppCheckError.h and GIDSignInButton.h were conditionally imported in the umbrella header (GoogleSignIn.h) but declared unconditionally in the module map. This caused "umbrella header does not include header" warnings during Xcode's precompiled module generation. Both headers already have their own internal #if TARGET_OS guards, so importing them unconditionally in the umbrella header is safe — they compile to empty on unsupported platforms. --- GoogleSignIn/Sources/Public/GoogleSignIn/GoogleSignIn.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/GoogleSignIn/Sources/Public/GoogleSignIn/GoogleSignIn.h b/GoogleSignIn/Sources/Public/GoogleSignIn/GoogleSignIn.h index 6ffab4f4..d7328b03 100644 --- a/GoogleSignIn/Sources/Public/GoogleSignIn/GoogleSignIn.h +++ b/GoogleSignIn/Sources/Public/GoogleSignIn/GoogleSignIn.h @@ -13,11 +13,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -#import - -#if TARGET_OS_IOS && !TARGET_OS_MACCATALYST #import "GIDAppCheckError.h" -#endif #import "GIDConfiguration.h" #import "GIDGoogleUser.h" #import "GIDProfileData.h"