Skip to content

Remove beta warning and obsolete flag conversion for Cloud Run jobs #593

@178inaba

Description

@178inaba

TL;DR

The beta warning and the --update-secrets flag conversion logic for Cloud Run jobs appear to no longer be necessary.

Background

Cloud Run jobs support was added in v2.4.0 (April 2024) with a beta warning. Since then, approximately 20 months have passed, and the following changes have occurred:

  1. --update-secrets flag is now supported for gcloud run jobs deploy

    • The current code includes a comment stating: "There is no --update-secrets flag on jobs, but there will be in the future. At that point, we can remove this."
    • This flag is now available (verified with gcloud run jobs deploy --help)
  2. Cloud Run jobs has become a stable, mature feature

Current behavior

The following warnings are displayed on every job deployment:

Support for Cloud Run jobs in this GitHub Action is in beta and is not covered by the semver backwards compatibility guarantee.
Cloud Run does not allow updating secrets on jobs, ignoring "secrets_update_strategy" value of "merge"

Proposed changes

  1. Remove the beta warning (src/main.ts lines 171-174)
  2. Remove the --update-secrets to --set-secrets conversion logic and associated warning (src/main.ts lines 192-201)

References

  • Related commit: 32334e9 (Add support for Cloud Run jobs)
  • Release: v2.4.0

Thank you for maintaining this valuable action!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions