Merge pull request #1280 from hkad98/jkd/ty

Replace mypy with ty

Author: hkad98

.github/workflows/rw-python-tests.yaml

@@ -52,6 +52,6 @@ jobs:
       - name: Install dependencies
         run: |
           uv sync --only-group tox --only-group type
-      - name: mypy check
+      - name: type check
         run: |
-          make mypy
+          make type-check

Makefile

@@ -67,14 +67,14 @@ download:
 	$(call download_client,"export")
 	$(call download_client,automation)
 
-.PHONY: mypy
-mypy:
+.PHONY: type-check
+type-check:
 	RESULT=0; \
-	for project in $(NO_CLIENT_GD_PROJECTS_DIRS); do $(MAKE) -C packages/$${project} mypy || RESULT=$$?; done; \
+	for project in $(NO_CLIENT_GD_PROJECTS_DIRS); do $(MAKE) -C packages/$${project} type-check || RESULT=$$?; done; \
 	exit $$RESULT
 
 .PHONY: types
-types: mypy
+types: type-check
 
 .PHONY: test
 test:

packages/gooddata-dbt/mypy.ini

@@ -44,6 +44,9 @@ type = [
     "pydantic~=2.12.0",
 ]
 
+[tool.ty.analysis]
+allowed-unresolved-imports = ["deep_translator", "github"]
+
 [tool.hatch.build.targets.wheel]
 packages = ["src/gooddata_dbt"]
 

packages/gooddata-dbt/pyproject.toml

@@ -291,12 +291,12 @@ def dict_camel_to_snake(self, data: Union[dict, list]) -> Union[dict, list]:
                 else:
                     return record
         else:
-            result = {}  # type: ignore
+            result = {}
             for key, value in data.items():
                 if isinstance(value, dict):
-                    result[self.string_camel_to_snake(key)] = self.dict_camel_to_snake(value)  # type: ignore
+                    result[self.string_camel_to_snake(key)] = self.dict_camel_to_snake(value)
                 else:
-                    result[self.string_camel_to_snake(key)] = value  # type: ignore
+                    result[self.string_camel_to_snake(key)] = value
         return result
 
     def get_last_execution(self, environment_id: str, model_count: int) -> list[DbtExecution]:

packages/gooddata-dbt/src/gooddata_dbt/dbt/cloud.py

@@ -36,15 +36,15 @@ class GoodDataConfigProduct(Base):
     id: str
     name: str
     environment_setup_id: str
-    model_ids: list[str] = attr.field(default=list)
+    model_ids: list[str] = attr.field(factory=list)
     localization: Optional[GoodDataConfigLocalization] = None
     skip_tests: Optional[list[str]] = None
 
 
 @attrs.define(auto_attribs=True, kw_only=True)
 class GoodDataConfigOrganization(Base):
     gooddata_profile: str
-    data_product_ids: list[str] = attr.field(default=list)
+    data_product_ids: list[str] = attr.field(factory=list)
 
 
 @attrs.define(auto_attribs=True, kw_only=True)

packages/gooddata-dbt/src/gooddata_dbt/gooddata/config.py

@@ -46,5 +46,6 @@ def test_make_ldm():
     declarative_datasets = tables.make_declarative_datasets(data_source_id, [MODEL_ID])
     ldm = CatalogDeclarativeModel.from_dict({"ldm": declarative_datasets}, camel_case=False)
 
+    assert ldm.ldm is not None
     assert len(ldm.ldm.datasets) == 4
     assert len(ldm.ldm.date_instances) == 4

packages/gooddata-dbt/tests/test_tables.py

@@ -13,10 +13,10 @@ setenv =
 commands =
     pytest -v --cov=src/gooddata_dbt --cov-report=xml tests {posargs}
 
-[testenv:mypy]
+[testenv:type-check]
 runner = uv-venv-lock-runner
 skip_install = true
 dependency_groups =
     type
 commands =
-    mypy src/gooddata_dbt
+    uv run ty check src/gooddata_dbt

packages/gooddata-dbt/tox.ini

@@ -62,6 +62,9 @@ type = [
     "pydantic~=2.12.0",
 ]
 
+[tool.ty.analysis]
+allowed-unresolved-imports = ["multicorn"]
+
 [tool.hatch.build.targets.wheel]
 packages = ["src/gooddata_fdw"]