Skip to content

Commit d25693c

Browse files
ParzivalPavlisParzivalPavlis
committed
docs: updated theme and accessibility
risk: low
1 parent 591a595 commit d25693c

14 files changed

Lines changed: 87 additions & 68 deletions

File tree

‎docs/assets/icons/GoodDataLearn.svg‎

Lines changed: 0 additions & 4 deletions
This file was deleted.

‎docs/assets/scss/header.scss‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@
1111
align-items: center;
1212
padding: 0 20px;
1313

14+
&__menu {
15+
overflow-y: auto;
16+
}
17+
1418
&__first {
1519
top: 0;
1620
min-height: $header-first-nav-height;

‎docs/assets/scss/menu.scss‎

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@
5151

5252
&__mobile-icon {
5353
position: fixed;
54-
top: $header-first-nav-height;
54+
top: 80px;
5555
display: flex;
5656
justify-content: center;
5757
align-items: center;
5858
width: 55px;
5959
height: $header-second-nav-height;
6060
left: 10px;
61-
z-index: 32;
61+
z-index: 34;
6262
transition: $transition;
6363

6464
&::before {
@@ -83,6 +83,25 @@
8383
}
8484
}
8585

86+
&__mobile-bg {
87+
position: fixed;
88+
top: $header-first-nav-height + 1px;
89+
left: -100%;
90+
bottom: 0;
91+
width: 100%;
92+
z-index: 32;
93+
background-color: rgba($color-deep-purple, 0.5);
94+
transition: $transition;
95+
96+
@include mq(medium) {
97+
display: none;
98+
}
99+
}
100+
&__mobile-trigger:checked ~ &,
101+
&__mobile-trigger:checked ~ &__mobile-bg {
102+
left: 0;
103+
}
104+
86105
&__mobile-trigger:checked ~ & {
87106
left: 0;
88107
}
@@ -144,11 +163,10 @@
144163
position: relative;
145164
display: inline-block;
146165
flex: 1 1 auto;
147-
margin: 2px 20px 2px 0; // orig values -> 8px 20px 3px 0;
166+
margin: 8px 20px 3px 0;
148167
padding: 0 0 5px;
149168
max-width: 100%;
150169
font-size: 15px;
151-
//font-family: "Lucida Console", "Courier New", monospace;
152170
line-height: 1.5;
153171

154172
&,

‎docs/go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ go 1.20
44

55
require (
66
github.com/FortAwesome/Font-Awesome v0.0.0-20230327165841-0698449d50f2 // indirect
7-
github.com/gooddata/gooddata-docs-theme v0.0.0-20250724141246-310dd7684e82 // indirect
7+
github.com/gooddata/gooddata-docs-theme v0.0.0-20250814105944-65486e0f9cfb // indirect
88
github.com/google/docsy v0.7.1 // indirect
99
github.com/google/docsy/dependencies v0.7.1 // indirect
1010
github.com/twbs/bootstrap v5.3.1+incompatible // indirect

‎docs/go.sum‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,12 @@ github.com/gooddata/gooddata-docs-theme v0.0.0-20250724110042-81655c31f00b h1:w2
2828
github.com/gooddata/gooddata-docs-theme v0.0.0-20250724110042-81655c31f00b/go.mod h1:VVNP6Cmo+vC37RD3T/YHjyU/QdqftGY5z4G513LYyrA=
2929
github.com/gooddata/gooddata-docs-theme v0.0.0-20250724141246-310dd7684e82 h1:vetjOF/JcH99uBeMDV22JvRoPB+5rps03c72na5LMi4=
3030
github.com/gooddata/gooddata-docs-theme v0.0.0-20250724141246-310dd7684e82/go.mod h1:VVNP6Cmo+vC37RD3T/YHjyU/QdqftGY5z4G513LYyrA=
31+
github.com/gooddata/gooddata-docs-theme v0.0.0-20250729102440-7a7e8c25d60b h1:Tsi2R9UmdkJpEhdBPN870ybDU06RfEN2Hbq4+BiOzMA=
32+
github.com/gooddata/gooddata-docs-theme v0.0.0-20250729102440-7a7e8c25d60b/go.mod h1:VVNP6Cmo+vC37RD3T/YHjyU/QdqftGY5z4G513LYyrA=
33+
github.com/gooddata/gooddata-docs-theme v0.0.0-20250813103715-562a4a4e4a75 h1:swX9dIehu8bj/pIHF11NjBsiS/nEBl4vqmu8b+G530c=
34+
github.com/gooddata/gooddata-docs-theme v0.0.0-20250813103715-562a4a4e4a75/go.mod h1:VVNP6Cmo+vC37RD3T/YHjyU/QdqftGY5z4G513LYyrA=
35+
github.com/gooddata/gooddata-docs-theme v0.0.0-20250814105944-65486e0f9cfb h1:acb17FkbyBJjZ4e/DvIf5xJ2S/XkpF+fQqa9lNP+8LM=
36+
github.com/gooddata/gooddata-docs-theme v0.0.0-20250814105944-65486e0f9cfb/go.mod h1:VVNP6Cmo+vC37RD3T/YHjyU/QdqftGY5z4G513LYyrA=
3137
github.com/google/docsy v0.7.1 h1:DUriA7Nr3lJjNi9Ulev1SfiG1sUYmvyDeU4nTp7uDxY=
3238
github.com/google/docsy v0.7.1/go.mod h1:JCmE+c+izhE0Rvzv3y+AzHhz1KdwlA9Oj5YBMklJcfc=
3339
github.com/google/docsy/dependencies v0.7.1 h1:NbzYKJYMin2q50xdWSUzR2c9gCp7zR/XHDBcxklEcTQ=

‎docs/layouts/_default/baseof.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
</head>
77
<body class="td-{{ .Kind }}">
88
{{ partial "gtm-body.html" }}
9-
<header>
9+
<header aria-label="Main site header">
1010
{{ partial "navbar.html" . }}
1111
</header>
1212
<div class="container-fluid td-default td-outer">
13-
<main role="main" class="td-main">
13+
<main role="main" class="td-main" aria-label="Article content">
1414
{{ block "main" . }}{{ end }}
1515
</main>
1616
{{ partialCached "footer.html" . }}

‎docs/layouts/docs/baseof.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
</head>
1111
<body class="td-{{ .Kind }}">
1212
{{ partial "gtm-body.html" }}
13-
<header>
13+
<header aria-label="Main site header">
1414
{{ partial "navbar.html" . }}
1515
</header>
1616
<div class="container-fluid td-outer">
@@ -22,7 +22,7 @@
2222
<div class="d-none d-xl-block col-xl-2 td-toc d-print-none">
2323
{{ partial "toc.html" . }}
2424
</div>
25-
<main class="col-12 col-md-8 col-xl-7 pl-md-5" role="main">
25+
<main class="col-12 col-md-8 col-xl-7 pl-md-5" role="main" aria-label="Article content">
2626
{{ partial "version-banner.html" . }}
2727
{{ if not .Site.Params.ui.breadcrumb_disable }}{{ partial "breadcrumb.html" . }}{{ end }}
2828
{{ if .Draft }}

‎docs/layouts/partials/footer.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{{ $footer := getJSON "https://www.gooddata.com/learn-assets/js/footer-definition.json" }}
22

3-
<footer class="gd-footer">
3+
<footer class="gd-footer" aria-label="Page footer">
44
{{ if $footer.footer.bannerLinks }}
55
<ul class="gd-footer-banner-links gd-footer-links">
66
{{ range $index, $link := $footer.footer.bannerLinks }}

‎docs/layouts/partials/header-menu.html‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
<nav class="gd-docs-header-nav__center gd-header" aria-label="Main">
2+
<input type="checkbox" role="button" id="gd-header-mobile-menu-trigger-input" name="gd-header-mobile-menu-trigger-input" class="gd-header-mobile gd-header-mobile-menu-trigger-input" aria-label="Open navigation menu" aria-controls="gd-header-mobile-menu" aria-expanded="false">
3+
<label tabindex="0" for="gd-header-mobile-menu-trigger-input" class="gd-header-mobile gd-header-mobile-menu-trigger"><span></span></label>
4+
<ul class="gd-docs-header-nav__menu gd-header-links">
5+
<li class="gd-docs-header-nav__menuitem gd-header-link-item gd-header-link-item-mobile-only">
6+
<a href="https://www.gooddata.com/learn/" class="gd-docs-header-nav__menulink gd-header-link gd-header-link__main">Learn</a>
7+
</li>
8+
<li class="gd-docs-header-nav__menuitem gd-header-link-item">
9+
<a href="https://university.gooddata.com/" class="gd-docs-header-nav__menulink gd-header-link">University</a>
10+
</li>
11+
<li class="gd-docs-header-nav__menuitem gd-header-link-item">
12+
<a href="https://community.gooddata.com/" class="gd-docs-header-nav__menulink gd-header-link">Community</a>
13+
</li>
14+
<li class="gd-docs-header-nav__menuitem gd-header-link-item">
15+
<a href="https://www.gooddata.com/docs/cloud/" class="gd-docs-header-nav__menulink gd-header-link gd-header-link__active">Documentation</a>
16+
</li>
17+
<li class="gd-docs-header-nav__menuitem gd-header-link-item">
18+
<a href="https://support.gooddata.com/hc/en-us" class="gd-docs-header-nav__menulink gd-header-link">Support</a>
19+
</li>
20+
<li class="gd-docs-header-nav__menuitem gd-header-link-item gd-header-link-item-mobile-only">
21+
<a href="https://www.gooddata.com/" class="button">Go to GoodData.com</a>
22+
</li>
23+
</ul>
24+
</nav>

‎docs/layouts/partials/navbar-breadcrumb.html‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<nav class="gd-docs-header-nav__left" aria-label="Breadcrumbs">
2+
<ul class="gd-breadcrumb">
3+
<li class="gd-breadcrumb-item">
4+
<a href="https://www.gooddata.com/docs/">All Products</a>
5+
</li>
6+
<li class="gd-breadcrumb-item">
7+
<span> &nbsp;Python SDK</span>
8+
</li>
9+
</ul>
10+
</nav>

0 commit comments

Comments
 (0)