feat: adapt ty findings

JIRA: TRIVIAL
risk: low

Author: hkad98

packages/gooddata-dbt/src/gooddata_dbt/dbt/cloud.py

@@ -291,12 +291,12 @@ def dict_camel_to_snake(self, data: Union[dict, list]) -> Union[dict, list]:
                 else:
                     return record
         else:
-            result = {}  # type: ignore
+            result = {}
             for key, value in data.items():
                 if isinstance(value, dict):
-                    result[self.string_camel_to_snake(key)] = self.dict_camel_to_snake(value)  # type: ignore
+                    result[self.string_camel_to_snake(key)] = self.dict_camel_to_snake(value)
                 else:
-                    result[self.string_camel_to_snake(key)] = value  # type: ignore
+                    result[self.string_camel_to_snake(key)] = value
         return result
 
     def get_last_execution(self, environment_id: str, model_count: int) -> list[DbtExecution]:

packages/gooddata-dbt/src/gooddata_dbt/gooddata/config.py

@@ -36,15 +36,15 @@ class GoodDataConfigProduct(Base):
     id: str
     name: str
     environment_setup_id: str
-    model_ids: list[str] = attr.field(default=list)
+    model_ids: list[str] = attr.field(factory=list)
     localization: Optional[GoodDataConfigLocalization] = None
     skip_tests: Optional[list[str]] = None
 
 
 @attrs.define(auto_attribs=True, kw_only=True)
 class GoodDataConfigOrganization(Base):
     gooddata_profile: str
-    data_product_ids: list[str] = attr.field(default=list)
+    data_product_ids: list[str] = attr.field(factory=list)
 
 
 @attrs.define(auto_attribs=True, kw_only=True)

packages/gooddata-dbt/tests/test_tables.py

@@ -46,5 +46,6 @@ def test_make_ldm():
     declarative_datasets = tables.make_declarative_datasets(data_source_id, [MODEL_ID])
     ldm = CatalogDeclarativeModel.from_dict({"ldm": declarative_datasets}, camel_case=False)
 
+    assert ldm.ldm is not None
     assert len(ldm.ldm.datasets) == 4
     assert len(ldm.ldm.date_instances) == 4

packages/gooddata-fdw/src/gooddata_fdw/environment.py

@@ -67,18 +67,18 @@ class TableDefinitionStub:
         def __init__(
             self,
             table_name: str,
-            columns: list[ColumnDefinition],  # type: ignore
-            options: dict[str, str],  # type: ignore
+            columns: list[ColumnDefinition],
+            options: dict[str, str],
         ) -> None:
             self.table_name = table_name
             self.columns = columns
             self.options = options
-            self.col_idx = dict([(c.column_name, c) for c in columns])  # type: ignore
+            self.col_idx = dict([(c.column_name, c) for c in columns])
 
     TableDefinition = TableDefinitionStub
 
     class ForeignDataWrapperStub:
-        def __init__(self, options: dict[str, str], columns: dict[str, ColumnDefinition]) -> None:  # type: ignore
+        def __init__(self, options: dict[str, str], columns: dict[str, ColumnDefinition]) -> None:
             self.options = options
             self.columns = columns
 
@@ -90,10 +90,10 @@ def import_schema(
             options: dict[str, str],
             restriction_type: Optional[str],
             restricts: list[str],
-        ) -> list[TableDefinition]:  # type: ignore
+        ) -> list[TableDefinition]:
             return NotImplemented
 
-        def execute(self, quals: list[Qual], columns: list[str], sortkeys: Optional[list[Any]] = None):  # type: ignore
+        def execute(self, quals: list[Qual], columns: list[str], sortkeys: Optional[list[Any]] = None):
             pass
 
     ForeignDataWrapper = ForeignDataWrapperStub

packages/gooddata-fdw/src/gooddata_fdw/fdw.py

@@ -34,7 +34,7 @@ def __init__(self, options: dict[str, str], columns: dict[str, ColumnDefinition]
         self._executor = ExecutorFactory.create(InitData(gd_sdk, self._server_options, self._table_options, columns))
         self._executor.validate_columns_def()
 
-    def execute(self, quals: list[Qual], columns: list[str], sortkeys: Optional[list[Any]] = None):  # type: ignore
+    def execute(self, quals: list[Qual], columns: list[str], sortkeys: Optional[list[Any]] = None):
         _log_debug(f"query in fdw with {self._server_options}; {self._table_options}; columns {columns}; quals={quals}")
         try:
             return self._executor.execute(quals, columns, sortkeys)
@@ -50,7 +50,7 @@ def import_schema(
         options: dict[str, str],
         restriction_type: Optional[str],
         restricts: list[str],
-    ) -> list[TableDefinition]:  # type: ignore
+    ) -> list[TableDefinition]:
         _log_info(
             f"import fdw {schema} (srv_options={srv_options}, "
             f"options={options}, restriction_type={restriction_type}, restricts={restricts})"
@@ -76,14 +76,14 @@ def import_schema(
             raise e
 
     @property
-    def rowid_column(self):  # type: ignore
+    def rowid_column(self):
         return super().rowid_column
 
-    def insert(self, values):  # type: ignore
+    def insert(self, values):
         return super().insert(values)
 
-    def update(self, oldvalues, newvalues):  # type: ignore
+    def update(self, oldvalues, newvalues):
         return super().update(oldvalues, newvalues)
 
-    def delete(self, oldvalues):  # type: ignore
+    def delete(self, oldvalues):
         return super().delete(oldvalues)

packages/gooddata-fdw/src/gooddata_fdw/naming.py

@@ -60,7 +60,7 @@ class InsightColumnNamingStrategy:
     def col_name_for_attribute(self, attr: sdk.VisualizationAttribute) -> str:
         raise NotImplementedError()
 
-    def col_name_for_metric(self, attr: sdk.VisualizationMetric) -> str:
+    def col_name_for_metric(self, metric: sdk.VisualizationMetric) -> str:
         raise NotImplementedError()
 
 

packages/gooddata-flexconnect/tests/function/test_flex_fun_execution_context.py

@@ -22,6 +22,7 @@ def test_report_execution_context_deser(sample_report_execution_context_dict):
     """
     deserialized = ExecutionContext.from_dict(sample_report_execution_context_dict)
 
+    assert deserialized is not None
     assert deserialized.execution_type == ExecutionType.REPORT
     assert deserialized.organization_id == "default"
     assert deserialized.label_elements_execution_request is None
@@ -42,14 +43,17 @@ def test_label_elements_execution_context_deser(sample_label_execution_context_d
     """
     deserialized = ExecutionContext.from_dict(sample_label_execution_context_dict)
 
+    assert deserialized is not None
     assert deserialized.execution_type == ExecutionType.LABEL_ELEMENTS
     assert deserialized.organization_id == "default"
     assert deserialized.report_execution_request is None
 
     assert deserialized.label_elements_execution_request is not None
     assert isinstance(deserialized.label_elements_execution_request.filter_by, CatalogFilterBy)
     assert deserialized.label_elements_execution_request.filter_by.label_type == "REQUESTED"
+    assert deserialized.label_elements_execution_request.depends_on is not None
     assert isinstance(deserialized.label_elements_execution_request.depends_on[0], CatalogDependsOn)
+    assert deserialized.label_elements_execution_request.validate_by is not None
     assert isinstance(deserialized.label_elements_execution_request.validate_by[0], CatalogValidateByItem)
 
     assert isinstance(deserialized.attributes[0], ExecutionContextAttribute)

packages/gooddata-flexconnect/tests/function/test_registry.py

@@ -15,11 +15,11 @@ def fake_ctx():
     # need to ensure that the functions are registered correctly and that
     # their on_load() initializers are called
     return ServerContext(
-        config=None,
+        config=None,  # type: ignore[arg-type]
         location=pyarrow.flight.Location.for_grpc_tcp("localhost", 6666),
-        settings=None,
-        task_executor=None,
-        health=None,
+        settings=None,  # type: ignore[arg-type]
+        task_executor=None,  # type: ignore[arg-type]
+        health=None,  # type: ignore[arg-type]
     )
 
 

packages/gooddata-flexconnect/tests/function/testing_funs.py

@@ -1,4 +1,5 @@
 #  (C) 2024 GoodData Corporation
+from typing import Optional
 
 import pyarrow
 from gooddata_flexconnect.function.function import FlexConnectFunction
@@ -12,7 +13,7 @@ class Fun1(FlexConnectFunction):
     def call(
         self,
         parameters: dict,
-        columns: tuple[str, ...],
+        columns: Optional[tuple[str, ...]],
         headers: dict[str, list[str]],
     ) -> ArrowData:
         pass
@@ -27,7 +28,7 @@ class Fun2(FlexConnectFunction):
     def call(
         self,
         parameters: dict,
-        columns: tuple[str, ...],
+        columns: Optional[tuple[str, ...]],
         headers: dict[str, list[str]],
     ) -> ArrowData:
         pass

packages/gooddata-flexconnect/tests/json_schemas/conftest.py

@@ -2,9 +2,9 @@
 from pathlib import Path
 from typing import Any
 
+import orjson
 import pytest
 from jsonschema.validators import Draft202012Validator
-from orjson import orjson
 from referencing import Registry, Resource
 
 SCHEMAS = Path("json_schemas")