Commit 47825a5
committed
fix(gooddata-sdk): resolve ty + dbt + htmltest CI failures
Three small fixes uncovered by CI on the previous push:
- `dataset.py` (gooddata-sdk): the new `type: Literal["NORMAL",
"AUXILIARY"] | None` field on `CatalogDeclarativeDataset` shadowed the
builtin `type` inside the class body, so `type[DeclarativeDataset]` in
`client_class()` resolved to the field (None) and tripped ty with
`invalid-type-form`. Use `builtins.type[...]` (the same pattern
`setting.py` and `identifier.py` already use) and import `builtins`.
- `metrics.py` (gooddata-dbt): `attribute.source_column`,
`label.source_column`, and `fact.source_column` are now `str | None`
on the SDK side (AUXILIARY datasets carry synthetic entries with no
physical column). Guard the `.lower()` calls so AUX entries are
silently skipped instead of crashing.
- `get_hll_type.md` and `ai-lake/analyze_statistics.md`: relative links
to sibling pages were missing trailing slashes, which htmltest rejects
("target is a directory, href lacks trailing slash"). Added them.
risk: low1 parent ae8ef87 commit 47825a5
4 files changed
Lines changed: 15 additions & 7 deletions
File tree
- docs/content/en/latest
- administration/organization
- data/ai-lake
- packages
- gooddata-dbt/src/gooddata_dbt/dbt
- gooddata-sdk/src/gooddata_sdk/catalog/workspace/declarative_model/workspace/logical_model/dataset
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
| 21 | + | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
89 | 93 | | |
90 | | - | |
| 94 | + | |
91 | 95 | | |
92 | 96 | | |
93 | | - | |
| 97 | + | |
94 | 98 | | |
95 | 99 | | |
96 | | - | |
| 100 | + | |
97 | 101 | | |
98 | 102 | | |
99 | 103 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
70 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
71 | 75 | | |
72 | 76 | | |
73 | 77 | | |
| |||
0 commit comments