Built-in *cp* sometimes ignores working directory

[elieux]

Description

Hi.

Since Task gained the built-in Coreutils implementations, I've been encountering a consistent failure with Cp. I'm not entirely convinced it's an issue directly in u-root code (or how I'd even test it) so I'm reporting it here.

The problem seems to be that the check for "target ... is not a directory" is not using the same working directory as the rest. If I do the test below but first create ROOT\subsubdir manually to pass the check, Cp continues and actually copies the files into ROOT\subdir\subsubdir correctly.

> task test
task: [test] pwd
ROOT\subdir
task: [test] rm -rf subsubdir/
task: [test] mkdir subsubdir/
task: [test] touch file1 file2
task: [test] ls
ROOT\subdir\file1
ROOT\subdir\file2
ROOT\subdir\subsubdir
task: [test] cp file1 file2 subsubdir/
task: Failed to run task "test": coreutils: target "subsubdir/" is not a directory

Version

3.50.0

Operating system

Windows

Experiments Enabled

none

Example Taskfile

version: "3"

tasks:
  test:
    dir: subdir
    cmds:
      - pwd
      - rm -rf subsubdir/
      - mkdir subsubdir/
      - touch file1 file2
      - ls
      - cp file1 file2 subsubdir/

[elieux]

(text is edited because I mistakenly created the issue prematurely)

[trulede]

The problem is here:
https://github.com/u-root/u-root/blob/da85cec0d607bcbdfaa1fc62c799af97243ff468/pkg/core/cp/cp.go#L285

stat() is called from the working dir (os.Getwd()) and not the task dir. Probably something like this will fix it:

soStat, err := os.Stat(o.resolvePath(to))
As a workaround you can use {{.TASK_DIR}}/subsubdir/

@elieux I suggest opening an issue on the u-root repo.