Skip to content

When reviewers are automatically added via CODEOWNERS rules, it is presented as an action by the PR authorΒ #36333

@drsybren

Description

@drsybren

Description

When the .gitea/CODEOWNERS file indicates a user should be added as reviewer to a PR, this reviewer is added automatically. This addition is marked as a personal action by the PR author:

${PR_OWNER} requested review from ${CODE_OWNER} 18 hours ago

This even happens when the CODEOWNERS file did not exist when the PR was created; in that case, the reviewer is added when a new commit is pushed to the PR. And it happens even when the PR author previously removed that particular user from the reviewers list.

This behaviour means that I, as PR author, have no control over this. The code owner is always added to the reviewers list. If that's how Gitea works, that's a bit clumsy, but fine.

I do have a moral issue with the fact that this is presented in the Gitea history as my personal action. This is wrong, and the reason I write this bug report. Especially because, as I described above, I have no control over this.

A solution would simply be to change the node that is added to the PR:

System requested review from ${CODE_OWNER} by CODEOWNERS ruleset

That way I also understand where this comes from, and that I didn't just mis-click something. And other people understand that I didn't choose to add this user to the reviewers list, but that it was an automated action.

Example in production: https://projects.blender.org/blender/blender/pulls/152416

I can't test on demo.gitea.com because I'm getting a '500 Internal Server Error' when I try to log in.

Gitea Version

1.25.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Self-built, self-hosted.

Database

PostgreSQL

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions