From 035f68c52fb1ef94fb3403d46194f55e17da3c8d Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu, 14 May 2026 21:02:50 +0000 Subject: [PATCH] =?UTF-8?q?docs:=20fix=20documentation=20drift=20=E2=80=94?= =?UTF-8?q?=20pool=20defaults=20and=20codemod=20registry?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - README.md: Fix pool field default (was AZS-1ES-L-MMS-ubuntu-22.04 for all targets; correct defaults are vmImage:ubuntu-latest for standalone and AZS-1ES-L-MMS-ubuntu-22.04 for 1ES) - prompts/create-ado-agentic-workflow.md: Fix Step 6 pool guidance to document the correct target-dependent defaults (standalone vs 1ES) - AGENTS.md: Add missing 0002_pool_object_form.rs to architecture tree - docs/codemods.md: Add missing 0002_pool_object_form.rs to file layout listing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- AGENTS.md | 1 + README.md | 2 +- docs/codemods.md | 3 ++- prompts/create-ado-agentic-workflow.md | 10 +++++++--- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index c6e089e7..39571ffd 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -66,6 +66,7 @@ Every compiled pipeline runs as three sequential jobs: │ │ ├── codemods/ # Front-matter codemods (one file per transformation) │ │ │ ├── mod.rs # Codemod struct, CODEMODS registry, runner │ │ │ ├── 0001_repos_unified.rs # Legacy repositories/checkout → repos codemod +│ │ │ ├── 0002_pool_object_form.rs # Legacy scalar pool → object form codemod │ │ │ └── helpers.rs # take_key, insert_no_overwrite, rename_key, ConflictPolicy │ │ ├── codemod_integration_test.rs # White-box rewrite-path tests (stub registry injection) │ │ └── types.rs # Front matter grammar and types diff --git a/README.md b/README.md index 9db2cfc7..de609722 100644 --- a/README.md +++ b/README.md @@ -238,7 +238,7 @@ the service connections. Approve the permissions and the pipeline is ready. | `target` | `standalone` \| `1es` | `standalone` | Pipeline output format | | `engine` | string or object | `copilot` | Engine identifier or object with `id`, `model`, `timeout-minutes`, etc. | | `on` | object | — | Unified trigger configuration (`schedule`, `pipeline` completion, `pr` triggers). See [schedule syntax](#schedule-syntax). | -| `pool` | string or object | `AZS-1ES-L-MMS-ubuntu-22.04` | Agent pool | +| `pool` | string or object | `vmImage: ubuntu-latest` (standalone) / `AZS-1ES-L-MMS-ubuntu-22.04` (1ES) | Agent pool | | `workspace` | `root` \| `repo` \| `self` \| *alias* | auto | Working directory mode. `self` is an alias for `repo`; any checked-out repo alias is also accepted. | | `repos` | list | — | Compact repository declarations (replaces legacy `repositories:` + `checkout:`) | | `mcp-servers` | map | — | MCP server configuration | diff --git a/docs/codemods.md b/docs/codemods.md index e293ad56..aa6981bf 100644 --- a/docs/codemods.md +++ b/docs/codemods.md @@ -108,7 +108,8 @@ Codemods live in `src/compile/codemods/`: src/compile/codemods/ ├── mod.rs # Framework + CODEMODS registry ├── helpers.rs # take_key, insert_no_overwrite, rename_key, ConflictPolicy -└── 0001_repos_unified.rs # Legacy repositories: + checkout: → repos: codemod +├── 0001_repos_unified.rs # Legacy repositories: + checkout: → repos: codemod +└── 0002_pool_object_form.rs # Legacy scalar pool → explicit object form codemod ``` (New codemods are appended as `_.rs` files.) diff --git a/prompts/create-ado-agentic-workflow.md b/prompts/create-ado-agentic-workflow.md index 59e8f85f..6f6a7f27 100644 --- a/prompts/create-ado-agentic-workflow.md +++ b/prompts/create-ado-agentic-workflow.md @@ -153,15 +153,19 @@ repos: ### Step 6 — Pool -Defaults to `AZS-1ES-L-MMS-ubuntu-22.04`. Only include if overriding. +Default depends on target: standalone uses `vmImage: ubuntu-latest` (Microsoft-hosted); 1ES uses `name: AZS-1ES-L-MMS-ubuntu-22.04`. Only include if overriding the default. -String form: +String form (self-hosted pool by name): ```yaml pool: MyCustomPool ``` -Object form (needed for 1ES target with explicit OS): +Object form (Microsoft-hosted or explicit OS): ```yaml +pool: + vmImage: ubuntu-latest # Microsoft-hosted (standalone default) + +# 1ES pool with explicit OS: pool: name: AZS-1ES-L-MMS-ubuntu-22.04 os: linux # "linux" or "windows"