Skip to content

Commit 55d8092

Browse files
authored
Merge pull request #316 from githubdoe/ver831
Fixes crash in "percent of correction" feature
2 parents 224b83e + 89888ee commit 55d8092

2 files changed

Lines changed: 13 additions & 8 deletions

File tree

RevisionHistory.html

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<h1>DFTFringe Version History</h1>
1111
<ul>
1212

13-
<li>Version 8.3.0</li>
13+
<li>Version 8.3.1</li>
1414
<ul>
1515
<li>Auto-invert feature (and dialog) only applies to wavefronts created form igram, not those loaded from file, simulated, averaged, subtracted, etc.</li>
1616
<li>Contourview display is always perfectly square</li>
@@ -19,12 +19,13 @@ <h1>DFTFringe Version History</h1>
1919
<li>Fixed crash in "show statistics"</li>
2020
<li>Disabled dark mode on windows</li>
2121
<li>Updated dependencies versions</li>
22+
<li>Configuration Preferences look cleaner and some spellings fixed</li>
2223
<li>Changes to profile plot:</li>
2324
<ul>
2425
<li>Some features moved to context menu (right click menu)</li>
2526
<li>Selecting multiple wavefronts on right show their corresponding profiles</li>
26-
<li>New average feature that uses all data (not just 16 diameters)<li>
27-
<li>Ability to create wavefront based on average profile<li>
27+
<li>New average feature that uses all data (not just 16 diameters)</li>
28+
<li>Ability to create wavefront based on average profile</li>
2829
<li>Corrected bugs with percentages, inches, mm</li>
2930
<li>Select multiple wavefronts and right click to see multiple Ronchi view</li>
3031
<li>Multi Ronchi view lets you compare Ronchi's</li>

percentcorrectiondlg.cpp

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ percentCorrectionDlg::percentCorrectionDlg( QWidget *parent) :
5454
sizes << 500 << 100;
5555
ui->splitter->setSizes(sizes);
5656
m_number_of_zones = set.value("percent number of zones", 5).toInt();
57+
if (m_number_of_zones <= 0)
58+
m_number_of_zones = 5;
5759
m_exclusionRadius = ui->exclusionRadius->value();
5860
ui->numberOfZones->blockSignals(true);
5961
ui->numberOfZones->setValue(m_number_of_zones);
@@ -105,11 +107,13 @@ QList<double> percentCorrectionDlg::generateZoneCenters(double radius, int numbe
105107
QJsonObject jsonData=doc.object();
106108

107109
QJsonArray zones = jsonData["zones"].toArray();
108-
m_number_of_zones = zones.size();
109-
ui->numberOfZones->blockSignals(true);
110-
ui->numberOfZones->setValue(m_number_of_zones);
111-
ui->numberOfZones->blockSignals(false);
112-
return m_zoneCenters;
110+
if (zones.size() > 0) {
111+
m_number_of_zones = zones.size();
112+
ui->numberOfZones->blockSignals(true);
113+
ui->numberOfZones->setValue(m_number_of_zones);
114+
ui->numberOfZones->blockSignals(false);
115+
return m_zoneCenters;
116+
}
113117
}
114118

115119
}

0 commit comments

Comments
 (0)