Skip to content

[lint-monster] Non-workflow function-length cleanup (2026-07-26) #48112

Description

@github-actions

Summary

Custom lint scan on 2026-07-26 found 6 largefunc findings outside the shared pkg/workflow / pkg/cli function-length backlog. These belong to the same linter rule but live in non-shared subsystems and should be handled separately.

Findings

  • pkg/parser/remote_download_file.go:383downloadFileViaGitClone is 68 lines long
  • cmd/gh-aw/main.go:288 — func literal is 129 lines long
  • cmd/gh-aw/main.go:516init is 447 lines long
  • cmd/gh-aw/main.go:577 — func literal is 72 lines long
  • pkg/linters/stringbytesroundtrip/stringbytesroundtrip.go:55analyzeRoundTrip is 76 lines long
  • pkg/linters/registry.go:72All is 61 lines long

Expected outcome

Break up the reported functions into smaller helpers without changing behavior and clear this non-workflow/non-cli subset of largefunc diagnostics.

Remediation checklist

  • Keep changes scoped to the 6 listed findings
  • Prefer extracting small nearby helpers or splitting cohesive phases
  • Avoid mixing this work with the shared pkg/workflow / pkg/cli function-length backlog
  • Preserve behavior and tests
  • Validate with make golint-custom

Fused guidance for the assignee

  • Keep remediation scoped to findings in this assigned lint group.
  • Prefer minimal, targeted helper extraction over broad rewrites.
  • Validate with make golint-custom before handoff.

Generated by 🧌 LintMonster · gpt54 · 19.2 AIC · ⌖ 4.72 AIC · ⊞ 4.6K ·

  • expires on Aug 1, 2026, 7:47 PM UTC-08:00

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions