-
Notifications
You must be signed in to change notification settings - Fork 250
Open
Labels
Description
Objective
Add the Version type to the SafeInputsMCPVersion constant, which is inconsistently declared as an untyped string while all 20+ neighboring version constants are properly typed.
Context
Discussion #17885 (Typist - Go Type Consistency Analysis) identified this as an obvious oversight — every neighboring Version constant in pkg/constants/constants.go uses the Version semantic type except this one.
Location
File: pkg/constants/constants.go (around line 654)
// Current — untyped (inconsistent)
const SafeInputsMCPVersion = "1.0.0"
// Fixed — consistent with all other Version constants
const SafeInputsMCPVersion Version = "1.0.0"Files to Modify
pkg/constants/constants.go— addVersiontype toSafeInputsMCPVersion
Acceptance Criteria
-
SafeInputsMCPVersionuses theVersiontype - All usage sites compile correctly (the
Versiontype has aString()method and is compatible with string operations) -
make buildandmake test-unitpass -
make fmtandmake lintpass
Generated by Plan Command for issue #discussion #17885
- expires on Feb 25, 2026, 11:40 AM UTC
Reactions are currently unavailable