[Schema Consistency] Schema Consistency Check - 2026-04-10 #25578
Closed
Replies: 1 comment
-
|
This discussion has been marked as outdated by Schema Consistency Checker. A newer discussion is available at Discussion #25753. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
pre-steps/run-install-scriptsabsent fromfrontmatter-full.md;upload-artifactconstraint gapsCritical Issues
CONSTRAINT GAP:
upload-artifact.max-uploadsmaximum not enforcedmax-uploadshasmaximum: 20publish_artifacts.go:81only checksv > 0, neverv <= 20max-uploads: 999silently accepts any value without errorpkg/workflow/publish_artifacts.go:81CONSTRAINT GAP:
upload-artifact.defaults.if-no-filesenum not validatedif-no-fileshasenum: ["error", "ignore"]publish_artifacts.go:152–153accepts any non-empty stringif-no-files: warnpass compilation but will fail at runtime in the safe-outputs handlerpkg/workflow/publish_artifacts.go:152–153Documentation Gaps
NEW:
pre-stepsabsent fromfrontmatter-full.mdpkg/parser/schemas/main_workflow_schema.jsonwith detailed description about minting short-lived tokens before checkoutfrontmatter.mdORfrontmatter-full.md; only mentioned incidentally inimports.mdanddependencies.mdNEW:
run-install-scriptsabsent fromfrontmatter-full.mddefault: falsewith supply-chain security warning descriptionfrontmatter.mdORfrontmatter-full.mdpkg/workflow/run_install_scripts_validation.go(per-runtime and global)Persistent Issues (Unresolved)
View persistent documentation gaps
1.
observability.otlpsub-fields undocumentedfrontmatter-full.mdshows onlyobservability: {}with no sub-fieldsotlp.endpoint(OTLP collector URL, auto-allowlisted in firewall) andotlp.headers(injected asOTEL_EXPORTER_OTLP_HEADERS)2.
keepalive-intervalinsandbox.mcpundocumentedpkg/parser/schemas/main_workflow_schema.json:3234defines keepalive ping interval for HTTP MCP backendsfrontmatter-full.mdsandbox.mcpsection3. 30
safe-outputstools missing fromfrontmatter-full.mdThe
safe-outputs:section infrontmatter-full.mdis missing 30 tool entries. Notable gap:upload-artifact(newly added tool withmax-uploads,retention-days,skip-archive,max-size-bytes,allowed-paths,filters,defaultssub-fields).Other missing tools:
actions,activation-comments,call-workflow,concurrency-group,dispatch-workflow,dispatch_repository,env,environment,failure-issue-repo,github-app,group-reports,hide-comment,id-token,jobs,max-bot-mentions,max-patch-size,missing-data,missing-tool,noop,push-to-pull-request-branch,report-failure-as-issue,report-incomplete,runs-on,scripts,set-issue-type,steps,threat-detection,update-release,upload-asset4. 12 schema fields missing from
frontmatter.mdcheck-for-updates,disable-model-invocation,import-schema,infer,inlined-imports,mcp-servers,observability,pre-steps,rate-limit,run-install-scripts,secret-masking,tracker-idNote:
run-install-scriptsis newly added to this list (up from 11 in previous run).5. Feature flags undocumented
cli-proxy,cli-proxy-writable,copilot-requests,mcp-gateway,disable-xpia-prompt,mcp-scriptsare used in production workflows but absent fromfrontmatter.mdandfrontmatter-full.md.View previously resolved findings
RESOLVED:
proxy-argsnow in schema$defs.stdio_mcp_tool.propertiesnow includesproxy-args— the schema and Go validation are consistent. Previously a workflow usingproxy-argswould fail schema validation but pass Go validation.RESOLVED:
status-commentauto-enable behavior documentedfrontmatter.md:33correctly states automatic enablement forslash_commandandlabel_commandtriggers.Recommendations
Fix
upload-artifactconstraint gaps — Addv <= 20guard formax-uploadsinpublish_artifacts.go:81and add enum validation forif-no-filesatpublish_artifacts.go:152. These are cheap one-line fixes consistent with how other constraint gaps were closed (e.g.max-patch-size).Document
pre-stepsinfrontmatter-full.md— The feature is fully implemented with a rich schema description (short-lived token minting, step output references). Add a dedicated YAML example block to bothfrontmatter.mdandfrontmatter-full.md.Document
run-install-scriptsinfrontmatter-full.md— Security-sensitive field with no user-facing reference. Add tofrontmatter-full.mdalongside a security note (supply chain warning, per-runtime alternative viaruntimes.node.run-install-scripts).Document
upload-artifactsafe-outputs tool — Newly active feature (used indaily-performance-summaryworkflow). Add its sub-fields (max-uploads,retention-days,skip-archive,max-size-bytes,allowed-paths,filters,defaults) tofrontmatter-full.md.Expand
observability.otlpdocs — Addendpointandheaderssub-field examples tofrontmatter-full.md; the schema descriptions are already accurate.Strategy Performance
Next Steps
pkg/workflow/publish_artifacts.go:81— addv <= 20guard formax-uploadspkg/workflow/publish_artifacts.go:152— addif-no-filesenum checkdocs/src/content/docs/reference/frontmatter-full.md— addpre-steps:example blockdocs/src/content/docs/reference/frontmatter-full.md— addrun-install-scripts:example blockdocs/src/content/docs/reference/frontmatter-full.md— addupload-artifact:safe-outputs tool blockdocs/src/content/docs/reference/frontmatter-full.md— expandobservability:block withotlp:sub-fieldsReferences:
Beta Was this translation helpful? Give feedback.
All reactions