Skip to content

Commit eb71953

Browse files
mvachhardaniel-noland
authored andcommitted
fix: Comment out failing new workflows
The earlier series of commits adds the address and thread sanitizer to the dev workflows. These fail due to real bugs that need to be addressed. However, that is for later commits. While the sanitizer jobs are marked as optional and do not cause build failure, the summary job still sees them as failed and fails. A future commit should make the summary job somehow look at the optional flag and not fail. Signed-off-by: Manish Vachharajani <manish@githedgehog.com>
1 parent 14efecb commit eb71953

1 file changed

Lines changed: 14 additions & 10 deletions

File tree

.github/workflows/dev.yml

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -137,16 +137,20 @@ jobs:
137137
profile: "release"
138138
sanitize: "" # TODO: enable safe-stack,cfi when possible
139139
instrument: "none"
140-
- name: "sanitize/address"
141-
profile: "debug" # FIXME: should be fuzz, but build time explodes for unknown reasons
142-
sanitize: "address"
143-
instrument: "none" # FIXME: should be coverage, but build time explodes for unknown reasons
144-
optional: true # FIXME: Make required once existing bugs are fixed
145-
- name: "sanitize/thread"
146-
profile: "fuzz"
147-
sanitize: "thread"
148-
instrument: "none" # FIXME: should be coverage, but build time explodes for unknown reasons
149-
optional: true # FIXME: Make required once existing bugs are fixed
140+
# FIXME: The following commented sections are marked optional
141+
# and the build continues after they fail, but then summary
142+
# fails. For now, comment this out, but ideally we'd run them
143+
# let them fail, but let the summary pass anyway
144+
# - name: "sanitize/address"
145+
# profile: "debug" # FIXME: should be fuzz, but build time explodes for unknown reasons
146+
# sanitize: "address"
147+
# instrument: "none" # FIXME: should be coverage, but build time explodes for unknown reasons
148+
# optional: true # FIXME: Make required once existing bugs are fixed
149+
# - name: "sanitize/thread"
150+
# profile: "fuzz"
151+
# sanitize: "thread"
152+
# instrument: "none" # FIXME: should be coverage, but build time explodes for unknown reasons
153+
# optional: true # FIXME: Make required once existing bugs are fixed
150154
debug_justfile:
151155
- "${{ inputs.debug_justfile || false }}"
152156
steps:

0 commit comments

Comments
 (0)