Merge pull request #2537 from gitautoai/wes

Fix Python 3.14 event loop crash and tool dispatch for None args

Author: hiroshinishio

.claude/hooks/no-skip-hooks.sh

@@ -0,0 +1,20 @@
+#!/bin/bash
+# Bash hook: Block --no-verify on git commit
+INPUT=$(cat)
+CMD=$(echo "$INPUT" | jq -r '.tool_input.command // ""')
+
+# Extract only the git commit portion (before any && or ; chain), then strip the message
+COMMIT_CMD=$(echo "$CMD" | grep -oE '(^|&&|;)\s*git commit[^&;]*' | head -1)
+if [ -n "$COMMIT_CMD" ]; then
+  # Strip commit message to avoid false positives
+  FLAGS=$(echo "$COMMIT_CMD" | sed 's/ -m .*//; s/ -m".*//; s/ -m$//')
+  if echo "$FLAGS" | grep -q -- "--no-verify"; then
+    jq -n '{
+      "decision": "block",
+      "reason": "BLOCKED: --no-verify is not allowed. Commit without it."
+    }'
+    exit 2
+  fi
+fi
+
+exit 0

.claude/settings.json

@@ -1,5 +1,17 @@
 {
   "hooks": {
+    "PreToolUse": [
+      {
+        "matcher": "Bash",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "/Users/rwest/Repositories/gitauto/.claude/hooks/no-skip-hooks.sh",
+            "timeout": 5
+          }
+        ]
+      }
+    ],
     "Stop": [
       {
         "matcher": "",

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "GitAuto"
-version = "1.1.9"
+version = "1.1.12"
 requires-python = ">=3.14"
 dependencies = [
     "annotated-doc==0.0.4",

scripts/lint/check_test_files.sh

@@ -38,19 +38,15 @@ if [ -n "$STAGED_IMPL_NEW" ]; then
 fi
 
 # Check 2: Changed impl files with existing test files must have test also staged
-# Exception: if the test file has no unstaged changes (identical to HEAD), it's fine
 if [ -n "$STAGED_IMPL_MODIFIED" ]; then
     for file in $STAGED_IMPL_MODIFIED; do
         dir=$(dirname "$file")
         base=$(basename "$file")
         test_file="$dir/test_$base"
         if [ -f "$test_file" ]; then
             if ! echo "$STAGED_ALL" | grep -qF "$test_file"; then
-                # Allow if test file is unchanged from HEAD (e.g. import-only refactors)
-                if ! git diff --quiet HEAD -- "$test_file" 2>/dev/null; then
-                    echo "TEST NOT UPDATED: $file changed but $test_file is not staged"
-                    FAIL=1
-                fi
+                echo "TEST NOT STAGED: $file changed but $test_file is not staged"
+                FAIL=1
             fi
         fi
     done

services/chat_with_agent.py

@@ -246,6 +246,11 @@ async def chat_with_agent(
                 tool_result = tools_to_call[tool_name](
                     **tool_args, base_args=base_args, messages=messages
                 )
+            else:
+                # Model passed None or non-dict args (e.g. verify_task_is_complete with no args)
+                tool_result = tools_to_call[tool_name](
+                    base_args=base_args, messages=messages
+                )
             if inspect.iscoroutine(tool_result):
                 tool_result = await tool_result
 

services/test_chat_with_agent.py

@@ -444,6 +444,56 @@ async def test_verify_task_is_complete_without_pr_changes_returns_is_completed_f
     assert "No changes were needed" in last_message
 
 
+@pytest.mark.asyncio
+@patch("services.chat_with_agent.chat_with_model")
+@patch("services.agents.verify_task_is_complete.get_pull_request_files")
+@patch("services.chat_with_agent.update_comment")
+async def test_verify_task_is_complete_with_none_args_still_executes(
+    _mock_update_comment, mock_get_pr_files, mock_chat_with_model, create_test_base_args
+):
+    """PR 786: Gemma 4 31B called verify_task_is_complete with args=None instead of {}.
+    isinstance(None, dict) is False, so the tool was silently skipped and returned None.
+    Gemma then entered a dead loop returning empty responses for 20 iterations."""
+    mock_get_pr_files.return_value = [{"filename": "test.py", "status": "modified"}]
+    mock_chat_with_model.return_value = (
+        {
+            "role": "assistant",
+            "content": [
+                {
+                    "type": "tool_use",
+                    "id": "test_id",
+                    "name": "verify_task_is_complete",
+                    "input": {},
+                }
+            ],
+        },
+        [ToolCall(id="test_id", name="verify_task_is_complete", args=None)],
+        15,
+        10,
+    )
+
+    base_args = create_test_base_args(
+        model_id=GoogleModelId.GEMMA_4_31B,
+        owner="test-owner",
+        repo="test-repo",
+        pr_number=123,
+        token="test-token",
+    )
+
+    result = await chat_with_agent(
+        messages=[{"role": "user", "content": "test"}],
+        system_message="test system message",
+        base_args=base_args,
+        tools=[],
+        usage_id=123,
+        model_id=GoogleModelId.GEMMA_4_31B,
+    )
+
+    # verify_task_is_complete was called (not skipped), so is_completed should be True
+    assert result.is_completed is True
+    mock_get_pr_files.assert_called_once()
+
+
 @pytest.mark.asyncio
 @patch("services.chat_with_agent.chat_with_model")
 async def test_regular_tool_returns_is_completed_false(