* Finished Bento implementation.

* TAL Sampler
  * New: Conversion does not stop after first missing sample. All missing samples are logged.
  * Fixed: Could not read file when the program element had more than 200 attributes.
  * Fixed: Version 11 of the format has now a double to indicate of a layer is enabled or not which led to empty results.

Author: git-moss

documentation/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changes
 
-## 15.2.0 (unreleased)
+## 15.5.0
 
 * Added support for 1010music Bento
 * Fixed: The header of written FLAC files did not contain the sample length, which is valid but many readers rely on that value and crash otherwise.
@@ -13,6 +13,10 @@
 * MPC
   * New: The file version and source platform is now logged.
   * New: Improved check for valid loops. If none is present it is loaded from the WAV file if present.
+* TAL Sampler
+  * New: Conversion does not stop after first missing sample. All missing samples are logged.
+  * Fixed: Could not read file when the program element had more than 200 attributes.
+  * Fixed: Version 11 of the format has now a double to indicate of a layer is enabled or not which led to empty results.
 * Yamaha YSFC
   * Fixed: End of loop was always set to the end of the sample.
 

documentation/SupportedFeaturesSampleFormats.ods

@@ -5,7 +5,7 @@
 	<modelVersion>4.0.0</modelVersion>
 	<groupId>de.mossgrabers</groupId>
 	<artifactId>convertwithmoss</artifactId>
-	<version>15.2.0</version>
+	<version>15.5.0</version>
 	<packaging>jar</packaging>
 	<name>ConvertWithMoss</name>
 	<organization>
@@ -154,7 +154,7 @@
 			<plugin>
 				<groupId>org.panteleyev</groupId>
 				<artifactId>jpackage-maven-plugin</artifactId>
-				<version>1.7.2</version>
+				<version>1.7.3</version>
 				<configuration>
 					<input>target/lib</input>
 					<destination>target/release</destination>

pom.xml

@@ -96,6 +96,9 @@ public ConverterBackend (final INotifier notifier)
     {
         this.notifier = notifier;
 
+        // Workaround for attribute limit of 200 which e.g. causes issues with TAL Sampler format
+        System.setProperty ("jdk.xml.elementAttributeLimit", "1000");
+
         this.detectors = new IDetector []
         {
             new BentoDetector (notifier),

src/main/java/de/mossgrabers/convertwithmoss/core/ConverterBackend.java

@@ -5,6 +5,7 @@
 package de.mossgrabers.convertwithmoss.format.tal;
 
 import java.io.File;
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.StringReader;
 import java.util.ArrayList;
@@ -150,7 +151,7 @@ private List<IMultisampleSource> parseDescription (final File multiSampleFile, f
             final List<IGroup> groups = new ArrayList<> (4);
             for (int groupCounter = 0; groupCounter < 4; groupCounter++)
                 // Group is disabled?
-                if (XMLUtils.getIntegerAttribute (programElement, TALSamplerTag.PROGRAM_LAYER_ON + TALSamplerConstants.LAYERS[groupCounter], 0) == 1)
+                if (XMLUtils.getDoubleAttribute (programElement, TALSamplerTag.PROGRAM_LAYER_ON + TALSamplerConstants.LAYERS[groupCounter], 0) > 0)
                 {
                     final Element groupElement = XMLUtils.getChildElementByName (programElement, TALSamplerTag.SAMPLE_LAYER + groupCounter);
                     if (groupElement != null)
@@ -208,7 +209,16 @@ private ISampleZone parseSample (final File parentFolder, final Element programE
         if (XMLUtils.getIntegerAttribute (sampleElement, TALSamplerTag.IS_ROM_SAMPLE, 0) == 1)
             throw new IOException (Functions.getMessage ("IDS_TAL_ROM_SAMPLES_NOT_SUPPORTED", filename));
 
-        final ISampleZone zone = this.createSampleZone (new File (parentFolder, filename));
+        final ISampleZone zone;
+        try
+        {
+            zone = this.createSampleZone (new File (parentFolder, filename));
+        }
+        catch (final FileNotFoundException ex)
+        {
+            this.notifier.logError (ex, false);
+            return null;
+        }
 
         zone.setGain (convertGain (XMLUtils.getDoubleAttribute (sampleElement, TALSamplerTag.VOLUME, 0)));
         zone.setPanning (XMLUtils.getDoubleAttribute (sampleElement, TALSamplerTag.PANNING, 0.5) * 2.0 - 1.0);
@@ -231,7 +241,7 @@ private ISampleZone parseSample (final File parentFolder, final Element programE
         zone.setVelocityLow (XMLUtils.getIntegerAttribute (sampleElement, TALSamplerTag.LO_VEL, -1));
         zone.setVelocityHigh (XMLUtils.getIntegerAttribute (sampleElement, TALSamplerTag.HI_VEL, -1));
 
-        // No note and velocity crossfades
+        // No note and velocity cross-fades
 
         if (XMLUtils.getIntegerAttribute (sampleElement, TALSamplerTag.LOOP_ENABLED, 0) == 1)
         {

src/main/java/de/mossgrabers/convertwithmoss/format/tal/TALSamplerDetector.java

@@ -1,4 +1,4 @@
-TITLE=ConvertWithMoss 15.2.0
+TITLE=ConvertWithMoss 15.5.0
 
 ##################################################################################
 #