chore: remove unnecessary global name to spy on console (#2443)

Author: ghiscoding

frameworks/angular-slickgrid/src/library/components/__tests__/angular-slickgrid.component.spec.ts

@@ -864,7 +864,7 @@ describe('Angular-Slickgrid Custom Component instantiated via Constructor', () =
       });
 
       it('should display a console warning when any of the column definition ids include a dot notation', () => {
-        const consoleSpy = vi.spyOn(global.console, 'warn').mockReturnValue();
+        const consoleSpy = vi.spyOn(console, 'warn').mockReturnValue();
         const mockColDefs = [{ id: 'user.gender', field: 'user.gender', editor: { model: Editors.text, collection: ['male', 'female'] } }] as Column[];
 
         component.columns = mockColDefs;

packages/common/src/core/__tests__/slickGrid.spec.ts

@@ -130,7 +130,7 @@ describe('SlickGrid core file', () => {
   });
 
   it('should display a console warning when body zoom level is different than 100%', () => {
-    const consoleWarnSpy = vi.spyOn(global.console, 'warn').mockReturnValue();
+    const consoleWarnSpy = vi.spyOn(console, 'warn').mockReturnValue();
 
     document.body.style.zoom = '90%';
     const columns = [{ id: 'firstName', field: 'firstName', name: 'First Name' }] as Column[];
@@ -142,7 +142,7 @@ describe('SlickGrid core file', () => {
   });
 
   it('should not display a console warning when body zoom level is 100%', () => {
-    const consoleWarnSpy = vi.spyOn(global.console, 'warn').mockReturnValue();
+    const consoleWarnSpy = vi.spyOn(console, 'warn').mockReturnValue();
 
     document.body.style.zoom = '100%';
     const columns = [{ id: 'firstName', field: 'firstName', name: 'First Name' }] as Column[];
@@ -154,7 +154,7 @@ describe('SlickGrid core file', () => {
   });
 
   it('should not display a console warning when body zoom is not defined', () => {
-    const consoleWarnSpy = vi.spyOn(global.console, 'warn').mockReturnValue();
+    const consoleWarnSpy = vi.spyOn(console, 'warn').mockReturnValue();
 
     document.body.style.zoom = '';
     const columns = [{ id: 'firstName', field: 'firstName', name: 'First Name' }] as Column[];
@@ -166,7 +166,7 @@ describe('SlickGrid core file', () => {
   });
 
   it('should display a console warning when Row Detail is enabled with `rowTopOffsetRenderType` is set to "transfrom"', () => {
-    const consoleWarnSpy = vi.spyOn(global.console, 'warn').mockReturnValue();
+    const consoleWarnSpy = vi.spyOn(console, 'warn').mockReturnValue();
 
     document.body.style.zoom = '90%';
     const columns = [{ id: 'firstName', field: 'firstName', name: 'First Name' }] as Column[];
@@ -186,7 +186,7 @@ describe('SlickGrid core file', () => {
   });
 
   it('should display a console warning when RowSpan is enabled with `rowTopOffsetRenderType` is set to "transfrom"', () => {
-    const consoleWarnSpy = vi.spyOn(global.console, 'warn').mockReturnValue();
+    const consoleWarnSpy = vi.spyOn(console, 'warn').mockReturnValue();
 
     document.body.style.zoom = '90%';
     const columns = [{ id: 'firstName', field: 'firstName', name: 'First Name' }] as Column[];
@@ -1499,7 +1499,7 @@ describe('SlickGrid core file', () => {
     });
 
     it('should define colspan and rowspan but get a warning when enableCellRowSpan is disabled', () => {
-      const consoleWarnSpy = vi.spyOn(global.console, 'warn').mockReturnValue();
+      const consoleWarnSpy = vi.spyOn(console, 'warn').mockReturnValue();
       const columns = [
         { id: 'firstName', field: 'firstName', name: 'First Name' },
         { id: 'lastName', field: 'lastName', name: 'Last Name' },

packages/common/src/extensions/__tests__/slickGridMenu.spec.ts

@@ -169,7 +169,7 @@ describe('GridMenuControl', () => {
   let div;
 
   describe('with I18N Service', () => {
-    const consoleErrorSpy = vi.spyOn(global.console, 'error').mockReturnValue();
+    const consoleErrorSpy = vi.spyOn(console, 'error').mockReturnValue();
     let parentContainer: HTMLDivElement;
 
     beforeEach(() => {

packages/common/src/formatters/__tests__/currencyFormatter.spec.ts

@@ -9,7 +9,7 @@ describe('the Currency Formatter', () => {
   } as unknown as SlickGrid;
 
   beforeEach(() => {
-    vi.spyOn(global.console, 'warn').mockReturnValue();
+    vi.spyOn(console, 'warn').mockReturnValue();
   });
 
   it('should display an empty string when no value is provided', () => {

packages/common/src/formatters/__tests__/decimalFormatter.spec.ts

@@ -9,7 +9,7 @@ describe('the Decimal Formatter', () => {
   } as unknown as SlickGrid;
 
   beforeEach(() => {
-    vi.spyOn(global.console, 'warn').mockReturnValue();
+    vi.spyOn(console, 'warn').mockReturnValue();
   });
 
   it('should display an empty string when no value is provided', () => {

packages/common/src/services/__tests__/resizer.service.spec.ts

@@ -990,7 +990,7 @@ describe('Resizer Service', () => {
 
       it('should try to resize grid when its UI is deemed broken but expect an error shown in the console when "resizeGrid" throws an error', () =>
         new Promise((done: any) => {
-          const consoleSpy = vi.spyOn(global.console, 'log').mockReturnValue();
+          const consoleSpy = vi.spyOn(console, 'log').mockReturnValue();
           const promise = new Promise((_resolve, reject) => setTimeout(() => reject('some error'), 0));
           vi.spyOn(service, 'resizeGrid').mockReturnValue(promise as any);
 

packages/common/src/services/__tests__/utilities.spec.ts

@@ -1426,7 +1426,7 @@ describe('Service/Utilies', () => {
     });
 
     it('should throw an error when Fetch Promise response bodyUsed is true', async () => {
-      const consoleSpy = vi.spyOn(global.console, 'warn').mockReturnValue();
+      const consoleSpy = vi.spyOn(console, 'warn').mockReturnValue();
       const mockCollection = ['male', 'female'];
       const collectionAsync = basicFetchStub('http://invalid-url', { method: 'GET' }, mockCollection);
 

packages/composite-editor-component/src/slick-composite-editor.component.spec.ts

@@ -295,7 +295,7 @@ describe('CompositeEditorService', () => {
     });
 
     it('should show an error in console log when using default onError and the Grid Option flag "enableCellNavigation" is not enabled', () => {
-      const consoleSpy = vi.spyOn(global.console, 'log').mockReturnValue();
+      const consoleSpy = vi.spyOn(console, 'log').mockReturnValue();
       const newGridOptions = { ...gridOptionsMock, enableCellNavigation: false };
       vi.spyOn(gridStub, 'getOptions').mockReturnValue(newGridOptions);
 

packages/custom-tooltip-plugin/src/__tests__/slickCustomTooltip.spec.ts

@@ -578,7 +578,7 @@ describe('SlickCustomTooltip plugin', () => {
   });
 
   it('should throw an error when trying to create an async tooltip without "asyncPostFormatter" defined', () => {
-    const consoleSpy = vi.spyOn(global.console, 'error').mockReturnValue();
+    const consoleSpy = vi.spyOn(console, 'error').mockReturnValue();
     const cellNode = document.createElement('div');
     cellNode.className = 'slick-cell l2 r2';
     const mockColumns = [{ id: 'firstName', field: 'firstName' }] as Column[];
@@ -638,7 +638,7 @@ describe('SlickCustomTooltip plugin', () => {
     vi.spyOn(gridStub, 'getCellNode').mockReturnValue(cellNode);
     vi.spyOn(gridStub, 'getColumns').mockReturnValue(mockColumns);
     vi.spyOn(dataviewStub, 'getItem').mockReturnValue({ firstName: 'John', lastName: 'Doe' });
-    const consoleSpy = vi.spyOn(global.console, 'error').mockReturnValue();
+    const consoleSpy = vi.spyOn(console, 'error').mockReturnValue();
 
     plugin.init(gridStub, container);
     plugin.addRxJsResource(rxjsResourceStub);

packages/row-detail-view-plugin/src/slickRowDetailView.spec.ts

@@ -348,7 +348,7 @@ describe('SlickRowDetailView plugin', () => {
   });
 
   it('should trigger "onAsyncResponse" but throw an error when there is no item provided', () => {
-    const consoleSpy = vi.spyOn(global.console, 'error').mockReturnValue();
+    const consoleSpy = vi.spyOn(console, 'error').mockReturnValue();
     const updateItemSpy = vi.spyOn(dataviewStub, 'updateItem');
     const postViewMock = (item: any) => `<span>Post ${item.id}</span>`;
     vi.spyOn(gridStub, 'getOptions').mockReturnValue({ ...gridOptionsMock, rowDetailView: { postTemplate: postViewMock } as any });