-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Closed
Copy link
Description
Note
The pull request "fix(profiling-node): Fix NODE_VERSION rendered as [object Object] in warning" was created by @logaretm but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.
Summary
NODE_VERSIONis aSemVerobject ({ major, minor, patch }) fromparseSemver()with no customtoString(). Interpolating it in a template literal produced[object Object]instead of the actual version number.- Since the surrounding check is
![16, 18, 20, 22, 24].includes(NODE_MAJOR), it makes more sense to logNODE_MAJOR(a number) in the warning message anyway. - Added a test verifying that
NODE_VERSIONhas no customtoString()to prevent future misuse.
Test plan
- Added unit test confirming
NODE_VERSIONstringifies as[object Object] - Existing profiling-node tests pass
🤖 Generated with Claude Code
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels