Improve bind routes on typescript-backend

Author: ganatan

backend-javascript/src/modules/city/city.controller.js

@@ -5,14 +5,8 @@ import { validateItem } from './city.schema.js';
 class Controller {
   constructor(service) {
     this.service = service;
-    // this.getItems = this.getItems.bind(this);
-    // this.getItemById = this.getItemById.bind(this);
-    // this.createItem = this.createItem.bind(this);
-    // this.updateItem = this.updateItem.bind(this);
-    // this.deleteItem = this.deleteItem.bind(this);
   }
 
-  // async getItems(req, res, next) {
   getItems = async (req, res, next) => {
     try {
       const result = await this.service.getItems(req.query);

backend-javascript/src/modules/continent/continent.controller.js

@@ -5,14 +5,9 @@ import { validateItem } from './continent.schema.js';
 class Controller {
   constructor(service) {
     this.service = service;
-    this.getItems = this.getItems.bind(this);
-    this.getItemById = this.getItemById.bind(this);
-    this.createItem = this.createItem.bind(this);
-    this.updateItem = this.updateItem.bind(this);
-    this.deleteItem = this.deleteItem.bind(this);
   }
 
-  async getItems(req, res, next) {
+  getItems = async (req, res, next) => {
     try {
       const result = await this.service.getItems(req.query);
       res.locals = { data: result, statusCode: HTTP_STATUS.OK };
@@ -24,7 +19,7 @@ class Controller {
     }
   }
 
-  async getItemById(req, res, next) {
+  getItemById = async (req, res, next) => {
     try {
       const result = await this.service.getItemById(parseInt(req.params.id));
       res.locals = { data: result, statusCode: HTTP_STATUS.OK };
@@ -48,7 +43,7 @@ class Controller {
     }
   }
 
-  async createItem(req, res, next) {
+  createItem = async (req, res, next) => {
     try {
       validateItem(req.body);
       const result = await this.service.createItem(req.body);
@@ -67,7 +62,7 @@ class Controller {
     }
   }
 
-  async updateItem(req, res, next) {
+  updateItem = async (req, res, next) => {
     try {
       validateItem(req.body);
       const result = await this.service.updateItem(parseInt(req.params.id), req.body);
@@ -86,7 +81,7 @@ class Controller {
     }
   }
 
-  async deleteItem(req, res, next) {
+  deleteItem = async (req, res, next) => {
     try {
       const result = await this.service.deleteItem(parseInt(req.params.id));
       res.locals = { data: result, statusCode: HTTP_STATUS.OK };

backend-typescript/src/modules/city/city.controller.ts

@@ -10,15 +10,10 @@ export default class Controller {
 
   constructor(service: Service) {
     this.service = service;
-
-    this.getItems = this.getItems.bind(this);
-    this.getItemById = this.getItemById.bind(this);
-    this.createItem = this.createItem.bind(this);
-    this.updateItem = this.updateItem.bind(this);
-    this.deleteItem = this.deleteItem.bind(this);
   }
 
-  async getItems(req: Request, res: Response, next: NextFunction): Promise<void> {
+
+  getItems = async (req: Request, res: Response, next: NextFunction): Promise<void> => {
     try {
       const result = await this.service.getItems(req.query);
       res.locals = { data: result, statusCode: HTTP_STATUS.OK };
@@ -29,7 +24,7 @@ export default class Controller {
     }
   }
 
-  async getItemById(req: Request, res: Response, next: NextFunction): Promise<void> {
+  getItemById = async (req: Request, res: Response, next: NextFunction): Promise<void> => {
     try {
       const id = parseInt(req.params.id, 10);
       const result = await this.service.getItemById(id);
@@ -55,7 +50,7 @@ export default class Controller {
     }
   }
 
-  async createItem(req: Request, res: Response, next: NextFunction): Promise<void> {
+  createItem = async (req: Request, res: Response, next: NextFunction): Promise<void> => {
     try {
       validateItem(req.body);
       const result = await this.service.createItem(req.body as City);
@@ -76,7 +71,7 @@ export default class Controller {
     }
   }
 
-  async updateItem(req: Request, res: Response, next: NextFunction): Promise<void> {
+  updateItem = async (req: Request, res: Response, next: NextFunction): Promise<void> => {
     try {
       validateItem(req.body);
       const id = parseInt(req.params.id, 10);
@@ -96,7 +91,7 @@ export default class Controller {
     }
   }
 
-  async deleteItem(req: Request, res: Response, next: NextFunction): Promise<void> {
+  deleteItem = async (req: Request, res: Response, next: NextFunction): Promise<void> => {
     try {
       const id = parseInt(req.params.id, 10);
       const result = await this.service.deleteItem(id);

backend-typescript/src/modules/city/city.routes.ts

@@ -16,15 +16,15 @@ const controller = new Controller(service);
 const admin = permissionHandler(['admin']);
 const editor = permissionHandler(['admin', 'editor']);
 
-router.get('/', controller.getItems.bind(controller));
+router.get('/', controller.getItems);
 
-router.get('/authorized', editor, controller.getItems.bind(controller));
-router.get('/denied', admin, controller.getItems.bind(controller));
+router.get('/authorized', editor, controller.getItems);
+router.get('/denied', admin, controller.getItems);
 
-router.post('/', editor, controller.createItem.bind(controller));
-router.get('/:id', controller.getItemById.bind(controller));
-router.put('/:id', editor, controller.updateItem.bind(controller));
-router.delete('/:id', admin, controller.deleteItem.bind(controller));
+router.post('/', editor, controller.createItem);
+router.get('/:id', controller.getItemById);
+router.put('/:id', editor, controller.updateItem);
+router.delete('/:id', admin, controller.deleteItem);
 
 export default router;