Describe the bug
IconFamilyType forces Icon's family ty'pe to accept values such as 'EvilIcons', 'FontAwesome' etc, however, getIconType helper accepts values such as 'evilicons', 'font-awesome' etc, due to which, default case, ie. MaterialIcon is returned always.
To Reproduce
Steps to reproduce the behaviour:
- Import Icon
- Pass family as
FontAwesome (as expected by TS declaration) and name as address-book.
- See error
Expected behavior
FontAwesome's address-book icon should be visible.
Instead, no icon is identified and ? is displayed.
Additional context / Proposed Solution
Either the IconFamilyType should be updated to reflect actual accepted values, or getIconType should be updated to handle new values specified by IconFamilyType.
In my opinion, IconFamilyType should be updated as it will maintain backward compatibility and fix type issue also, as the new types are anyway buggy by nature.
Willing to submit PR for same.
Describe the bug
IconFamilyTypeforces Icon'sfamilyty'pe to accept values such as'EvilIcons','FontAwesome'etc, however, getIconType helper accepts values such as'evilicons','font-awesome'etc, due to which, default case, ie.MaterialIconis returned always.To Reproduce
Steps to reproduce the behaviour:
FontAwesome(as expected by TS declaration) and name asaddress-book.Expected behavior
FontAwesome's
address-bookicon should be visible.Instead, no icon is identified and
?is displayed.Additional context / Proposed Solution
Either the
IconFamilyTypeshould be updated to reflect actual accepted values, orgetIconTypeshould be updated to handle new values specified byIconFamilyType.In my opinion,
IconFamilyTypeshould be updated as it will maintain backward compatibility and fix type issue also, as the new types are anyway buggy by nature.Willing to submit PR for same.