Skip to content

Commit c139910

Browse files
authored
Merge pull request #1 from osbre/patch-1
Fix parameter type in `launch` and `launchWithExecutable`
2 parents 65ddaef + aba843c commit c139910

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/ChromeDevtoolsProtocol/Instance/Launcher.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,11 +116,11 @@ public function setInput($input)
116116
* Start new Chrome process.
117117
*
118118
* @param ContextInterface $ctx
119-
* @param array ...$args
119+
* @param string ...$args
120120
* @return ProcessInstance
121121
* @throws \Exception
122122
*/
123-
public function launch(ContextInterface $ctx, ...$args): ProcessInstance
123+
public function launch(ContextInterface $ctx, string ...$args): ProcessInstance
124124
{
125125
if ($this->executable) {
126126
$executable = $this->executable;
@@ -169,11 +169,11 @@ public function launch(ContextInterface $ctx, ...$args): ProcessInstance
169169
/**
170170
* @param ContextInterface $ctx
171171
* @param string $executable
172-
* @param array ...$args
172+
* @param string ...$args
173173
* @return ProcessInstance
174174
* @throws \Exception
175175
*/
176-
private function launchWithExecutable(ContextInterface $ctx, string $executable, ...$args): ProcessInstance
176+
private function launchWithExecutable(ContextInterface $ctx, string $executable, string ...$args): ProcessInstance
177177
{
178178
$args = array_unique(array_merge(static::$defaultArgs, $args));
179179

0 commit comments

Comments
 (0)