Skip to content

Commit de1c1e7

Browse files
gallaylgallayl
committed
code review fixes
1 parent 4ff2fda commit de1c1e7

19 files changed

Lines changed: 373 additions & 1090 deletions

‎common/schemas/dependencies-api.json‎

Lines changed: 35 additions & 150 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,7 @@
2020
"type": "string"
2121
}
2222
},
23-
"required": [
24-
"id",
25-
"stackName",
26-
"name",
27-
"checkCommand",
28-
"installationHelp"
29-
],
23+
"required": ["id", "stackName", "name", "checkCommand", "installationHelp"],
3024
"additionalProperties": false
3125
},
3226
"PostDependencyEndpoint": {
@@ -39,10 +33,7 @@
3933
"$ref": "#/definitions/WithOptionalId%3CDependencyWritableFields%2C%22id%22%3E"
4034
}
4135
},
42-
"required": [
43-
"result",
44-
"body"
45-
],
36+
"required": ["result", "body"],
4637
"additionalProperties": false
4738
},
4839
"Dependency": {
@@ -70,15 +61,7 @@
7061
"type": "string"
7162
}
7263
},
73-
"required": [
74-
"id",
75-
"stackName",
76-
"name",
77-
"checkCommand",
78-
"installationHelp",
79-
"createdAt",
80-
"updatedAt"
81-
],
64+
"required": ["id", "stackName", "name", "checkCommand", "installationHelp", "createdAt", "updatedAt"],
8265
"additionalProperties": false
8366
},
8467
"WithOptionalId<DependencyWritableFields,\"id\">": {
@@ -101,12 +84,7 @@
10184
"type": "string"
10285
}
10386
},
104-
"required": [
105-
"checkCommand",
106-
"installationHelp",
107-
"name",
108-
"stackName"
109-
]
87+
"required": ["checkCommand", "installationHelp", "name", "stackName"]
11088
},
11189
"PatchDependencyEndpoint": {
11290
"$ref": "#/definitions/PatchEndpoint%3CDependencyWritableFields%2C%22id%22%3E"
@@ -142,20 +120,14 @@
142120
"type": "string"
143121
}
144122
},
145-
"required": [
146-
"id"
147-
],
123+
"required": ["id"],
148124
"additionalProperties": false
149125
},
150126
"result": {
151127
"type": "object"
152128
}
153129
},
154-
"required": [
155-
"body",
156-
"url",
157-
"result"
158-
],
130+
"required": ["body", "url", "result"],
159131
"additionalProperties": false,
160132
"description": "Endpoint model for updating entities"
161133
},
@@ -169,9 +141,7 @@
169141
"type": "string"
170142
}
171143
},
172-
"required": [
173-
"id"
174-
],
144+
"required": ["id"],
175145
"additionalProperties": false
176146
},
177147
"result": {
@@ -184,17 +154,11 @@
184154
"type": "string"
185155
}
186156
},
187-
"required": [
188-
"satisfied",
189-
"output"
190-
],
157+
"required": ["satisfied", "output"],
191158
"additionalProperties": false
192159
}
193160
},
194-
"required": [
195-
"url",
196-
"result"
197-
],
161+
"required": ["url", "result"],
198162
"additionalProperties": false
199163
},
200164
"DependenciesApi": {
@@ -210,10 +174,7 @@
210174
"$ref": "#/definitions/GetEntityEndpoint%3CDependency%2C%22id%22%3E"
211175
}
212176
},
213-
"required": [
214-
"/dependencies",
215-
"/dependencies/:id"
216-
],
177+
"required": ["/dependencies", "/dependencies/:id"],
217178
"additionalProperties": false
218179
},
219180
"POST": {
@@ -226,10 +187,7 @@
226187
"$ref": "#/definitions/CheckDependencyEndpoint"
227188
}
228189
},
229-
"required": [
230-
"/dependencies",
231-
"/dependencies/:id/check"
232-
],
190+
"required": ["/dependencies", "/dependencies/:id/check"],
233191
"additionalProperties": false
234192
},
235193
"PATCH": {
@@ -239,9 +197,7 @@
239197
"$ref": "#/definitions/PatchDependencyEndpoint"
240198
}
241199
},
242-
"required": [
243-
"/dependencies/:id"
244-
],
200+
"required": ["/dependencies/:id"],
245201
"additionalProperties": false
246202
},
247203
"PUT": {
@@ -255,9 +211,7 @@
255211
"body": {},
256212
"headers": {}
257213
},
258-
"required": [
259-
"result"
260-
],
214+
"required": ["result"],
261215
"additionalProperties": false
262216
}
263217
},
@@ -268,9 +222,7 @@
268222
"$ref": "#/definitions/DeleteEndpoint%3CDependency%2C%22id%22%3E"
269223
}
270224
},
271-
"required": [
272-
"/dependencies/:id"
273-
],
225+
"required": ["/dependencies/:id"],
274226
"additionalProperties": false
275227
},
276228
"HEAD": {
@@ -284,9 +236,7 @@
284236
"body": {},
285237
"headers": {}
286238
},
287-
"required": [
288-
"result"
289-
],
239+
"required": ["result"],
290240
"additionalProperties": false
291241
}
292242
},
@@ -301,9 +251,7 @@
301251
"body": {},
302252
"headers": {}
303253
},
304-
"required": [
305-
"result"
306-
],
254+
"required": ["result"],
307255
"additionalProperties": false
308256
}
309257
},
@@ -318,9 +266,7 @@
318266
"body": {},
319267
"headers": {}
320268
},
321-
"required": [
322-
"result"
323-
],
269+
"required": ["result"],
324270
"additionalProperties": false
325271
}
326272
},
@@ -335,19 +281,12 @@
335281
"body": {},
336282
"headers": {}
337283
},
338-
"required": [
339-
"result"
340-
],
284+
"required": ["result"],
341285
"additionalProperties": false
342286
}
343287
}
344288
},
345-
"required": [
346-
"GET",
347-
"POST",
348-
"PATCH",
349-
"DELETE"
350-
],
289+
"required": ["GET", "POST", "PATCH", "DELETE"],
351290
"additionalProperties": false
352291
},
353292
"GetCollectionEndpoint<Dependency>": {
@@ -366,10 +305,7 @@
366305
"$ref": "#/definitions/GetCollectionResult%3CDependency%3E"
367306
}
368307
},
369-
"required": [
370-
"query",
371-
"result"
372-
],
308+
"required": ["query", "result"],
373309
"additionalProperties": false,
374310
"description": "Rest endpoint model for getting / querying collections"
375311
},
@@ -389,52 +325,31 @@
389325
"properties": {
390326
"id": {
391327
"type": "string",
392-
"enum": [
393-
"ASC",
394-
"DESC"
395-
]
328+
"enum": ["ASC", "DESC"]
396329
},
397330
"stackName": {
398331
"type": "string",
399-
"enum": [
400-
"ASC",
401-
"DESC"
402-
]
332+
"enum": ["ASC", "DESC"]
403333
},
404334
"name": {
405335
"type": "string",
406-
"enum": [
407-
"ASC",
408-
"DESC"
409-
]
336+
"enum": ["ASC", "DESC"]
410337
},
411338
"checkCommand": {
412339
"type": "string",
413-
"enum": [
414-
"ASC",
415-
"DESC"
416-
]
340+
"enum": ["ASC", "DESC"]
417341
},
418342
"installationHelp": {
419343
"type": "string",
420-
"enum": [
421-
"ASC",
422-
"DESC"
423-
]
344+
"enum": ["ASC", "DESC"]
424345
},
425346
"createdAt": {
426347
"type": "string",
427-
"enum": [
428-
"ASC",
429-
"DESC"
430-
]
348+
"enum": ["ASC", "DESC"]
431349
},
432350
"updatedAt": {
433351
"type": "string",
434-
"enum": [
435-
"ASC",
436-
"DESC"
437-
]
352+
"enum": ["ASC", "DESC"]
438353
}
439354
},
440355
"additionalProperties": false,
@@ -444,15 +359,7 @@
444359
"type": "array",
445360
"items": {
446361
"type": "string",
447-
"enum": [
448-
"id",
449-
"stackName",
450-
"name",
451-
"checkCommand",
452-
"installationHelp",
453-
"createdAt",
454-
"updatedAt"
455-
]
362+
"enum": ["id", "stackName", "name", "checkCommand", "installationHelp", "createdAt", "updatedAt"]
456363
},
457364
"description": "The result set will be limited to these fields"
458365
},
@@ -873,10 +780,7 @@
873780
"description": "List of the selected entities"
874781
}
875782
},
876-
"required": [
877-
"count",
878-
"entries"
879-
],
783+
"required": ["count", "entries"],
880784
"additionalProperties": false,
881785
"description": "Response Model for GetCollection"
882786
},
@@ -890,15 +794,7 @@
890794
"type": "array",
891795
"items": {
892796
"type": "string",
893-
"enum": [
894-
"id",
895-
"stackName",
896-
"name",
897-
"checkCommand",
898-
"installationHelp",
899-
"createdAt",
900-
"updatedAt"
901-
]
797+
"enum": ["id", "stackName", "name", "checkCommand", "installationHelp", "createdAt", "updatedAt"]
902798
},
903799
"description": "The list of fields to select"
904800
}
@@ -913,20 +809,14 @@
913809
"description": "The entity's unique identifier"
914810
}
915811
},
916-
"required": [
917-
"id"
918-
],
812+
"required": ["id"],
919813
"additionalProperties": false
920814
},
921815
"result": {
922816
"$ref": "#/definitions/Dependency"
923817
}
924818
},
925-
"required": [
926-
"query",
927-
"url",
928-
"result"
929-
],
819+
"required": ["query", "url", "result"],
930820
"additionalProperties": false,
931821
"description": "Endpoint model for getting a single entity"
932822
},
@@ -940,21 +830,16 @@
940830
"type": "string"
941831
}
942832
},
943-
"required": [
944-
"id"
945-
],
833+
"required": ["id"],
946834
"additionalProperties": false
947835
},
948836
"result": {
949837
"type": "object"
950838
}
951839
},
952-
"required": [
953-
"url",
954-
"result"
955-
],
840+
"required": ["url", "result"],
956841
"additionalProperties": false,
957842
"description": "Endpoint model for deleting entities"
958843
}
959844
}
960-
}
845+
}

0 commit comments

Comments
 (0)