ZO: Shadow Harmony 4-Set effect is not included in calculations

[thailyn]

Shadow Harmony's 4-piece set effect increases the user's ATK and CRIT rate by 4% each per stack, up to three stacks. When configuring Disk Drive settings, there is a slider for this set to indicate the number of stacks. However, these buffs are not included in calculations. In the "All target buffs" section there appear to be buffs configured for these effects (named set4_stack_atk_ and set4_stack_crit_), but they appear to always have zero stacks:

cond:

{
  "Trigger": {
    "Trigger": {
      "ShadowHarmony": {
        "stacks": 0
      }
    }
  }
}

read:

{
  "op": "read",
  "x": [],
  "br": [],
  "tag": {
    "src": "Trigger",
    "preset": "preset0",
    "et": "display",
    "qt": "combat",
    "q": "crit_",
    "sheet": "ShadowHarmony",
    "name": "set4_stack_crit_"
  }
}

I notice that the read section references "combat", which I assume is from the "initial"/"combat"/"final" contexts (or whatever they are called) for what to include in calculations (although I am very unclear what these technically mean). However, the only place I can see for indicating which context to use is when trying to optimize for certain stats, such as "Final ATK" or "Energy Regen". In any case, those only provide options for "initial" and "final", and neither include the set bonus's ATK or CRIT rate buffs.

[thailyn]

I was running some additional optimizations on the site and noticed that the 4-piece set bonuses were being applied correctly for Soldier 0 - Anby, and when I changed the slider in the "Conditionals" section, the ATK and CRIT rate calculations were being properly updated. The initial bug report was in regards to the stat calculations and optimizations for Trigger. I also see that for Soldier 0 - Anby, the slider to indicate the number of stacks has additional lines below it indicating the magnitude of the buffs, but no such indication is provided below the slider when optimizing Trigger.

[nguyentvan7]

@thailyn do you happen to have your DB still? I suspect this is some DB corruption, as the sliders work fine for me

[thailyn]

Hi, @nguyentvan7 , I do still have the DB. I've attached it to this comment. I did a quick check again, and it looks like the bug is still present when optimizing Trigger.

Database_1_2025-12-24_05-51-02.json

To put a picture to the difference with the slider between the agents, this is what it looks like with Solder 0 - Anby:

And this is what it looks like for Trigger: