fix: ghost unpublish delete record operations (#518)

* fix: add optional chaining for ghost unpublish operations that should delete records on Algolia

* fix: siteLang logic when unpublishing posts

Author: scissorsneedfoodtoo

lib/utils/helpers.js

@@ -108,10 +108,10 @@ export const getBaseSiteURL = (url) => {
   let siteLang;
   if (host.startsWith('chinese')) {
     siteLang = 'chinese';
-  } else if (pathParts.length === 3) {
+  } else if (pathParts.length >= 3) {
     // Webhooks will only be triggered by posts, so the path will
-    // always have 3 parts for our localized instances:
-    // (/<lang>/news/<slug>/).
+    // always have 3-4 parts for our localized instances:
+    // (/<lang>/news/<slug>/) or (/<lang>/news/<author>/<slug>/).
     // Or if it's coming from a Dockerized test instance / localhost,
     // it will only have 1 part: (/<slug>/).
     siteLang = pathParts[0];

packages/ghost/delete-record/index.js

@@ -18,15 +18,15 @@ export const deleteRecord = async (req) => {
 
     // Whether a published post is unpublished or deleted, the
     // status will be 'published' in the previous state
-    if (prevState.status === 'published') {
+    if (prevState?.status === 'published') {
       // Deleted posts don't include a url or a primary author object.
       // But since every post returns an author array, we can use
       // the first author object to determine the search index name.
       // This helps since we're handling data from localhost,
       // chinese.freecodecamp.org, and www.freecodecamp.org.
-      const primaryAuthorURL = prevState.authors
-        ? prevState.authors[0].url
-        : currState.authors[0].url;
+      const primaryAuthorURL = prevState?.authors
+        ? prevState?.authors[0]?.url
+        : currState?.authors[0]?.url;
       const siteURL = getBaseSiteURL(primaryAuthorURL);
       const indexName = getSearchIndexName(siteURL);