Add common propTypes for Events

[jrogatis]

We use a common library of proptypes. Add events type check and change the object at each one of the files that use this prop.

[caskuplich]

@jrogatis I'd like to help with this issue. How can I start?

[gURLmeetsCode]

@jrogatis I would like to help as well. Please me know if there is anything I can do.

[jrogatis]

sorry about the delayed answer! Yes all help will be appreciated! @gURLmeetsCode and @caskuplich ! Its simple. look at the code and find the complex prototypes that repeat along the other component classes and add a file inside at the commom prototypes dir and try to export then there. Any help that you needed please contact me !

[caskuplich]

@jrogatis Let me see if I get it: I found at least 3 files that could use the common propTypes isEvent and isCurUser from the file client/util/commonPropTypes.js:

• client/components/NavBar/NavBar.js
• client/components/NotificationBar/NotificationBar.js
• client/pages/NewEvent/index.js

But I haven't identified patterns of complex propTypes that could be reused by components. Maybe you can help me find these propTypes.

[jrogatis]

@caskuplich
curUser: PropTypes.shape({
_id: PropTypes.string, // Unique user id
name: PropTypes.string, // User name
avatar: PropTypes.string, // URL to image representing user(?)
}).isRequired,

is one of than is used all over the app.

[caskuplich]

@jrogatis Unfortunately I can't run the project on my local machine. After Google redirects to the app, the following error appears:

Error
    at /<...>/meeting-for-good/node_modules/passport-google-oauth20/lib/strategy.js:95:21
    at passBackControl (/<...>/meeting-for-good/node_modules/oauth/lib/oauth2.js:132:9)
    at IncomingMessage.<anonymous> (/<...>/meeting-for-good/node_modules/oauth/lib/oauth2.js:157:7)
    at emitNone (events.js:110:20)
    at IncomingMessage.emit (events.js:207:7)
    at IncomingMessage.wrappedEmit [as emit] (/<...>/meeting-for-good/node_modules/opbeat/lib/instrumentation/http-shared.js:116:29)
    at endReadableNT (_stream_readable.js:1045:12)
    at instrumented (/<...>/meeting-for-good/node_modules/opbeat/lib/instrumentation/index.js:102:27)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)
    at process.fallback (/<...>/meeting-for-good/node_modules/opbeat/lib/instrumentation/async-hooks.js:514:17)

Node version: v8.3.0
MongoDB version: v3.4.7
OS: Trisquel 7 (Ubuntu 14.04)

Can you help me with this issue?

[jrogatis]

@caskuplich Hey there. Sure! Do you set the .env file properly with the correct api keys ?

[caskuplich]

@jrogatis I just didn't set the FACEBOOK_KEY, FACEBOOK_SECRET, AWS_ACCESS_KEY_ID, AWS_SECRET_KEY, and EMAIL_FROM.

Is there any problem to set the URL restrictions and redirect_url to http://localhost:8080 and http://localhost:8080/api/auth/google/callback, respectively on the Google API Console when I create a new OAuth API client_id? I enabled the Calendar API as stated on the README file and also created an API Key for Google Analytics.

[jrogatis]

You need to set this call back properly at the google api console.
http://localhost:8080/api/auth/google/callback
at the javascript authorized URLs at restrictions area.
@caskuplich

[caskuplich]

This is my Google Developers console settings:

This is a OAuth Client ID credential.

It seems that the problem is on the meeting-for-good code on the return. For some reason the code returned from Google causes the error I mentioned above. The URL of the return comes with a code query string, like this: http://localhost:8080/api/auth/google/callback?code=<code with 46 chars>. This is right, isn't it?

[jrogatis]

do you set the Oauth consentiment screen ? and enable the API ? @caskuplich ?

[caskuplich]

@jrogatis, yes. I set my email address and the Product Name as "Meeting for Good Dev". The other fields are optional.

Can I sign-in the application with the same email address I set in the Consent screen or should I enter with a different Google Account?