-
-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathlp-api_test.go
More file actions
427 lines (367 loc) · 12.1 KB
/
lp-api_test.go
File metadata and controls
427 lines (367 loc) · 12.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
package main
import (
"os"
"os/exec"
"strings"
"testing"
)
func Test_get(t *testing.T) {
backupArgs := os.Args
os.Args = append(os.Args, "-staging")
os.Args = append(os.Args, "-output")
os.Args = append(os.Args, "payload.json")
os.Args = append(os.Args, "get")
os.Args = append(os.Args, "bugs/1923283")
main()
os.Args = backupArgs
}
func Test_put(t *testing.T) {
t.Cleanup(func() {
os.Remove("payload.json")
})
backupArgs := os.Args
os.Args = append(os.Args, "-staging")
os.Args = append(os.Args, "-output")
os.Args = append(os.Args, "")
os.Args = append(os.Args, "put")
os.Args = append(os.Args, "bugs/1923283")
os.Args = append(os.Args, "payload.json")
main()
os.Args = backupArgs
}
func Test_patch(t *testing.T) {
backupArgs := os.Args
os.Args = append(os.Args, "-staging")
os.Args = append(os.Args, "patch")
os.Args = append(os.Args, "bugs/1923283")
os.Args = append(os.Args, "tags:=[\"focal\",\"jammy\"]")
main()
os.Args = backupArgs
os.Args = append(os.Args, "-staging")
os.Args = append(os.Args, "patch")
os.Args = append(os.Args, "bugs/1923283")
os.Args = append(os.Args, "tags:=[]")
main()
os.Args = backupArgs
}
func Test_post(t *testing.T) {
backupArgs := os.Args
os.Args = append(os.Args, "-staging")
os.Args = append(os.Args, "post")
os.Args = append(os.Args, "bugs/1923283")
os.Args = append(os.Args, "ws.op=newMessage")
os.Args = append(os.Args, "content=test")
main()
os.Args = backupArgs
}
func Test_productionAPI(t *testing.T) {
os.Clearenv()
os.Setenv("LAUNCHPAD_TOKEN", "::")
backupArgs := os.Args
os.Args = append(os.Args, "-debug")
os.Args = append(os.Args, "get")
os.Args = append(os.Args, "https://api.launchpad.net/devel/bugs/1")
main()
os.Args = backupArgs
}
func Test_stagingAPI(t *testing.T) {
os.Clearenv()
os.Setenv("LAUNCHPAD_TOKEN", "::")
backupArgs := os.Args
os.Args = append(os.Args, "-debug")
os.Args = append(os.Args, "get")
os.Args = append(os.Args, "https://api.staging.launchpad.net/devel/bugs/1")
main()
os.Args = backupArgs
}
func Test_timeout10s(t *testing.T) {
os.Clearenv()
os.Setenv("LAUNCHPAD_TOKEN", "::")
backupArgs := os.Args
os.Args = append(os.Args, "-debug")
os.Args = append(os.Args, "-timeout")
os.Args = append(os.Args, "10s")
os.Args = append(os.Args, "get")
os.Args = append(os.Args, "https://api.launchpad.net/devel/bugs/1")
main()
os.Args = backupArgs
}
func Test_download(t *testing.T) {
t.Cleanup(func() {
os.Remove("OEMpatch")
})
os.Clearenv()
os.Setenv("LAUNCHPAD_TOKEN", "::")
backupArgs := os.Args
os.Args = append(os.Args, "-debug=0")
os.Args = append(os.Args, "download")
os.Args = append(os.Args, "https://api.launchpad.net/devel/bugs/1/+attachment/26604/data")
main()
os.Args = backupArgs
if _, err := os.Stat("OEMpatch"); os.IsNotExist(err) {
t.Errorf("Expected file 'OEMpatch' was not created")
}
}
func Test_fileUpload_staging(t *testing.T) {
// Ensure we use config file credentials, not dummy env vars from other tests
os.Unsetenv("LAUNCHPAD_TOKEN")
// Create a test file
tmpDir := t.TempDir()
testFile := tmpDir + "/test-upload.log"
testContent := []byte("Test log content from lp-api integration test\n")
if err := os.WriteFile(testFile, testContent, 0644); err != nil {
t.Fatalf("Failed to create test file: %v", err)
}
backupArgs := os.Args
defer func() { os.Args = backupArgs }()
// Reset os.Args to just the program name
os.Args = []string{os.Args[0]}
os.Args = append(os.Args, "-staging")
os.Args = append(os.Args, "post")
os.Args = append(os.Args, "bugs/1923283")
os.Args = append(os.Args, "ws.op=addAttachment")
os.Args = append(os.Args, "attachment=@"+testFile)
os.Args = append(os.Args, "comment=Integration test attachment from lp-api_test.go")
os.Args = append(os.Args, "description=Automated test file upload")
// Note: This test may fail if staging server is unavailable
// That's expected behavior - staging is not always online
main()
}
func Test_fileUpload_withDescription_staging(t *testing.T) {
// Ensure we use config file credentials
os.Unsetenv("LAUNCHPAD_TOKEN")
// Create a test file with different content
tmpDir := t.TempDir()
testFile := tmpDir + "/test-upload-2.txt"
testContent := []byte("Another test file with description\n")
if err := os.WriteFile(testFile, testContent, 0644); err != nil {
t.Fatalf("Failed to create test file: %v", err)
}
backupArgs := os.Args
defer func() { os.Args = backupArgs }()
os.Args = []string{os.Args[0]}
os.Args = append(os.Args, "-staging")
os.Args = append(os.Args, "post")
os.Args = append(os.Args, "bugs/1923283")
os.Args = append(os.Args, "ws.op=addAttachment")
os.Args = append(os.Args, "attachment=@"+testFile)
os.Args = append(os.Args, "comment=Test with description field")
os.Args = append(os.Args, "description=This tests the optional description parameter")
// Note: This test may fail if staging server is unavailable
main()
}
func Test_fileUpload_missingComment(t *testing.T) {
if os.Getenv("TEST_SUBPROCESS") == "1" {
// Create a test file
tmpDir := t.TempDir()
testFile := tmpDir + "/test-upload-error.log"
testContent := []byte("This should fail due to missing comment\n")
if err := os.WriteFile(testFile, testContent, 0644); err != nil {
t.Fatalf("Failed to create test file: %v", err)
}
// Create dummy config to bypass auth flow
configFile := tmpDir + "/dummy_config.toml"
configContent := []byte("oauth_consumer_key = \"foo\"\noauth_token = \"bar\"\noauth_token_secret = \"baz\"\n")
if err := os.WriteFile(configFile, configContent, 0644); err != nil {
t.Fatalf("Failed to create config file: %v", err)
}
// Ensure we use config file credentials
os.Unsetenv("LAUNCHPAD_TOKEN")
os.Args = []string{os.Args[0]}
os.Args = append(os.Args, "-staging")
os.Args = append(os.Args, "-conf", configFile)
os.Args = append(os.Args, "post")
os.Args = append(os.Args, "bugs/1923283")
os.Args = append(os.Args, "ws.op=addAttachment")
os.Args = append(os.Args, "attachment=@"+testFile)
// Intentionally omit comment parameter
main()
return
}
cmd := exec.Command(os.Args[0], "-test.run=Test_fileUpload_missingComment")
cmd.Env = append(os.Environ(), "TEST_SUBPROCESS=1")
output, err := cmd.CombinedOutput()
// Check exit code
if e, ok := err.(*exec.ExitError); ok && !e.Success() {
// Expected exit status 1
stderr := string(output)
if !strings.Contains(stderr, "comment") && !strings.Contains(stderr, "required") {
t.Errorf("Expected error message about missing comment, got: %s", stderr)
}
return
}
t.Fatalf("process ran with err %v, want exit status 1", err)
}
func Test_fileUpload_fileNotFound(t *testing.T) {
if os.Getenv("TEST_SUBPROCESS") == "1" {
// Create dummy config to bypass auth flow
tmpDir := t.TempDir()
configFile := tmpDir + "/dummy_config.toml"
configContent := []byte("oauth_consumer_key = \"foo\"\noauth_token = \"bar\"\noauth_token_secret = \"baz\"\n")
if err := os.WriteFile(configFile, configContent, 0644); err != nil {
t.Fatalf("Failed to create config file: %v", err)
}
// Ensure we use config file credentials
os.Unsetenv("LAUNCHPAD_TOKEN")
os.Args = []string{os.Args[0]}
os.Args = append(os.Args, "-staging")
os.Args = append(os.Args, "-conf", configFile)
os.Args = append(os.Args, "post")
os.Args = append(os.Args, "bugs/1923283")
os.Args = append(os.Args, "ws.op=addAttachment")
os.Args = append(os.Args, "attachment=@/nonexistent/file.log")
os.Args = append(os.Args, "comment=This should fail")
main()
return
}
cmd := exec.Command(os.Args[0], "-test.run=Test_fileUpload_fileNotFound")
cmd.Env = append(os.Environ(), "TEST_SUBPROCESS=1")
output, err := cmd.CombinedOutput()
// Check exit code
if e, ok := err.(*exec.ExitError); ok && !e.Success() {
// Expected exit status 1
stderr := string(output)
if !strings.Contains(stderr, "File not found") {
t.Errorf("Expected 'File not found' error message, got: %s", stderr)
}
return
}
t.Fatalf("process ran with err %v, want exit status 1", err)
}
func TestIsFileAttachment(t *testing.T) {
tests := []struct {
name string
param string
want bool
}{
{"valid file with @ prefix", "@file.log", true},
{"absolute path", "@/absolute/path.txt", true},
{"relative path", "@../relative/file.png", true},
{"no @ prefix", "file.log", false},
{"empty string", "", false},
{"only @", "@", true},
{"double @", "@@file.log", true},
{"@ with spaces", "@file with spaces.log", true},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := isFileAttachment(tt.param); got != tt.want {
t.Errorf("isFileAttachment(%q) = %v, want %v", tt.param, got, tt.want)
}
})
}
}
func TestExtractFilePath(t *testing.T) {
tests := []struct {
name string
param string
want string
}{
{"valid file", "@file.log", "file.log"},
{"absolute path", "@/absolute/path.txt", "/absolute/path.txt"},
{"relative path", "@../relative/file.png", "../relative/file.png"},
{"no @ prefix", "file.log", ""},
{"empty string", "", ""},
{"only @", "@", ""},
{"double @", "@@file.log", "@file.log"},
{"@ with spaces", "@file with spaces.log", "file with spaces.log"},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := extractFilePath(tt.param); got != tt.want {
t.Errorf("extractFilePath(%q) = %q, want %q", tt.param, got, tt.want)
}
})
}
}
func TestReadFileContent(t *testing.T) {
// Create temporary test files
tmpDir := t.TempDir()
// Test reading valid text file
t.Run("read valid text file", func(t *testing.T) {
testFile := tmpDir + "/test.txt"
content := []byte("test content")
if err := os.WriteFile(testFile, content, 0644); err != nil {
t.Fatalf("Failed to create test file: %v", err)
}
data, err := readFileContent(testFile)
if err != nil {
t.Errorf("readFileContent() error = %v", err)
}
if string(data) != string(content) {
t.Errorf("readFileContent() = %q, want %q", string(data), string(content))
}
})
// Test reading binary file
t.Run("read binary file", func(t *testing.T) {
testFile := tmpDir + "/test.bin"
content := []byte{0x00, 0x01, 0x02, 0xFF}
if err := os.WriteFile(testFile, content, 0644); err != nil {
t.Fatalf("Failed to create test file: %v", err)
}
data, err := readFileContent(testFile)
if err != nil {
t.Errorf("readFileContent() error = %v", err)
}
if len(data) != len(content) {
t.Errorf("readFileContent() length = %d, want %d", len(data), len(content))
}
})
// Test file not found error
t.Run("file not found", func(t *testing.T) {
_, err := readFileContent(tmpDir + "/nonexistent.txt")
if err == nil {
t.Error("readFileContent() expected error for non-existent file")
}
})
}
func TestDetectContentType(t *testing.T) {
tests := []struct {
name string
filepath string
want string
}{
{"text log", "file.log", "text/"},
{"text file", "file.txt", "text/plain"},
{"png image", "screenshot.png", "image/png"},
{"jpg image", "photo.jpg", "image/jpeg"},
{"json file", "config.json", "application/json"},
{"yaml file", "config.yaml", "application/"},
{"tar.gz archive", "backup.tar.gz", "application/gzip"},
{"unknown extension", "file.xyz", "application/octet-stream"},
{"uppercase extension", "FILE.LOG", "text/"},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
got := detectContentType(tt.filepath)
// Some MIME types may have charset suffix
if !strings.HasPrefix(got, tt.want) {
t.Errorf("detectContentType(%q) = %q, want prefix %q", tt.filepath, got, tt.want)
}
})
}
}
func TestBuildMultipartBody(t *testing.T) {
attachment := FileAttachment{
Path: "/tmp/test.log",
Filename: "test.log",
ContentType: "text/plain",
Data: []byte("test file content"),
}
params := map[string]string{
"ws.op": "addAttachment",
"description": "Test description",
}
body, contentType, err := buildMultipartBody(attachment, params)
if err != nil {
t.Fatalf("buildMultipartBody() error = %v", err)
}
// Verify content type header
if !strings.HasPrefix(contentType, "multipart/form-data; boundary=") {
t.Errorf("Content-Type = %q, want prefix 'multipart/form-data; boundary='", contentType)
}
// Verify body is not empty
if body.Len() == 0 {
t.Error("buildMultipartBody() returned empty body")
}
}