fix: forbid non-dollar names starting with $

Author: jodavies

check/fixes.frm

@@ -4461,6 +4461,21 @@ assert warning?("Excess information in symmetric properties")
 assert warning?("Illegal information in number of arguments properties")
 assert warning?("Undefined $-variable")
 *--#] Issue766 : 
+*--#[ Issue782 : 
+S $s;
+V $v;
+I $i;
+F $f;
+Set $ss;
+Local $test = 1;
+.end
+assert compile_error?("Illegally formed name in symbol statement")
+assert compile_error?("Illegally formed name in vector statement")
+assert compile_error?("Illegally formed name in index statement")
+assert compile_error?("Illegally formed function/tensor name")
+assert compile_error?("Illegal name for set")
+assert compile_error?("Illegal name for expression")
+*--#] Issue782 : 
 *--#[ Issue796 : 
 * Regression: the fix for 796 deadlocks here:
 Symbol x;

sources/comexpr.c

@@ -112,12 +112,11 @@ int DoExpr(UBYTE *inp, int type, int par)
 		else p++;
 	}
 	if ( *p ) {		/* Variety with the = sign */
-		if ( ( q = SkipAName(inp) ) == 0 || q[-1] == '_' ) {
+		q = SkipAName(inp);
+		if ( *inp == '$' || q == 0 || q[-1] == '_' ) {
 			MesPrint("&Illegal name for expression");
 			error = 1;
-			if ( q[-1] == '_' ) {
-				while ( FG.cTable[*q] < 2 || *q == '_' ) q++;
-			}
+			return(error);
 		}
 		else {
 			c = *q; *q = 0;

sources/names.c

@@ -3261,6 +3261,7 @@ int TestName(UBYTE *name)
 	}
 	while ( *name ) {
 		if ( *name == '_' ) return(-1);
+		if ( *name == '$' ) return(-1);
 		name++;
 	}
 	return(0);