From f449230ce269620114ca54c902bbcf24b8b5cb8e Mon Sep 17 00:00:00 2001
From: Nikhil Mittal <nik.mittal165@gmail.com>
Date: Mon, 13 Jul 2026 11:55:51 +0530
Subject: [PATCH] fix: bump bundled PMD from 7.25.0 to 7.26.0 (#2065)

Upgrades bundled PMD version to 7.26.0 so that custom rulesets
referencing rules added in PMD 7.26.0 (e.g. InvocableClassNoArgConstructor)
can be loaded without RuleSetLoadException.

Updates version references in constants.ts, libs.versions.toml, and
package.json. Adds InvocableClassNoArgConstructor to RULE_MAPPINGS and
apex goldfile.
---
 .../gradle/libs.versions.toml                       |  2 +-
 packages/code-analyzer-pmd-engine/package.json      |  2 +-
 packages/code-analyzer-pmd-engine/src/constants.ts  |  2 +-
 .../src/pmd-rule-mappings.ts                        |  4 ++++
 .../pmdGoldfiles/rules_apexOnly.goldfile.json       | 13 +++++++++++++
 5 files changed, 20 insertions(+), 3 deletions(-)

diff --git a/packages/code-analyzer-pmd-engine/gradle/libs.versions.toml b/packages/code-analyzer-pmd-engine/gradle/libs.versions.toml
index 085caa9c..dab93fc7 100644
--- a/packages/code-analyzer-pmd-engine/gradle/libs.versions.toml
+++ b/packages/code-analyzer-pmd-engine/gradle/libs.versions.toml
@@ -8,7 +8,7 @@
 [versions]
 hamcrest = "3.0"
 junit-jupiter = "5.14.4"
-pmd = "7.25.0" # !!! IMPORTANT !!! KEEP THIS IN SYNC WITH PMD_VERSION INSIDE OF: src/constants.ts
+pmd = "7.26.0" # !!! IMPORTANT !!! KEEP THIS IN SYNC WITH PMD_VERSION INSIDE OF: src/constants.ts
 
 # For the following: Keep in sync with whatever pmd-core pulls in. Basically, we don't want duplicates in our java-lib folder.
 # To see pmd-core's dependencies, go to https://mvnrepository.com/artifact/net.sourceforge.pmd/pmd-core
diff --git a/packages/code-analyzer-pmd-engine/package.json b/packages/code-analyzer-pmd-engine/package.json
index bb259299..c62f5de3 100644
--- a/packages/code-analyzer-pmd-engine/package.json
+++ b/packages/code-analyzer-pmd-engine/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@salesforce/code-analyzer-pmd-engine",
   "description": "Plugin package that adds 'pmd' and 'cpd' as engines into Salesforce Code Analyzer",
-  "version": "0.43.0",
+  "version": "0.44.0-SNAPSHOT",
   "author": "The Salesforce Code Analyzer Team",
   "license": "BSD-3-Clause",
   "homepage": "https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/overview",
diff --git a/packages/code-analyzer-pmd-engine/src/constants.ts b/packages/code-analyzer-pmd-engine/src/constants.ts
index 868a3cd0..0c0b6e1a 100644
--- a/packages/code-analyzer-pmd-engine/src/constants.ts
+++ b/packages/code-analyzer-pmd-engine/src/constants.ts
@@ -1,5 +1,5 @@
 // !!! IMPORTANT !!! KEEP THIS IN SYNC WITH gradle/libs.versions.toml
-export const PMD_VERSION: string = '7.25.0';
+export const PMD_VERSION: string = '7.26.0';
 
 export const PMD_ENGINE_NAME: string = "pmd";
 export const CPD_ENGINE_NAME: string = "cpd";
diff --git a/packages/code-analyzer-pmd-engine/src/pmd-rule-mappings.ts b/packages/code-analyzer-pmd-engine/src/pmd-rule-mappings.ts
index b1a88651..0ecfd953 100644
--- a/packages/code-analyzer-pmd-engine/src/pmd-rule-mappings.ts
+++ b/packages/code-analyzer-pmd-engine/src/pmd-rule-mappings.ts
@@ -216,6 +216,10 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
         severity: SeverityLevel.Moderate,
         tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.ERROR_PRONE,    COMMON_TAGS.LANGUAGES.APEX]
     },
+    "InvocableClassNoArgConstructor": {
+        severity: SeverityLevel.Moderate,
+        tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.ERROR_PRONE,    COMMON_TAGS.LANGUAGES.APEX]
+    },
     "LocalVariableNamingConventions": {
         severity: SeverityLevel.Moderate,
         tags: [COMMON_TAGS.RECOMMENDED, COMMON_TAGS.CATEGORIES.CODE_STYLE,     COMMON_TAGS.LANGUAGES.APEX]
diff --git a/packages/code-analyzer-pmd-engine/test/test-data/pmdGoldfiles/rules_apexOnly.goldfile.json b/packages/code-analyzer-pmd-engine/test/test-data/pmdGoldfiles/rules_apexOnly.goldfile.json
index 57ca779f..32151778 100644
--- a/packages/code-analyzer-pmd-engine/test/test-data/pmdGoldfiles/rules_apexOnly.goldfile.json
+++ b/packages/code-analyzer-pmd-engine/test/test-data/pmdGoldfiles/rules_apexOnly.goldfile.json
@@ -816,6 +816,19 @@
       "https://docs.pmd-code.org/pmd-doc-{{PMD_VERSION}}/pmd_rules_apex_errorprone.html#inaccessibleauraenabledgetter"
     ]
   },
+  {
+    "name": "InvocableClassNoArgConstructor",
+    "severityLevel": 3,
+    "tags": [
+      "Recommended",
+      "ErrorProne",
+      "Apex"
+    ],
+    "description": "Apex classes containing @InvocableVariable properties used for flow parameters must expose a visible, zero-argument constructor to prevent runtime instantiation errors under modern Salesforce API versions.",
+    "resourceUrls": [
+      "https://docs.pmd-code.org/pmd-doc-{{PMD_VERSION}}/pmd_rules_apex_errorprone.html#invocableclassnoargconstructor"
+    ]
+  },
   {
     "name": "LocalVariableNamingConventions",
     "severityLevel": 3,