Improve performance by switching method channels to generated pigeon code.

[panmari]

Describe your issue. If applicable, add screenshots to help explain your problem.

See https://pub.dev/packages/pigeon. This would in particular help with performance of #732. Plus it simplifies code by depending on code generation.

Steps to reproduce.

N/A

What is the expected result?

N/A

Did you try our example app?

Yes

Is it reproducible in the example app?

Yes

Reproducible in which OS?

iOS and Android

Flutter/Dart Version?

No response

Plugin Version?

Most recent in tree.

[bensonarafat]

I don't know how this sounds with @fbernaly
If it is okay, I can add the feature

[fbernaly]

@panmari: take this package: https://github.com/flutter-ml/google_ml_kit_flutter/tree/develop/packages/google_mlkit_commons and work on those changes I would like to see how it looks and then we will see if we implement it for the rest of the plugins.

[panmari]

I looked into how much work this is for the image labeling plugin. It's unfortunately a considerable amount of work to get this done, see my (incomplete) attempt at https://github.com/flutter-ml/google_ml_kit_flutter/compare/develop...panmari:Google-Ml-Kit-plugin:pigeon?expand=1.

One of the really nice things: Having multiple instances becomes really easy, because pigeon supports setting a channel suffix:

  factory ImageLabeler({required ImageLabelerOptions options, String identifier = ''}) {
    api = ImageLabelDetectorApi(messageChannelSuffix: identifier);
    api.create(options);
  }

So a lot of the custom logic for handling multiple models at once could be deleted (if I understand the model correctly)

[jymden]

This looks really interesting. I'm building an app that uses pose detection. I've been working on optimization for months now and gotten my own part of the analysis down to a couple of ms.

But that doesn't really help much when the round trip through the method channel takes 20-40 ms per frame. I'm considering going full native on the camera side for this, but looking into Pigeon might be a better solution.

[fbernaly]

Feel free to send a PR with your contribution. We are open to PRs.

[github-actions]

This issue is stale because it has been open for 30 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 14 days since being marked as stale.