Additional checks for FAA0001

[bkqc]

[The first 2 were transformed by FAA0003 but I unfortunately didn't keep the original form]

• (model.Items.Count == 0).Should().BeTrue();
  • model.Items.Should().BeEmpty()
• (model.Amount > 0).Should().BeTrue();
  • model.Amount.Should().BePositive();
• model.Items.Exists(x => x.Amout == 300).Should().BeTrue();
  • model.Items.Should().Contain(x => x.Amount == 300);
• model.Items.ToList().Exists(x => x == "444555666").Should().BeTrue();
  • model.Items.Should().Contain(x => x == "444555666");
• Assert.IsTrue(dict.Count == 2); transformed to (dict.Count == 2).Should().BeTrue(); by FAA0003
  • dict.Should().HaveCount(2);
• Assert.IsTrue(dict[Ui.Libel1] == Controleur.PremierDuMois); transformed to (dict[Ui.Libel1] == Controleur.PremierDuMois).Should().BeTrue(); by FAA0003
  • dict.Should().ContainKey(Ui.Libel1).WhoseValue.Should().Be(Controleur.PremierDuMois);
• model.IsSomething.Should().Be(true);
  • model.IsSomething.Should().BeTrue();

[Meir017]

(model.Items.Count == 0).Should().BeTrue();
model.Items.Should().BeEmpty()
(model.Amount > 0).Should().BeTrue();
model.Amount.Should().BePositive();

What's wrong with these transformations?

[bkqc]

From what I understand, the role of FAA0001 is to Simplify Assertions that are uselessly complex when there is a simpler/cleaner/more readable way of doing it. Wouldn't you say that
model.Items.Should().BeEmpty();is more readable than (model.Items.Count == 0).Should().BeTrue(); ?

Same for
(model.Amount > 0).Should().BeTrue(); and model.Amount.Should().BePositive();

Unless you were referring to the comment at the top of the opening post in which case it was only in relation with other points (like fourth and fifth) where I was able to cite the pre FAA0003 version. In which case there is nothing wrong per se with the transformation. Only that it can be simplified. There are other transformations like that which require a 2-steps correction path (from non Fluent to Fluent then simplified) and I live well with having to do this two steps process.

On the other hand there are no simplification warning at all for any final form to the simplified form for thos I mentionned.

I hope I was able to make it clearer...

[Meir017]

@bkqc I might have understood you the wrong way.

What was the original input and what was the output? I thought you meant that the code (model.Items.Count == 0).Should().BeTrue(); was converted to be model.Items.Should().BeEmpty();

[bkqc]

For the 2 first cases, I had something (which I didn't note unfortunately) that FAA0003 automatically changed to (model.Items.Count == 0).Should().BeTrue();.

What I'm saying is that there was no FAA0001 recommendation then to simplify it to model.Items.Should().BeEmpty();

[Meir017]

@bkqc can you share a complete code sample? With the type definitions