From 3b32175b2e2c27ff56386028889d878d554b6d8a Mon Sep 17 00:00:00 2001 From: Md Mushfiqur Rahim <20mahin2020@gmail.com> Date: Fri, 22 May 2026 06:11:23 +0000 Subject: [PATCH 1/2] fix: log file write and close errors in debug image protocol logger --- view/html.go | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/view/html.go b/view/html.go index fce56661..749fc532 100644 --- a/view/html.go +++ b/view/html.go @@ -4,6 +4,7 @@ import ( "encoding/base64" "fmt" "io" + "log" "mime/quotedprintable" "os" "regexp" @@ -277,13 +278,21 @@ func debugImageProtocol(format string, args ...interface{}) { loglevel.Infof("%s", strings.TrimSuffix(msg, "\n")) if path := os.Getenv("DEBUG_IMAGE_PROTOCOL_LOG"); path != "" { if f, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644); err == nil { - _, _ = f.WriteString(msg) - _ = f.Close() + if _, err := f.WriteString(msg); err != nil { + log.Printf("debug log write error: %v", err) + } + if err := f.Close(); err != nil { + log.Printf("debug log close error: %v", err) + } } } else if path := os.Getenv("DEBUG_KITTY_LOG"); path != "" { if f, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644); err == nil { - _, _ = f.WriteString(msg) - _ = f.Close() + if _, err := f.WriteString(msg); err != nil { + log.Printf("debug log write error: %v", err) + } + if err := f.Close(); err != nil { + log.Printf("debug log close error: %v", err) + } } } } From e8189c0c3c59a30f5885741cb71bd21932da3c83 Mon Sep 17 00:00:00 2001 From: FromSi Date: Sun, 24 May 2026 22:04:50 +0500 Subject: [PATCH 2/2] fix(view): refine debug error logs --- view/html.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/view/html.go b/view/html.go index 7c472f97..3600677d 100644 --- a/view/html.go +++ b/view/html.go @@ -267,19 +267,19 @@ func debugImageProtocol(format string, args ...interface{}) { if path := os.Getenv("DEBUG_IMAGE_PROTOCOL_LOG"); path != "" { if f, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644); err == nil { //nolint:gosec if _, err := f.WriteString(msg); err != nil { - loglevel.Debugf("debug log write error: %v", err) + loglevel.Debugf("image protocol write error: %v", err) } if err := f.Close(); err != nil { - loglevel.Debugf("debug log close error: %v", err) + loglevel.Debugf("image protocol close error: %v", err) } } } else if path := os.Getenv("DEBUG_KITTY_LOG"); path != "" { if f, err := os.OpenFile(path, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644); err == nil { //nolint:gosec if _, err := f.WriteString(msg); err != nil { - loglevel.Debugf("debug log write error: %v", err) + loglevel.Debugf("image protocol write error: %v", err) } if err := f.Close(); err != nil { - loglevel.Debugf("debug log close error: %v", err) + loglevel.Debugf("image protocol close error: %v", err) } } }