fix: close DEBUG_IMAP file descriptor on shutdown#1337
Open
MD-Mushfiqur123 wants to merge 1 commit into
Open
Conversation
floatpanebot
requested changes
May 22, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @MD-Mushfiqur123! Please fix the following issues with your PR:
- Title: Is too long (49 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
floatpanebot
added
area/fetcher
FromSi
requested changes
May 23, 2026
| args, level := parseGlobalFlags(os.Args) | ||
| os.Args = args | ||
| loglevel.Set(level) | ||
| defer fetcher.CloseDebugFiles() |
Member
There was a problem hiding this comment.
defer is not enough here because many paths in main() exit via os.Exit(...), and Go does not run deferred calls on os.Exit. For example, matcha daemon run can open DEBUG_IMAP, then return through runDaemonCLI and hit os.Exit(0), so CloseDebugFiles() is skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #715. Adds fetcher.CloseDebugFiles() to close the DEBUG_IMAP file handle on application shutdown, preventing a file descriptor leak for the application lifetime.