From c27398e3139e64bc7652145349cba3da36e553e2 Mon Sep 17 00:00:00 2001 From: Md Mushfiqur Rahim <20mahin2020@gmail.com> Date: Fri, 22 May 2026 06:06:40 +0000 Subject: [PATCH 1/4] fix: check errors from os.Remove and os.Chmod in daemon startup --- daemon/daemon.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/daemon/daemon.go b/daemon/daemon.go index 20cdfb88..c48e4f36 100644 --- a/daemon/daemon.go +++ b/daemon/daemon.go @@ -87,7 +87,9 @@ func (d *Daemon) Run() error { // Remove stale socket file. sockPath := daemonrpc.SocketPath() - os.Remove(sockPath) + if err := os.Remove(sockPath); err != nil && !os.IsNotExist(err) { + return fmt.Errorf("remove stale socket: %w", err) + } // Listen on Unix domain socket. var err error @@ -98,7 +100,9 @@ func (d *Daemon) Run() error { defer d.listener.Close() // Set socket permissions (owner only). - os.Chmod(sockPath, 0700) + if err := os.Chmod(sockPath, 0700); err != nil { + return fmt.Errorf("set socket permissions: %w", err) + } log.Printf("daemon: listening on %s (PID %d)", sockPath, os.Getpid()) From 024a4f031de8879d4aec89d240edf31ccf0786c1 Mon Sep 17 00:00:00 2001 From: FromSi Date: Sun, 24 May 2026 20:30:35 +0500 Subject: [PATCH 2/4] fix(daemon): use safer socket mode --- daemon/daemon.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/daemon.go b/daemon/daemon.go index 6c84646c..0aabf2b9 100644 --- a/daemon/daemon.go +++ b/daemon/daemon.go @@ -102,7 +102,7 @@ func (d *Daemon) Run() error { defer d.listener.Close() //nolint:errcheck // Set socket permissions (owner only). - if err := os.Chmod(sockPath, 0700); err != nil { + if err := os.Chmod(sockPath, 0700); err != nil { //nolint:gosec return fmt.Errorf("set socket permissions: %w", err) } From f568115c39d1c20a87f94de4a91004db4ff01092 Mon Sep 17 00:00:00 2001 From: FromSi Date: Sun, 24 May 2026 20:44:52 +0500 Subject: [PATCH 3/4] fix(daemon): document socket mode --- daemon/daemon.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/daemon.go b/daemon/daemon.go index 0aabf2b9..e27103e1 100644 --- a/daemon/daemon.go +++ b/daemon/daemon.go @@ -102,7 +102,7 @@ func (d *Daemon) Run() error { defer d.listener.Close() //nolint:errcheck // Set socket permissions (owner only). - if err := os.Chmod(sockPath, 0700); err != nil { //nolint:gosec + if err := os.Chmod(sockPath, 0700); err != nil { //nolint:errcheck,gosec return fmt.Errorf("set socket permissions: %w", err) } From 71bc66ceb1bc8455a3b0fa82f07a1dd91a2805a3 Mon Sep 17 00:00:00 2001 From: FromSi Date: Sun, 24 May 2026 20:50:41 +0500 Subject: [PATCH 4/4] fix(daemon): document socket mode --- daemon/daemon.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/daemon.go b/daemon/daemon.go index e27103e1..0fcbe5b4 100644 --- a/daemon/daemon.go +++ b/daemon/daemon.go @@ -102,7 +102,7 @@ func (d *Daemon) Run() error { defer d.listener.Close() //nolint:errcheck // Set socket permissions (owner only). - if err := os.Chmod(sockPath, 0700); err != nil { //nolint:errcheck,gosec + if err := os.Chmod(sockPath, 0700); err != nil { // #nosec G302 return fmt.Errorf("set socket permissions: %w", err) }