-
-
Notifications
You must be signed in to change notification settings - Fork 72
BUG: Unchecked outFile.Close() error in runUpdateCLI #861
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingchoreMaintenance, refactor, cleanupMaintenance, refactor, cleanupgood first issueGood for newcomersGood for newcomersneeds-responseWaiting on issue author replyWaiting on issue author replystaleNo activity for extended periodNo activity for extended period
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingchoreMaintenance, refactor, cleanupMaintenance, refactor, cleanupgood first issueGood for newcomersGood for newcomersneeds-responseWaiting on issue author replyWaiting on issue author replystaleNo activity for extended periodNo activity for extended period
Type
Fields
Give feedbackNo fields configured for issues without a type.
Projects
Status
Backlog
Describe the bug
In
runUpdateCLI()(main.go:3310), after writing the downloaded asset to disk withio.Copy,outFile.Close()is called without checking the returned error. If Close() fails (e.g., disk full), the written data may be incomplete but the update proceeds.To reproduce
Expected behavior
outFile.Close()error should be checked and returned if non-nil.