New test for previous flow_rates

Author: FBumann

flixopt/elements.py

@@ -199,6 +199,7 @@ def __init__(
                 If the load-profile is just an upper limit, use relative_maximum instead.
             previous_flow_rate: previous flow rate of the flow. Used to determine if and how long the
                 flow is already on / off. If None, the flow is considered to be off for one timestep.
+                Currently does not support different values in different years or scenarios!
             meta_data: used to store more information about the Element. Is not used internally, but saved in the results. Only use python native types.
         """
         super().__init__(label, meta_data=meta_data)
@@ -305,7 +306,8 @@ def _plausibility_checks(self) -> None:
                 ]
             ):
                 raise TypeError(
-                    f'previous_flow_rate must be None, a scalar, a list of scalars or a 1D-numpy-array. Got {type(self.previous_flow_rate)}'
+                    f'previous_flow_rate must be None, a scalar, a list of scalars or a 1D-numpy-array. Got {type(self.previous_flow_rate)}.'
+                    f'Different values in different years or scenarios are not yetsupported.'
                 )
 
     @property

tests/test_component.py

@@ -349,8 +349,26 @@ def test_previous_states_with_multiple_flows(self, basic_flow_system_linopy_coor
             + 1e-5,
         )
 
-    def test_previous_states_with_multiple_flows_2(self, basic_flow_system_linopy_coords, coords_config):
-        """Test that flow model constraints are correctly generated."""
+    @pytest.mark.parametrize(
+        'in1_previous_flow_rate, out1_previous_flow_rate, out2_previous_flow_rate, previous_on_hours',
+        [
+            (None, None, None, 0),
+            (np.array([0, 1e-6, 1e-4, 5]), None, None, 2),
+            (np.array([0, 5, 0, 5]), None, None, 1),
+            (np.array([0, 5, 0, 0]), 3, 0, 1),
+            (np.array([0, 0, 2, 0, 4, 5]), [3, 4, 5], None, 4),
+        ],
+    )
+    def test_previous_states_with_multiple_flows_parameterized(
+        self,
+        basic_flow_system_linopy_coords,
+        coords_config,
+        in1_previous_flow_rate,
+        out1_previous_flow_rate,
+        out2_previous_flow_rate,
+        previous_on_hours,
+    ):
+        """Test that flow model constraints are correctly generated with different previous flow rates and constraint factors."""
         flow_system, coords_config = basic_flow_system_linopy_coords, coords_config
 
         ub_out2 = np.linspace(1, 1.5, 10).round(2)
@@ -360,19 +378,21 @@ def test_previous_states_with_multiple_flows_2(self, basic_flow_system_linopy_co
                 'Fernwärme',
                 relative_minimum=np.ones(10) * 0.1,
                 size=100,
-                previous_flow_rate=np.array([0, 0, 1e-6, 1e-5, 1e-4, 3, 4]),
+                previous_flow_rate=in1_previous_flow_rate,
                 on_off_parameters=fx.OnOffParameters(consecutive_on_hours_min=3),
             ),
         ]
         outputs = [
-            fx.Flow('Out1', 'Gas', relative_minimum=np.ones(10) * 0.2, size=200, previous_flow_rate=[3, 4, 5]),
+            fx.Flow(
+                'Out1', 'Gas', relative_minimum=np.ones(10) * 0.2, size=200, previous_flow_rate=out1_previous_flow_rate
+            ),
             fx.Flow(
                 'Out2',
                 'Gas',
                 relative_minimum=np.ones(10) * 0.3,
                 relative_maximum=ub_out2,
                 size=300,
-                previous_flow_rate=20,
+                previous_flow_rate=out2_previous_flow_rate,
             ),
         ]
         comp = flixopt.elements.Component(
@@ -387,7 +407,7 @@ def test_previous_states_with_multiple_flows_2(self, basic_flow_system_linopy_co
         assert_conequal(
             comp.submodel.constraints['TestComponent|consecutive_on_hours|initial'],
             comp.submodel.variables['TestComponent|consecutive_on_hours'].isel(time=0)
-            == comp.submodel.variables['TestComponent|on'].isel(time=0) * 5,
+            == comp.submodel.variables['TestComponent|on'].isel(time=0) * (previous_on_hours + 1),
         )