Skip to content

Commit 648e05e

Browse files
committed
additional tests. restart from #84
2 parents 2a68828 + 6de7fc6 commit 648e05e

2 files changed

Lines changed: 18 additions & 5 deletions

File tree

ob-sql-session-tests.el

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,16 @@ database\nHGNC\nFlyBase\n"))
198198
"Expand variable."
199199
(pg-test "select $var as var;" "var\n33\n"))
200200

201+
(ert-deftest pg-X:test-close-session()
202+
(with-current-buffer "*SQL: [pg::tests]*" ; sqlite:///nil*"
203+
(quit-process nil t)
204+
(let ((kill-buffer-query-functions nil))
205+
(kill-this-buffer))))
206+
201207
;; (eval-buffer)
202208
;; (ert :new)
203209
;; (ert t)
204210
;; (ert-delete-all-tests)
205211
;; (with-current-buffer "ob-sql.el" (save-buffer))
206212
;; (progn (ert-delete-all-tests)(eval-buffer)(ert :new))
213+

ob-sql.el

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,18 +76,22 @@
7676
;;; Code:
7777

7878
(require 'org-macs)
79+
(org-assert-version)
7980
(require 'ob)
8081
(require 'sql)
8182

82-
(defvar sql-connection-alist)
8383

84+
(defvar org-babel-sql-session-start-time)
8485
(defvar org-sql-session-preamble
85-
(list 'postgres "\\set ON_ERROR_STOP 1
86+
(list
87+
'postgres "\\set ON_ERROR_STOP 1
8688
\\pset footer off
8789
\\pset pager off
8890
\\pset format unaligned")
8991
"Command preamble to run upon shell start.")
90-
(defvar ob-sql-batch-terminate
92+
(defvar org-sql-session-command-terminated nil)
93+
(defvar org-sql-session--batch-terminate "---#" "To print at the end of a command batch.")
94+
(defvar org-sql-batch-terminate
9195
(list 'sqlite (format ".print %s\n" org-sql-session--batch-terminate)
9296
'postgres (format "\\echo %s\n" org-sql-session--batch-terminate))
9397
"Print the command batch termination as last command.")
@@ -107,7 +111,8 @@
107111
(declare-function orgtbl-to-csv "org-table" (table params))
108112
(declare-function org-table-to-lisp "org-table" (&optional txt))
109113
(declare-function cygwin-convert-file-name-to-windows "cygw32.c" (file &optional absolute-p))
110-
(declare-function sql-set-product "sql" (product))
114+
115+
(defvar sql-connection-alist)
111116

112117
(defcustom org-babel-default-header-args:sql '((:engine . "unset"))
113118
"Default header args."
@@ -532,7 +537,8 @@ argument mechanism."
532537
vars)
533538
body)
534539

535-
(defun org-sql-session-connect (in-engine params session)
540+
541+
(defun org-babel-sql-session-connect (in-engine params session)
536542
"Start the SQL client of IN-ENGINE if it has not.
537543
PARAMS provides the sql connection parameters for a new or
538544
existing SESSION. Clear the intermediate buffer from previous

0 commit comments

Comments
 (0)