ncclAllReduce may require additional barriers #1587
Description
A thread on Zulip mentioned some additional care required for NCCL within a Legion task. Rohan spotted a problem in FlexFlow's use of ncclAllReduce. You may need to add concurrent_task_barrier before and after the call, and call set_concurrent_barrier on the task. More info is in the comment for that barrier.