Fixing issues flagged by Coverity

Author: flamewing

include/mdcomp/bigendian_io.hh

@@ -232,8 +232,8 @@ namespace detail {
             uint_t byte2 = new_value & mask2;
             new_value    = static_cast<uint_t>(
                     new_value ^ byte1 ^ byte2 ^ (byte1 << diff) ^ (byte2 >> diff));
-            mask1 = static_cast<uint_t>(mask1 << nbits);
-            mask2 = static_cast<uint_t>(mask2 >> nbits);
+            mask1 = std::rotl(mask1, nbits);
+            mask2 = std::rotr(mask2, nbits);
             diff -= 2ULL * nbits;
         }
         return uint_t(new_value & std::numeric_limits<uint_t>::max());

include/mdcomp/options_lib.hh

@@ -20,9 +20,6 @@
 
 #include <getopt.h>
 
-#include <boost/io/ios_state.hpp>
-#include <boost/io_fwd.hpp>
-
 #include <array>
 #include <charconv>
 #include <concepts>    // IWYU pragma: keep
@@ -325,9 +322,8 @@ namespace detail {
 
     template <typename instream, typename outstream, typename options_t>
     inline void do_decode(instream& input, outstream& output, options_t const& options) {
-        auto const do_print_end = [&]() noexcept {
+        auto const do_print_end = [&]() {
             if constexpr (has_print_end<options_t>) {
-                boost::io::ios_all_saver const flags(std::cout);
                 std::cout << std::format("0x{:06x}", static_cast<size_t>(input.tellg()));
             }
         };

src/lib/nemesis.cc

@@ -910,7 +910,7 @@ class nemesis_internal {
                     next_coins.push(make_shared<node>(child0, child1));
                 }
                 index++;
-                current_coins = next_coins;
+                current_coins = std::move(next_coins);
             }
 
             // The Coin Collector's problem has been solved. Now it is time to
@@ -1016,7 +1016,7 @@ class nemesis_internal {
             // Is this iteration better than the best?
             if (temp_size_est < size_est) {
                 // If yes, save the code_map and file size.
-                code_map = temp_code_map;
+                code_map = std::move(temp_code_map);
                 size_est = temp_size_est;
             }
         }