Merge pull request #333 from peterjeschke/bugfix/ffmpeg

Remove fluent-ffmpeg and directly invoke ffmpeg instead

Author: dahlia

CHANGES.md

@@ -98,24 +98,31 @@ To be released.
     `text/plain`.
 
  -  Implemented Mastodon 4.5.0 quote notification types (`quote` and
-    `quoted_update`) for improved quote post interaction tracking.
-    Users now receive notifications when their posts are quoted by others
-    and when posts they've quoted are edited by the original authors.
-    Key features include:
-
-     -  Added `quote` notification type that triggers when someone quotes
-        your post, with the notification showing the quote post itself.
-     -  Added `quoted_update` notification type that triggers when a post
-        you quoted is edited, with the notification showing your quote post
-        to provide context.
-     -  Both notification types are non-groupable, meaning each quote or edit
-        generates an individual notification for better visibility.
-     -  Self-quotes (quoting your own posts) do not generate notifications
-        to avoid unnecessary noise.
-     -  Existing quote posts are automatically backfilled with notifications
-        during migration to ensure consistent notification history.
-     -  Added database index on `posts.quote_target_id` for improved query
-        performance when looking up quote relationships.
+     `quoted_update`) for improved quote post interaction tracking.
+     Users now receive notifications when their posts are quoted by others
+     and when posts they've quoted are edited by the original authors.
+     Key features include:
+
+      -  Added `quote` notification type that triggers when someone quotes
+         your post, with the notification showing the quote post itself.
+      -  Added `quoted_update` notification type that triggers when a post
+         you quoted is edited, with the notification showing your quote post
+         to provide context.
+      -  Both notification types are non-groupable, meaning each quote or edit
+         generates an individual notification for better visibility.
+      -  Self-quotes (quoting your own posts) do not generate notifications
+         to avoid unnecessary noise.
+      -  Existing quote posts are automatically backfilled with notifications
+         during migration to ensure consistent notification history.
+      -  Added database index on `posts.quote_target_id` for improved query
+         performance when looking up quote relationships.
+
+ -  Removed dependency on deprecated *fluent-ffmpeg* package and now invoke
+    ffmpeg binary directly for video screenshot generation.  This change
+    improves reliability by preventing request failures when video screenshot
+    generation encounters errors.  On failure, a default screenshot (Hollo
+    logo) is now returned instead of aborting the entire upload request, and
+    ffmpeg error output is logged for debugging.  [[#333] by Peter Jeschke]
 
 [#94]: https://github.com/fedify-dev/hollo/issues/94
 [#312]: https://github.com/fedify-dev/hollo/issues/312
@@ -126,6 +133,7 @@ To be released.
 [#179]: https://github.com/fedify-dev/hollo/pull/179
 [#295]: https://github.com/fedify-dev/hollo/pull/295
 [#296]: https://github.com/fedify-dev/hollo/pull/296
+[#333]: https://github.com/fedify-dev/hollo/pull/333
 
 
 Version 0.6.19

Dockerfile

@@ -1,4 +1,4 @@
-FROM docker.io/node:24.0-alpine
+FROM docker.io/node:24-alpine
 
 LABEL org.opencontainers.image.title="Hollo"
 LABEL org.opencontainers.image.description="Federated single-user \

assets/default-screenshot.png

@@ -44,7 +44,6 @@
     "drizzle-kit": "^0.31.8",
     "drizzle-orm": "^0.45.0",
     "es-toolkit": "^1.44.0",
-    "fluent-ffmpeg": "^2.1.3",
     "flydrive": "^1.3.0",
     "hono": "^4.11.4",
     "iso-639-1": "^3.1.5",

package.json

@@ -1,11 +1,15 @@
-import { mkdtemp, readFile, writeFile } from "node:fs/promises";
-import { tmpdir } from "node:os";
+import { spawn } from "node:child_process";
+import { readFileSync } from "node:fs";
 import { join } from "node:path";
-import ffmpeg from "fluent-ffmpeg";
+import { getLogger } from "@logtape/logtape";
 import type { Sharp } from "sharp";
 import { drive } from "./storage";
 
+const logger = getLogger(["hollo", "media"]);
 const DEFAULT_THUMBNAIL_AREA = 230_400;
+const defaultScreenshot = readFileSync(
+  join(import.meta.dirname, "..", "assets", "default-screenshot.png"),
+);
 
 export interface Thumbnail {
   thumbnailUrl: string;
@@ -74,18 +78,59 @@ export function calculateThumbnailSize(
 export async function makeVideoScreenshot(
   videoData: Uint8Array,
 ): Promise<Uint8Array> {
-  const tmpDir = await mkdtemp(join(tmpdir(), "hollo-"));
-  const inFile = join(tmpDir, "video");
-  await writeFile(inFile, videoData);
-  await new Promise((resolve) =>
-    ffmpeg(inFile)
-      .on("end", resolve)
-      .screenshots({
-        timestamps: [0],
-        filename: "screenshot.png",
-        folder: tmpDir,
-      }),
-  );
-  const screenshot = await readFile(join(tmpDir, "screenshot.png"));
-  return new Uint8Array(screenshot.buffer);
+  const resultBuffer: Buffer = await new Promise((resolve, _) => {
+    const process = spawn("ffmpeg", [
+      "-i",
+      "pipe:0",
+      "-vframes",
+      "1",
+      "-f",
+      "image2pipe",
+      "pipe:1",
+    ]);
+    const stdin = process.stdin;
+    const stdout = process.stdout;
+    const stderr = process.stderr;
+    const chunks: Buffer[] = [];
+    const stderrChunks: Buffer[] = [];
+    if (!stdin || !stdout || !stderr) {
+      logger.error(
+        "Could not build pipes to ffmpeg, can't create a video screenshot",
+      );
+      logger.error("ffmpeg output: {stderr}", {
+        stderr: Buffer.concat(stderrChunks).toString(),
+      });
+      resolve(defaultScreenshot);
+    }
+    stdout.on("data", (chunk) => {
+      chunks.push(chunk);
+    });
+    stderr.on("data", (chunk) => {
+      stderrChunks.push(chunk);
+    });
+    process.on("close", (code) => {
+      if (code !== 0) {
+        logger.error("ffmpeg returned a bad error code {code}", { code });
+        logger.error("ffmpeg output: {stderr}", {
+          stderr: Buffer.concat(stderrChunks).toString(),
+        });
+        resolve(defaultScreenshot);
+      }
+      resolve(Buffer.concat(chunks));
+    });
+    process.on("error", (error) => {
+      logger.error("Could not run ffmpeg: {error}", { error });
+      logger.error("ffmpeg output: {stderr}", {
+        stderr: Buffer.concat(stderrChunks).toString(),
+      });
+      resolve(defaultScreenshot);
+    });
+    stdin.on("error", (_) => {
+      // probably a EPIPE because ffmpeg does not consume the whole file; swallow it here
+    });
+
+    stdin.write(videoData);
+    stdin.end();
+  });
+  return resultBuffer;
 }