Refactor lookup test exclusion rules

Consolidate lookup-test-only exclusions into a single pattern-based rule table so framework-wide and combination-specific bans follow the same matching logic. This keeps the supported-option checks unchanged while making the temporary lookup exclusions easier to maintain.

Add regression tests for lookup case parsing and wildcard-based filtering.

Co-Authored-By: OpenAI Codex <noreply@openai.com>

Author: dodok8

packages/init/src/lookup-filter.test.ts

@@ -0,0 +1,54 @@
+import { assertEquals } from "@std/assert";
+import { join } from "node:path";
+import { test } from "node:test";
+import {
+  filterLookupDirs,
+  getBannedLookupFrameworks,
+  matchesLookupCasePattern,
+  parseLookupCase,
+} from "./test/lookup.ts";
+
+test("parseLookupCase() parses the last four path segments", () => {
+  assertEquals(
+    parseLookupCase(join("/tmp", "cases", "hono", "deno", "denokv", "redis")),
+    ["hono", "deno", "denokv", "redis"],
+  );
+});
+
+test("matchesLookupCasePattern() supports wildcards", () => {
+  assertEquals(
+    matchesLookupCasePattern(
+      ["solidstart", "deno", "*", "*"],
+      ["solidstart", "deno", "postgres", "redis"],
+    ),
+    true,
+  );
+  assertEquals(
+    matchesLookupCasePattern(
+      ["solidstart", "deno", "*", "*"],
+      ["solidstart", "npm", "postgres", "redis"],
+    ),
+    false,
+  );
+});
+
+test("filterLookupDirs() excludes banned lookup cases only", () => {
+  const dirs = [
+    join("/tmp", "cases", "next", "pnpm", "postgres", "redis"),
+    join("/tmp", "cases", "solidstart", "deno", "postgres", "redis"),
+    join("/tmp", "cases", "solidstart", "npm", "postgres", "redis"),
+    join("/tmp", "cases", "hono", "deno", "denokv", "denokv"),
+  ];
+
+  assertEquals(
+    filterLookupDirs(dirs),
+    [
+      join("/tmp", "cases", "solidstart", "npm", "postgres", "redis"),
+      join("/tmp", "cases", "hono", "deno", "denokv", "denokv"),
+    ],
+  );
+});
+
+test("getBannedLookupFrameworks() returns framework-wide bans", () => {
+  assertEquals(getBannedLookupFrameworks(), ["next"]);
+});

packages/init/src/test/lookup.ts

@@ -19,9 +19,16 @@ import webFrameworks from "../webframeworks/mod.ts";
 const HANDLE = "john";
 const STARTUP_TIMEOUT = 30000; // 30 seconds
 const CWD = process.cwd();
-const BANNED_WFS: WebFramework[] = ["next"];
-const BANNED_COMBOS: [WebFramework, PackageManager][] = [
-  ["solidstart", "deno"],
+type LookupCase = [WebFramework, PackageManager, KvStore, MessageQueue];
+type LookupCasePattern = [
+  WebFramework | "*",
+  PackageManager | "*",
+  KvStore | "*",
+  MessageQueue | "*",
+];
+const BANNED_LOOKUP_CASES: LookupCasePattern[] = [
+  ["next", "*", "*", "*"],
+  ["solidstart", "deno", "*", "*"],
 ];
 
 /**
@@ -37,7 +44,7 @@ export default async function runServerAndLookupUser(
     printErrorMessage`\nNo directories to lookup test.`;
     return;
   }
-  const filtered = filterWebFrameworks(valid);
+  const filtered = filterLookupDirs(valid);
 
   printMessage`\nLookup Test start for ${String(filtered.length)} app(s)!`;
 
@@ -52,38 +59,50 @@ export default async function runServerAndLookupUser(
   Failed: ${String(failCount)}\n\n`;
 }
 
-function filterWebFrameworks(
+export function parseLookupCase(dir: string): LookupCase {
+  return dir.split(sep).slice(-4) as LookupCase;
+}
+
+export function matchesLookupCasePattern(
+  pattern: LookupCasePattern,
+  target: LookupCase,
+): boolean {
+  return pattern.every((value, index) =>
+    value === "*" || value === target[index]
+  );
+}
+
+export function getBannedLookupFrameworks(): WebFramework[] {
+  return BANNED_LOOKUP_CASES
+    .filter(([, pm, kv, mq]) => pm === "*" && kv === "*" && mq === "*")
+    .map(([wf]) => wf as WebFramework);
+}
+
+export function filterLookupDirs(
   dirs: string[],
 ): string[] {
   const wfs = new Set<WebFramework>(
-    dirs.map((dir) => dir.split(sep).slice(-4, -3)[0] as WebFramework),
+    dirs.map((dir) => parseLookupCase(dir)[0]),
   );
-  const hasBanned = BANNED_WFS.filter((wf) => wfs.has(wf));
+  const hasBanned = getBannedLookupFrameworks().filter((wf) => wfs.has(wf));
   if (!isEmpty(hasBanned)) {
     const bannedLabels = hasBanned.map((wf) => webFrameworks[wf]["label"]);
     printErrorMessage`\n${
       values(bannedLabels)
     } is not supported in lookup test yet.`;
   }
-  return dirs.filter((dir) => {
-    const [wf, pm] = dir.split(sep).slice(-4, -2) as [
-      WebFramework,
-      PackageManager,
-    ];
-    if (BANNED_WFS.includes(wf)) return false;
-    if (BANNED_COMBOS.some(([bwf, bpm]) => bwf === wf && bpm === pm)) {
-      return false;
-    }
-    return true;
-  });
+  return dirs.filter((dir) =>
+    !BANNED_LOOKUP_CASES.some((pattern) =>
+      matchesLookupCasePattern(pattern, parseLookupCase(dir))
+    )
+  );
 }
 
 /**
  * Run the dev server and test with lookup command.
  */
 async function testApp(dir: string): Promise<boolean> {
-  const [wf, pm, kv, mq] = dir.split(sep).slice(-4) as //
-  [WebFramework, PackageManager, KvStore, MessageQueue];
+  const [wf, pm, kv, mq] = parseLookupCase(dir);
 
   printMessage`  Testing ${values([wf, pm, kv, mq])}...`;
 
@@ -98,7 +117,7 @@ async function testApp(dir: string): Promise<boolean> {
   }!`;
   if (!result) {
     printMessage`    Check out these files for more details:
-      ${join(dir, "out.txt")} and 
+      ${join(dir, "out.txt")} and
       ${join(dir, "err.txt")}\n`;
   }
   printMessage`\n`;