-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathcommit_message.txt
More file actions
13 lines (9 loc) · 847 Bytes
/
commit_message.txt
File metadata and controls
13 lines (9 loc) · 847 Bytes
1
2
3
4
5
6
7
8
9
10
11
12
13
🏗️ Architect: Centralize Study Key Validation
🏗️ Design Change:
Simplified `KeepStudyKeyStrategy` and `PopStudyKeyStrategy` by moving the logic that raises `ClientError` for a missing study key fully to `EndpointABC._validate_study_key()`, rather than keeping duplicate exception handling in the strategies.
♻️ DRY Gains:
Eliminated duplicate validation code; removed `exception_cls` argument dependency, ensuring all study key presence validations are centralized exactly in one place without dual execution.
🛡️ Solidity:
Reduced logical complexity inside strategies which are now purely responsible for property extraction / state mutation, strictly adhering to Single Responsibility Principle.
⚠️ Breaking Changes:
None. The validation is identical but now occurs consistently in `EndpointABC._validate_study_key()`.