wsgi: properly pass through requests headers#24
Merged
Conversation
posborne
force-pushed
the
posborne/wsgi-http-headers
branch
from
41968b2 to
891c550
Compare
erikrose
approved these changes
Dec 11, 2025
| environ[wsgi_key] = header_value_str | ||
|
|
||
| # If there are more headers, continue with next cursor | ||
| if next_cursor is None: |
Member
There was a problem hiding this comment.
Why not float this test up to the while condition, e.g. while cursor is not None?
Member
Author
There was a problem hiding this comment.
I considered it but you would need to have an extra assignment of the value outside the loop in addition to inside the loop (basically, python doesn't have do-while or assignments with checks in the loop header).
I think it's probably better as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.